[java-identity-provider] 02/02: IDP-1515 Make several attribute api classes final
Rod Widdowson
rdw at steadingsoftware.com
Sun Nov 10 07:59:36 EST 2019
This is an automated email from the git hooks/post-receive script.
rdw pushed a commit to branch master
in repository java-identity-provider.
View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=3edee8ff530e3ab1a95cc05c9ef6f0da372a46f1
commit 3edee8ff530e3ab1a95cc05c9ef6f0da372a46f1
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Sun Nov 10 12:53:18 2019 +0000
IDP-1515 Make several attribute api classes final
https://issues.shibboleth.net/jira/browse/IDP-1515
---
.../main/java/net/shibboleth/idp/attribute/AttributesMapContainer.java | 2 +-
.../src/main/java/net/shibboleth/idp/attribute/ByteAttributeValue.java | 2 +-
.../main/java/net/shibboleth/idp/attribute/IdPRequestedAttribute.java | 2 +-
.../src/main/java/net/shibboleth/idp/attribute/PairwiseId.java | 2 +-
.../java/net/shibboleth/idp/attribute/ScopedStringAttributeValue.java | 2 +-
.../main/java/net/shibboleth/idp/attribute/XMLObjectAttributeValue.java | 2 +-
.../java/net/shibboleth/idp/attribute/transcoding/TranscodingRule.java | 2 +-
7 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/AttributesMapContainer.java b/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/AttributesMapContainer.java
index cc0b798..b39c52f 100644
--- a/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/AttributesMapContainer.java
+++ b/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/AttributesMapContainer.java
@@ -24,7 +24,7 @@ import com.google.common.collect.Multimap;
* Container for decoded attributes. This gives us a distinguished class to look for in the
* {@link org.opensaml.core.xml.XMLObject#getObjectMetadata()}.
*/
-public class AttributesMapContainer implements Supplier<Multimap<String,IdPAttribute>> {
+public final class AttributesMapContainer implements Supplier<Multimap<String,IdPAttribute>> {
/** The map we are encapsulating.*/
private final Multimap<String,IdPAttribute> providedValue;
diff --git a/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/ByteAttributeValue.java b/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/ByteAttributeValue.java
index 32d975a..6003aec 100644
--- a/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/ByteAttributeValue.java
+++ b/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/ByteAttributeValue.java
@@ -32,7 +32,7 @@ import org.apache.commons.codec.binary.Hex;
import com.google.common.base.MoreObjects;
/** A <code>byte[]</code> value for an {@link IdPAttribute}. */
-public class ByteAttributeValue implements IdPAttributeValue {
+public final class ByteAttributeValue implements IdPAttributeValue {
/** Value of the attribute. */
private final byte[] value;
diff --git a/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/IdPRequestedAttribute.java b/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/IdPRequestedAttribute.java
index 454b79f..f167686 100644
--- a/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/IdPRequestedAttribute.java
+++ b/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/IdPRequestedAttribute.java
@@ -22,7 +22,7 @@ import net.shibboleth.utilities.java.support.annotation.ParameterName;
/**
* IdP Representation of the SAML2 RequestedAttribute.
*/
-public class IdPRequestedAttribute extends IdPAttribute {
+public final class IdPRequestedAttribute extends IdPAttribute {
/** Is this attribute required. */
private boolean isRequired;
diff --git a/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/PairwiseId.java b/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/PairwiseId.java
index e4f2a9f..a2b46b6 100644
--- a/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/PairwiseId.java
+++ b/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/PairwiseId.java
@@ -26,7 +26,7 @@ import javax.annotation.Nullable;
*
* @since 4.0.0
*/
-public class PairwiseId {
+public final class PairwiseId {
/** ID of the entity that issued that identifier. */
@Nullable private String issuerEntityID;
diff --git a/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/ScopedStringAttributeValue.java b/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/ScopedStringAttributeValue.java
index 08903de..bc29f02 100644
--- a/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/ScopedStringAttributeValue.java
+++ b/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/ScopedStringAttributeValue.java
@@ -32,7 +32,7 @@ import com.google.common.base.Objects;
/** An attribute value with an associated scope. */
@ThreadSafe
-public class ScopedStringAttributeValue extends StringAttributeValue {
+public final class ScopedStringAttributeValue extends StringAttributeValue {
/** Scope of the attribute value. */
private final String scope;
diff --git a/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/XMLObjectAttributeValue.java b/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/XMLObjectAttributeValue.java
index 5360e39..52ff304 100644
--- a/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/XMLObjectAttributeValue.java
+++ b/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/XMLObjectAttributeValue.java
@@ -30,7 +30,7 @@ import org.opensaml.saml.saml2.core.NameIDType;
import com.google.common.base.MoreObjects;
/** A {@link XMLObjectAttributeValue} value for an {@link net.shibboleth.idp.attribute.IdPAttribute}. */
-public class XMLObjectAttributeValue implements IdPAttributeValue {
+public final class XMLObjectAttributeValue implements IdPAttributeValue {
/** Value of the attribute. */
private final XMLObject value;
diff --git a/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/transcoding/TranscodingRule.java b/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/transcoding/TranscodingRule.java
index 37026d7..7277350 100644
--- a/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/transcoding/TranscodingRule.java
+++ b/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/transcoding/TranscodingRule.java
@@ -45,7 +45,7 @@ import net.shibboleth.idp.attribute.IdPAttribute;
* Wrapper around a {@link Map} representing a rule for transcoding, used to
* detect and load the rules at runtime from a Spring context.
*/
-public class TranscodingRule {
+public final class TranscodingRule {
/** Underlying map containing the rule. */
@Nonnull @NonnullElements private final Map<String,Object> rule;
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
More information about the commits
mailing list