[java-identity-provider] branch master updated: more javadoc warning cleanup
Rod Widdowson
rdw at steadingsoftware.com
Sat May 18 11:29:55 EDT 2019
This is an automated email from the git hooks/post-receive script.
rdw pushed a commit to branch master
in repository java-identity-provider.
View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=5382563112d661a56834c5eac97f7bdf52845ddd
The following commit(s) were added to refs/heads/master by this push:
new 5382563 more javadoc warning cleanup
5382563 is described below
commit 5382563112d661a56834c5eac97f7bdf52845ddd
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Sat May 18 16:29:54 2019 +0100
more javadoc warning cleanup
---
.../resolver/spring/BaseResolverPluginDependencyParser.java | 5 ++++-
.../resolver/spring/dc/impl/ComputedIdDataConnectorParser.java | 2 +-
.../resolver/spring/dc/impl/StoredIdDataConnectorParser.java | 2 +-
.../resolver/spring/impl/InputAttributeDefinitionParser.java | 2 +-
.../idp/attribute/resolver/spring/impl/InputDataConnectorParser.java | 2 +-
.../spring/ad/ContextDerivedAttributeDefinitionsParserTest.java | 3 ++-
.../resolver/spring/ad/TemplateAttributeDefinitionParserTest.java | 3 ++-
.../transcoding/impl/CASScopedStringAttributeTranscoder.java | 3 ++-
.../cas/attribute/transcoding/impl/CASStringAttributeTranscoder.java | 3 ++-
.../shibboleth/idp/test/flows/saml1/SAML1TestResponseValidator.java | 2 +-
.../idp/test/flows/saml2/SAML2TestStatusResponseTypeValidator.java | 2 +-
.../main/java/net/shibboleth/idp/persistence/PersistenceManager.java | 2 +-
12 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/BaseResolverPluginDependencyParser.java b/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/BaseResolverPluginDependencyParser.java
index deefad7..70c9492 100644
--- a/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/BaseResolverPluginDependencyParser.java
+++ b/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/BaseResolverPluginDependencyParser.java
@@ -26,9 +26,12 @@ import org.springframework.beans.factory.xml.AbstractSingleBeanDefinitionParser;
import org.springframework.beans.factory.xml.ParserContext;
import org.w3c.dom.Element;
+import net.shibboleth.idp.attribute.resolver.ResolverAttributeDefinitionDependency;
+import net.shibboleth.idp.attribute.resolver.ResolverDataConnectorDependency;
import net.shibboleth.utilities.java.support.primitive.StringSupport;
-/** Bean definition parser for a {@link ResolverPluginDependency}. */
+/** Bean definition parser for {@link ResolverAttributeDefinitionDependency} and
+ * for {@link ResolverDataConnectorDependency}. */
public abstract class BaseResolverPluginDependencyParser extends AbstractSingleBeanDefinitionParser {
/** Class logger. */
diff --git a/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/dc/impl/ComputedIdDataConnectorParser.java b/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/dc/impl/ComputedIdDataConnectorParser.java
index b55c8e9..d59b87a 100644
--- a/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/dc/impl/ComputedIdDataConnectorParser.java
+++ b/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/dc/impl/ComputedIdDataConnectorParser.java
@@ -31,7 +31,7 @@ import org.springframework.beans.factory.xml.ParserContext;
import org.w3c.dom.Element;
/**
- * Spring bean definition parser for configuring {@link ComputedIDDataConnector}.
+ * Spring bean definition parser for configuring ComputedIdDataConnector.
*/
public class ComputedIdDataConnectorParser extends PairwiseIdDataConnectorParser {
diff --git a/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/dc/impl/StoredIdDataConnectorParser.java b/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/dc/impl/StoredIdDataConnectorParser.java
index b04f2b9..9ca560d 100644
--- a/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/dc/impl/StoredIdDataConnectorParser.java
+++ b/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/dc/impl/StoredIdDataConnectorParser.java
@@ -33,7 +33,7 @@ import org.springframework.beans.factory.xml.ParserContext;
import org.w3c.dom.Element;
/**
- * Spring bean definition parser for {@link StoredIDDataConnector}.
+ * Spring bean definition parser for StoredIDDataConnector.
*/
public class StoredIdDataConnectorParser extends ComputedIdDataConnectorParser {
diff --git a/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/impl/InputAttributeDefinitionParser.java b/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/impl/InputAttributeDefinitionParser.java
index 8e5ffda..06bfcf3 100644
--- a/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/impl/InputAttributeDefinitionParser.java
+++ b/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/impl/InputAttributeDefinitionParser.java
@@ -26,7 +26,7 @@ import org.w3c.dom.Element;
import net.shibboleth.idp.attribute.resolver.ResolverAttributeDefinitionDependency;
import net.shibboleth.idp.attribute.resolver.spring.BaseResolverPluginDependencyParser;
-/** Bean definition parser for a {@link ResolverPluginDependency}. */
+/** Bean definition parser for a {@link ResolverAttributeDefinitionDependency}. */
public class InputAttributeDefinitionParser extends BaseResolverPluginDependencyParser {
/** Element name. */
diff --git a/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/impl/InputDataConnectorParser.java b/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/impl/InputDataConnectorParser.java
index 1edee77..38136da 100644
--- a/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/impl/InputDataConnectorParser.java
+++ b/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/impl/InputDataConnectorParser.java
@@ -34,7 +34,7 @@ import net.shibboleth.idp.attribute.resolver.ResolverDataConnectorDependency;
import net.shibboleth.idp.attribute.resolver.spring.BaseResolverPluginDependencyParser;
import net.shibboleth.utilities.java.support.primitive.StringSupport;
-/** Bean definition parser for a {@link ResolverPluginDependency}. */
+/** Bean definition parser for a {@link ResolverDataConnectorDependency}. */
public class InputDataConnectorParser extends BaseResolverPluginDependencyParser {
/** Element name. */
diff --git a/idp-attribute-resolver-spring/src/test/java/net/shibboleth/idp/attribute/resolver/spring/ad/ContextDerivedAttributeDefinitionsParserTest.java b/idp-attribute-resolver-spring/src/test/java/net/shibboleth/idp/attribute/resolver/spring/ad/ContextDerivedAttributeDefinitionsParserTest.java
index d581c1a..10b08ad 100644
--- a/idp-attribute-resolver-spring/src/test/java/net/shibboleth/idp/attribute/resolver/spring/ad/ContextDerivedAttributeDefinitionsParserTest.java
+++ b/idp-attribute-resolver-spring/src/test/java/net/shibboleth/idp/attribute/resolver/spring/ad/ContextDerivedAttributeDefinitionsParserTest.java
@@ -37,6 +37,7 @@ import net.shibboleth.idp.attribute.resolver.ResolutionException;
import net.shibboleth.idp.attribute.resolver.ad.impl.ContextDerivedAttributeDefinition;
import net.shibboleth.idp.attribute.resolver.context.AttributeResolutionContext;
import net.shibboleth.idp.attribute.resolver.spring.BaseAttributeDefinitionParserTest;
+import net.shibboleth.idp.attribute.resolver.spring.ad.impl.ContextDerivedAttributeDefinitionParser;
import net.shibboleth.idp.attribute.resolver.spring.ad.impl.SubjectDerivedAttributeDefinitionParser;
import net.shibboleth.idp.authn.AuthenticationResult;
import net.shibboleth.idp.authn.context.SubjectContext;
@@ -45,7 +46,7 @@ import net.shibboleth.idp.saml.authn.principal.AuthenticationMethodPrincipal;
import net.shibboleth.idp.saml.impl.TestSources;
/**
- * Test for {@link SubjectDerivedAttributeDefinitionParser} and {@link .
+ * Test for {@link SubjectDerivedAttributeDefinitionParser} and {@link ContextDerivedAttributeDefinitionParser}.
*/
public class ContextDerivedAttributeDefinitionsParserTest extends BaseAttributeDefinitionParserTest {
diff --git a/idp-attribute-resolver-spring/src/test/java/net/shibboleth/idp/attribute/resolver/spring/ad/TemplateAttributeDefinitionParserTest.java b/idp-attribute-resolver-spring/src/test/java/net/shibboleth/idp/attribute/resolver/spring/ad/TemplateAttributeDefinitionParserTest.java
index dcc9d14..2e64299 100644
--- a/idp-attribute-resolver-spring/src/test/java/net/shibboleth/idp/attribute/resolver/spring/ad/TemplateAttributeDefinitionParserTest.java
+++ b/idp-attribute-resolver-spring/src/test/java/net/shibboleth/idp/attribute/resolver/spring/ad/TemplateAttributeDefinitionParserTest.java
@@ -25,10 +25,11 @@ import org.testng.annotations.Test;
import net.shibboleth.idp.attribute.resolver.ad.impl.TemplateAttributeDefinition;
import net.shibboleth.idp.attribute.resolver.spring.BaseAttributeDefinitionParserTest;
+import net.shibboleth.idp.attribute.resolver.spring.ad.impl.TemplateAttributeDefinitionParser;
import net.shibboleth.utilities.java.support.component.ComponentInitializationException;
/**
- * test for {@link CryptoTransientIdAttributeDefinitionParser}
+ * Test for {@link TemplateAttributeDefinitionParser}
*/
@SuppressWarnings("deprecation")
public class TemplateAttributeDefinitionParserTest extends BaseAttributeDefinitionParserTest {
diff --git a/idp-cas-impl/src/main/java/net/shibboleth/idp/cas/attribute/transcoding/impl/CASScopedStringAttributeTranscoder.java b/idp-cas-impl/src/main/java/net/shibboleth/idp/cas/attribute/transcoding/impl/CASScopedStringAttributeTranscoder.java
index 5eac1b6..2447dbf 100644
--- a/idp-cas-impl/src/main/java/net/shibboleth/idp/cas/attribute/transcoding/impl/CASScopedStringAttributeTranscoder.java
+++ b/idp-cas-impl/src/main/java/net/shibboleth/idp/cas/attribute/transcoding/impl/CASScopedStringAttributeTranscoder.java
@@ -24,6 +24,7 @@ import net.shibboleth.idp.attribute.AttributeEncodingException;
import net.shibboleth.idp.attribute.IdPAttribute;
import net.shibboleth.idp.attribute.IdPAttributeValue;
import net.shibboleth.idp.attribute.ScopedStringAttributeValue;
+import net.shibboleth.idp.attribute.transcoding.AttributeTranscoder;
import net.shibboleth.idp.attribute.transcoding.TranscodingRule;
import net.shibboleth.idp.cas.attribute.AbstractCASAttributeTranscoder;
import net.shibboleth.idp.cas.attribute.Attribute;
@@ -34,7 +35,7 @@ import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
/**
- * {@link net.shibboleth.idp.attribute.AttributeTranscoder} that supports {@link Attribute} and
+ * {@link AttributeTranscoder} that supports {@link Attribute} and
* {@link ScopedStringAttributeValue} objects.
*/
public class CASScopedStringAttributeTranscoder extends AbstractCASAttributeTranscoder<ScopedStringAttributeValue> {
diff --git a/idp-cas-impl/src/main/java/net/shibboleth/idp/cas/attribute/transcoding/impl/CASStringAttributeTranscoder.java b/idp-cas-impl/src/main/java/net/shibboleth/idp/cas/attribute/transcoding/impl/CASStringAttributeTranscoder.java
index da190b5..aea172f 100644
--- a/idp-cas-impl/src/main/java/net/shibboleth/idp/cas/attribute/transcoding/impl/CASStringAttributeTranscoder.java
+++ b/idp-cas-impl/src/main/java/net/shibboleth/idp/cas/attribute/transcoding/impl/CASStringAttributeTranscoder.java
@@ -29,12 +29,13 @@ import net.shibboleth.idp.attribute.IdPAttribute;
import net.shibboleth.idp.attribute.IdPAttributeValue;
import net.shibboleth.idp.attribute.ScopedStringAttributeValue;
import net.shibboleth.idp.attribute.StringAttributeValue;
+import net.shibboleth.idp.attribute.transcoding.AttributeTranscoder;
import net.shibboleth.idp.attribute.transcoding.TranscodingRule;
import net.shibboleth.idp.cas.attribute.AbstractCASAttributeTranscoder;
import net.shibboleth.idp.cas.attribute.Attribute;
/**
- * {@link net.shibboleth.idp.attribute.AttributeTranscoder} that supports {@link Attribute} and
+ * {@link AttributeTranscoder} that supports {@link Attribute} and
* {@link StringAttributeValue} objects.
*/
public class CASStringAttributeTranscoder extends AbstractCASAttributeTranscoder<StringAttributeValue> {
diff --git a/idp-conf/src/test/java/net/shibboleth/idp/test/flows/saml1/SAML1TestResponseValidator.java b/idp-conf/src/test/java/net/shibboleth/idp/test/flows/saml1/SAML1TestResponseValidator.java
index e1d6203..5dbad2f 100644
--- a/idp-conf/src/test/java/net/shibboleth/idp/test/flows/saml1/SAML1TestResponseValidator.java
+++ b/idp-conf/src/test/java/net/shibboleth/idp/test/flows/saml1/SAML1TestResponseValidator.java
@@ -417,7 +417,7 @@ public class SAML1TestResponseValidator {
* <li>the name identifier is not null</li>
* <li>the name identifier value is not null</li>
* <li>the name identifier value is the expected value if the format is not transient</li>
- * <li>the name format is the expected name format/li>
+ * <li>the name format is the expected name format</li>
* <li>the name qualifier is the expected name qualifier</li>
* <ul>
*
diff --git a/idp-conf/src/test/java/net/shibboleth/idp/test/flows/saml2/SAML2TestStatusResponseTypeValidator.java b/idp-conf/src/test/java/net/shibboleth/idp/test/flows/saml2/SAML2TestStatusResponseTypeValidator.java
index 11cac53..ed44679 100644
--- a/idp-conf/src/test/java/net/shibboleth/idp/test/flows/saml2/SAML2TestStatusResponseTypeValidator.java
+++ b/idp-conf/src/test/java/net/shibboleth/idp/test/flows/saml2/SAML2TestStatusResponseTypeValidator.java
@@ -27,7 +27,7 @@ import org.opensaml.saml.saml2.core.StatusResponseType;
import org.testng.Assert;
/**
- * SAML 2 {@link #org.opensaml.saml.saml2.core.StatusResponseType} validator.
+ * SAML 2 {@link StatusResponseType} validator.
*/
public class SAML2TestStatusResponseTypeValidator {
diff --git a/idp-core/src/main/java/net/shibboleth/idp/persistence/PersistenceManager.java b/idp-core/src/main/java/net/shibboleth/idp/persistence/PersistenceManager.java
index e64d388..6ae4079 100644
--- a/idp-core/src/main/java/net/shibboleth/idp/persistence/PersistenceManager.java
+++ b/idp-core/src/main/java/net/shibboleth/idp/persistence/PersistenceManager.java
@@ -26,7 +26,7 @@ import net.shibboleth.utilities.java.support.component.IdentifiedComponent;
*
* @deprecated
*/
-public interface PersistenceManager<ItemType> extends IdentifiedComponent {
+ at Deprecated public interface PersistenceManager<ItemType> extends IdentifiedComponent {
/**
* Determines if an item with the given ID is exists within the persistence store.
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
More information about the commits
mailing list