[java-opensaml] branch master updated: Adjust parameter type from Long to Duration to bypass warnings.

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch master
in repository java-opensaml.

View the commit online:
http://git.shibboleth.net/view/?p=java-opensaml.git;a=commit;h=5b7ace538bc4b0a0c667cbc2291565a7d79d889f

The following commit(s) were added to refs/heads/master by this push:
       new  5b7ace5   Adjust parameter type from Long to Duration to bypass warnings.
5b7ace5 is described below

commit 5b7ace538bc4b0a0c667cbc2291565a7d79d889f
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Mon Mar 18 21:43:09 2019 -0400

    Adjust parameter type from Long to Duration to bypass warnings.
---
 .../opensaml/saml/saml2/assertion/BaseAssertionValidationTest.java    | 3 ++-
 .../saml/saml2/assertion/impl/OneTimeUseConditionValidatorTest.java   | 4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/opensaml-saml-impl/src/test/java/org/opensaml/saml/saml2/assertion/BaseAssertionValidationTest.java b/opensaml-saml-impl/src/test/java/org/opensaml/saml/saml2/assertion/BaseAssertionValidationTest.java
index a4b9439..a7d51ef 100644
--- a/opensaml-saml-impl/src/test/java/org/opensaml/saml/saml2/assertion/BaseAssertionValidationTest.java
+++ b/opensaml-saml-impl/src/test/java/org/opensaml/saml/saml2/assertion/BaseAssertionValidationTest.java
@@ -27,6 +27,7 @@ import java.security.PrivateKey;
 import java.security.PublicKey;
 import java.security.cert.CertificateException;
 import java.security.cert.X509Certificate;
+import java.time.Duration;
 import java.time.Instant;
 import java.time.temporal.ChronoUnit;
 import java.util.Collections;
@@ -59,7 +60,7 @@ import org.testng.annotations.BeforeMethod;
 
 public class BaseAssertionValidationTest extends XMLObjectBaseTestCase {
     
-    public static final Long CLOCK_SKEW = 5*60*1000L;
+    public static final Duration CLOCK_SKEW = Duration.ofMinutes(5);
     
     public static final String PRINCIPAL_NAME = "gollum";
     
diff --git a/opensaml-saml-impl/src/test/java/org/opensaml/saml/saml2/assertion/impl/OneTimeUseConditionValidatorTest.java b/opensaml-saml-impl/src/test/java/org/opensaml/saml/saml2/assertion/impl/OneTimeUseConditionValidatorTest.java
index 9e57a98..d55fd65 100644
--- a/opensaml-saml-impl/src/test/java/org/opensaml/saml/saml2/assertion/impl/OneTimeUseConditionValidatorTest.java
+++ b/opensaml-saml-impl/src/test/java/org/opensaml/saml/saml2/assertion/impl/OneTimeUseConditionValidatorTest.java
@@ -139,7 +139,7 @@ public class OneTimeUseConditionValidatorTest extends BaseAssertionValidationTes
         Assert.assertNotNull(StringSupport.trimOrNull(assertion.getID()));
         
         Map<String, Object> staticParams = buildBasicStaticParameters();
-        staticParams.put(SAML2AssertionValidationParameters.COND_ONE_TIME_USE_EXPIRES, 500L);
+        staticParams.put(SAML2AssertionValidationParameters.COND_ONE_TIME_USE_EXPIRES, Duration.ofMillis(500));
         ValidationContext validationContext = new ValidationContext(staticParams);
         
         Assert.assertEquals(validator.validate(condition, assertion, validationContext), 
@@ -160,7 +160,7 @@ public class OneTimeUseConditionValidatorTest extends BaseAssertionValidationTes
         Assert.assertNotNull(StringSupport.trimOrNull(assertion.getID()));
         
         Map<String, Object> staticParams = buildBasicStaticParameters();
-        // This value is not a Long and so will be effectively ignored
+        // This value is not a Duration or Long and so will be effectively ignored
         staticParams.put(SAML2AssertionValidationParameters.COND_ONE_TIME_USE_EXPIRES, "500");
         ValidationContext validationContext = new ValidationContext(staticParams);
         

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.