[java-support] 02/03: Fix Javadocs, add missing use of ImmutableList.copyOf(...).

[Brent Putman]

This is an automated email from the git hooks/post-receive script.

putmanb pushed a commit to branch master
in repository java-support.

View the commit online:
http://git.shibboleth.net/view/?p=java-support.git;a=commit;h=9ca508799c3a58fe90401b6d13ec353508947224

commit 9ca508799c3a58fe90401b6d13ec353508947224
Author: Brent Putman <putmanb at georgetown.edu>
AuthorDate: Wed Mar 13 20:13:30 2019 -0400

    Fix Javadocs, add missing use of ImmutableList.copyOf(...).
---
 .../java/support/httpclient/HttpClientBuilder.java | 22 ++++++++++++----------
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/src/main/java/net/shibboleth/utilities/java/support/httpclient/HttpClientBuilder.java b/src/main/java/net/shibboleth/utilities/java/support/httpclient/HttpClientBuilder.java
index 032ba4e..cd5b057 100644
--- a/src/main/java/net/shibboleth/utilities/java/support/httpclient/HttpClientBuilder.java
+++ b/src/main/java/net/shibboleth/utilities/java/support/httpclient/HttpClientBuilder.java
@@ -856,10 +856,11 @@ public class HttpClientBuilder {
     /**
      * Get the list of request interceptors to add first.
      * 
-     * @return the list of interceptors, may be null
+     * @return the list of interceptors
      */
-    @Nonnull @NonnullElements @NotLive @Unmodifiable public List<HttpRequestInterceptor> getFirstRequestInterceptors() {
-        return requestInterceptorsFirst;
+    @Nonnull @NonnullElements @NotLive @Unmodifiable
+    public List<HttpRequestInterceptor> getFirstRequestInterceptors() {
+        return ImmutableList.copyOf(requestInterceptorsFirst);
     }
     
     /**
@@ -874,10 +875,11 @@ public class HttpClientBuilder {
     /**
      * Get the list of request interceptors to add last.
      * 
-     * @return the list of interceptors, may be null
+     * @return the list of interceptors
      */
-    @Nonnull @NonnullElements @NotLive @Unmodifiable public List<HttpRequestInterceptor> getLastRequestInterceptors() {
-        return requestInterceptorsLast;
+    @Nonnull @NonnullElements @NotLive @Unmodifiable
+    public List<HttpRequestInterceptor> getLastRequestInterceptors() {
+        return ImmutableList.copyOf(requestInterceptorsLast);
     }
 
     /**
@@ -892,11 +894,11 @@ public class HttpClientBuilder {
     /**
      * Get the list of response interceptors to add first.
      * 
-     * @return the list of interceptors, may be null
+     * @return the list of interceptors
      */
     @Nonnull @NonnullElements @NotLive @Unmodifiable
     public List<HttpResponseInterceptor> getFirstResponseInterceptors() {
-        return responseInterceptorsFirst;
+        return ImmutableList.copyOf(responseInterceptorsFirst);
     }
 
     /**
@@ -911,11 +913,11 @@ public class HttpClientBuilder {
     /**
      * Get the list of response interceptors to add last.
      * 
-     * @return the list of interceptors, may be null
+     * @return the list of interceptors
      */
     @Nonnull @NonnullElements @NotLive @Unmodifiable
     public List<HttpResponseInterceptor> getLastResponseInterceptors() {
-        return responseInterceptorsLast;
+        return ImmutableList.copyOf(responseInterceptorsLast);
     }
 
     /**

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.