[java-opensaml] branch master updated: Checkstyle.

Scott Cantor cantor.2 at osu.edu
Thu Jan 10 10:45:36 EST 2019


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch master
in repository java-opensaml.

View the commit online:
http://git.shibboleth.net/view/?p=java-opensaml.git;a=commit;h=f01dfc1fed1256626e8ab35919b2c8a6accea5d9

The following commit(s) were added to refs/heads/master by this push:
       new  f01dfc1   Checkstyle.
f01dfc1 is described below

commit f01dfc1fed1256626e8ab35919b2c8a6accea5d9
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Thu Jan 10 10:45:34 2019 -0500

    Checkstyle.
---
 .../java/org/opensaml/saml/common/SAMLObjectContentReference.java    | 3 ++-
 .../opensaml/saml/metadata/resolver/ChainingMetadataResolver.java    | 2 +-
 .../saml/metadata/resolver/impl/CompositeMetadataResolver.java       | 2 +-
 .../src/main/java/org/opensaml/security/x509/X509Support.java        | 2 +-
 .../config/impl/HttpClientSecurityConfigurationInitalizer.java       | 5 +++--
 .../security/httpclient/impl/SecurityEnhancedTLSSocketFactory.java   | 4 ++--
 .../src/main/java/org/opensaml/soap/client/SOAPFaultException.java   | 5 +++--
 7 files changed, 13 insertions(+), 10 deletions(-)

diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/SAMLObjectContentReference.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/SAMLObjectContentReference.java
index 6916ab9..fef5e55 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/SAMLObjectContentReference.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/SAMLObjectContentReference.java
@@ -73,7 +73,8 @@ import com.google.common.base.Strings;
  * </p>
  * 
  */
-public class SAMLObjectContentReference implements ConfigurableContentReference, TransformsConfigurableContentReference {
+public class SAMLObjectContentReference implements ConfigurableContentReference,
+        TransformsConfigurableContentReference {
 
     /** Class logger. */
     @Nonnull private final Logger log = LoggerFactory.getLogger(SAMLObjectContentReference.class);
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/metadata/resolver/ChainingMetadataResolver.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/metadata/resolver/ChainingMetadataResolver.java
index 66c4f6b..06cad12 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/metadata/resolver/ChainingMetadataResolver.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/metadata/resolver/ChainingMetadataResolver.java
@@ -161,7 +161,7 @@ public class ChainingMetadataResolver extends AbstractIdentifiableInitializableC
     }
 
     /** {@inheritDoc} */
-    public void clear(String entityID) throws ResolverException {
+    public void clear(final String entityID) throws ResolverException {
         for (final MetadataResolver resolver : resolvers) {
             if (resolver instanceof ClearableMetadataResolver) {
                 ((ClearableMetadataResolver) resolver).clear(entityID);
diff --git a/opensaml-saml-impl/src/main/java/org/opensaml/saml/metadata/resolver/impl/CompositeMetadataResolver.java b/opensaml-saml-impl/src/main/java/org/opensaml/saml/metadata/resolver/impl/CompositeMetadataResolver.java
index 2ce3425..239f6dc 100644
--- a/opensaml-saml-impl/src/main/java/org/opensaml/saml/metadata/resolver/impl/CompositeMetadataResolver.java
+++ b/opensaml-saml-impl/src/main/java/org/opensaml/saml/metadata/resolver/impl/CompositeMetadataResolver.java
@@ -163,7 +163,7 @@ public class CompositeMetadataResolver extends AbstractIdentifiedInitializableCo
     }
 
     /** {@inheritDoc} */
-    public void clear(String entityID) throws ResolverException {
+    public void clear(final String entityID) throws ResolverException {
         for (final MetadataResolver resolver : resolvers) {
             if (resolver instanceof ClearableMetadataResolver) {
                 ((ClearableMetadataResolver) resolver).clear(entityID);
diff --git a/opensaml-security-api/src/main/java/org/opensaml/security/x509/X509Support.java b/opensaml-security-api/src/main/java/org/opensaml/security/x509/X509Support.java
index 49662f1..2305c59 100644
--- a/opensaml-security-api/src/main/java/org/opensaml/security/x509/X509Support.java
+++ b/opensaml-security-api/src/main/java/org/opensaml/security/x509/X509Support.java
@@ -206,7 +206,7 @@ public class X509Support {
                 }
             }
             return altNames;
-        } catch (EncodingException e) {
+        } catch (final EncodingException e) {
             final Logger log = getLogger();
             log.warn("Could not extract alt names from certificate", e);
             throw e;
diff --git a/opensaml-security-impl/src/main/java/org/opensaml/security/config/impl/HttpClientSecurityConfigurationInitalizer.java b/opensaml-security-impl/src/main/java/org/opensaml/security/config/impl/HttpClientSecurityConfigurationInitalizer.java
index d08ddc8..208326e 100644
--- a/opensaml-security-impl/src/main/java/org/opensaml/security/config/impl/HttpClientSecurityConfigurationInitalizer.java
+++ b/opensaml-security-impl/src/main/java/org/opensaml/security/config/impl/HttpClientSecurityConfigurationInitalizer.java
@@ -31,7 +31,8 @@ public class HttpClientSecurityConfigurationInitalizer implements Initializer {
     /** {@inheritDoc} */
     public void init() throws InitializationException {
         // This is empty, just need to register it to satisfy resolver in case no others are supplied.
-        ConfigurationService.register(HttpClientSecurityConfiguration.class, new BasicHttpClientSecurityConfiguration());
+        ConfigurationService.register(HttpClientSecurityConfiguration.class,
+                new BasicHttpClientSecurityConfiguration());
     }
 
-}
+}
\ No newline at end of file
diff --git a/opensaml-security-impl/src/main/java/org/opensaml/security/httpclient/impl/SecurityEnhancedTLSSocketFactory.java b/opensaml-security-impl/src/main/java/org/opensaml/security/httpclient/impl/SecurityEnhancedTLSSocketFactory.java
index a58fa9d..98dea7d 100644
--- a/opensaml-security-impl/src/main/java/org/opensaml/security/httpclient/impl/SecurityEnhancedTLSSocketFactory.java
+++ b/opensaml-security-impl/src/main/java/org/opensaml/security/httpclient/impl/SecurityEnhancedTLSSocketFactory.java
@@ -321,8 +321,8 @@ public class SecurityEnhancedTLSSocketFactory implements LayeredConnectionSocket
             } else {
                 context.setAttribute(HttpClientSecurityConstants.CONTEXT_KEY_SERVER_TLS_CREDENTIAL_TRUSTED, 
                         Boolean.FALSE);
-                final Boolean fatal = 
-                        (Boolean)context.getAttribute(HttpClientSecurityConstants.CONTEXT_KEY_SERVER_TLS_FAILURE_IS_FATAL);
+                final Boolean fatal = (Boolean)context.getAttribute(
+                        HttpClientSecurityConstants.CONTEXT_KEY_SERVER_TLS_FAILURE_IS_FATAL);
                 if (fatal == null || fatal) {
                     log.debug("Credential evaluated as untrusted, failure indicated as fatal");
                     throw new SSLPeerUnverifiedException(
diff --git a/opensaml-soap-api/src/main/java/org/opensaml/soap/client/SOAPFaultException.java b/opensaml-soap-api/src/main/java/org/opensaml/soap/client/SOAPFaultException.java
index f23225f..2ab9d82 100644
--- a/opensaml-soap-api/src/main/java/org/opensaml/soap/client/SOAPFaultException.java
+++ b/opensaml-soap-api/src/main/java/org/opensaml/soap/client/SOAPFaultException.java
@@ -29,11 +29,11 @@ public class SOAPFaultException extends SOAPException {
     private static final long serialVersionUID = 4770411452264097320L;
 
     /** The fault that caused this exception. */
-    private Fault soapFault;
+    @Nullable private Fault soapFault;
 
     /** Constructor. */
     public SOAPFaultException() {
-        super();
+
     }
 
     /**
@@ -81,4 +81,5 @@ public class SOAPFaultException extends SOAPException {
     public void setFault(@Nullable final Fault fault) {
         soapFault = fault;
     }
+    
 }
\ No newline at end of file

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list