[java-identity-provider] branch maint-3.4 updated: IDP-1387 - Config-based ForceAuthn enhancement broke renew flag for CAS

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch maint-3.4
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=31d99d9f5aaf201290890cc13be15d556f4d3d90

The following commit(s) were added to refs/heads/maint-3.4 by this push:
       new  31d99d9   IDP-1387 - Config-based ForceAuthn enhancement broke renew flag for CAS
31d99d9 is described below

commit 31d99d9f5aaf201290890cc13be15d556f4d3d90
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Fri Jan 4 18:58:14 2019 -0500

    IDP-1387 - Config-based ForceAuthn enhancement broke renew flag for CAS
    
    https://issues.shibboleth.net/jira/browse/IDP-1387
---
 .../idp/cas/flow/impl/BuildAuthenticationContextAction.java       | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/idp-cas-impl/src/main/java/net/shibboleth/idp/cas/flow/impl/BuildAuthenticationContextAction.java b/idp-cas-impl/src/main/java/net/shibboleth/idp/cas/flow/impl/BuildAuthenticationContextAction.java
index 277031f..6f87a52 100644
--- a/idp-cas-impl/src/main/java/net/shibboleth/idp/cas/flow/impl/BuildAuthenticationContextAction.java
+++ b/idp-cas-impl/src/main/java/net/shibboleth/idp/cas/flow/impl/BuildAuthenticationContextAction.java
@@ -55,9 +55,11 @@ public class BuildAuthenticationContextAction extends
         ac.setForceAuthn(getCASRequest(profileRequestContext).isRenew());
         ac.setIsPassive(false);
 
-        final LoginConfiguration config = configLookupFunction.apply(profileRequestContext);
-        if (config != null) {
-            ac.setForceAuthn(config.getForceAuthnPredicate().apply(profileRequestContext));
+        if (!ac.isForceAuthn()) {
+            final LoginConfiguration config = configLookupFunction.apply(profileRequestContext);
+            if (config != null) {
+                ac.setForceAuthn(config.getForceAuthnPredicate().apply(profileRequestContext));
+            }
         }
         
         final AuthenticationContext initialAuthnContext =

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.