[java-identity-provider] branch maint-3.4 updated: IDP-1383 - SourceAttribute warning appears regardless of presence

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch maint-3.4
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=ec6bc988ec036dad08eb29813d69210aeb1c93d0

The following commit(s) were added to refs/heads/maint-3.4 by this push:
       new  ec6bc98   IDP-1383 - SourceAttribute warning appears regardless of presence
ec6bc98 is described below

commit ec6bc988ec036dad08eb29813d69210aeb1c93d0
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Thu Dec 20 08:42:48 2018 -0500

    IDP-1383 - SourceAttribute warning appears regardless of presence
    
    https://issues.shibboleth.net/jira/browse/IDP-1383
---
 .../resolver/spring/ad/impl/TemplateAttributeDefinitionParser.java      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/ad/impl/TemplateAttributeDefinitionParser.java b/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/ad/impl/TemplateAttributeDefinitionParser.java
index b229346..833648e 100644
--- a/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/ad/impl/TemplateAttributeDefinitionParser.java
+++ b/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/ad/impl/TemplateAttributeDefinitionParser.java
@@ -99,7 +99,7 @@ public class TemplateAttributeDefinitionParser extends AbstractWarningAttributeD
         final List<Element> sourceAttributeElements =
                 ElementSupport.getChildElements(config, SOURCE_ATTRIBUTE_ELEMENT_NAME_AD);
         sourceAttributeElements.addAll(ElementSupport.getChildElements(config, SOURCE_ATTRIBUTE_ELEMENT_NAME_RESOLVER));
-        if (null != sourceAttributeElements) {
+        if (null != sourceAttributeElements && !sourceAttributeElements.isEmpty()) {
             DeprecationSupport.warnOnce(ObjectType.ELEMENT, SOURCE_ATTRIBUTE_ELEMENT_NAME_RESOLVER.getLocalPart(),
                     parserContext.getReaderContext().getResource().getDescription(),
                     "by using <InputAttributeDefinition> and <InputDataConnector>");

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.