[java-identity-provider] 01/03: Checkstyle: supress unlikely-arg-type in equality testing
Rod Widdowson
rdw at steadingsoftware.com
Tue Feb 12 11:57:09 EST 2019
This is an automated email from the git hooks/post-receive script.
rdw pushed a commit to branch master
in repository java-identity-provider.
View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=565c672b97f476e2d2fe9e987153ed7f2f25b750
commit 565c672b97f476e2d2fe9e987153ed7f2f25b750
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Tue Feb 12 16:14:09 2019 +0000
Checkstyle: supress unlikely-arg-type in equality testing
The tests are explicitly testing that an apple isn't comparable to
an organge.
---
.../src/test/java/net/shibboleth/idp/attribute/AttributeTest.java | 1 +
.../test/java/net/shibboleth/idp/attribute/ByteAttributeValueTest.java | 1 +
.../test/java/net/shibboleth/idp/attribute/EmptyAttributeValueTest.java | 1 +
.../net/shibboleth/idp/attribute/LocalizedStringAttributeValueTest.java | 1 +
.../net/shibboleth/idp/attribute/ScopedStringAttributeValueTest.java | 1 +
.../test/java/net/shibboleth/idp/attribute/StringAttributeValueTest.java | 1 +
.../java/net/shibboleth/idp/attribute/XMLObjectAttributeValueTest.java | 1 +
.../idp/attribute/filter/matcher/impl/ScriptedMatcherTest.java | 1 +
.../idp/attribute/filter/policyrule/impl/ScriptedPolicyRuleTest.java | 1 +
.../idp/attribute/resolver/ResolvedAttributeDefinitionTest.java | 1 +
.../net/shibboleth/idp/attribute/resolver/ResolvedDataConnectorTest.java | 1 +
11 files changed, 11 insertions(+)
diff --git a/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/AttributeTest.java b/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/AttributeTest.java
index edc88a3..2c03282 100644
--- a/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/AttributeTest.java
+++ b/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/AttributeTest.java
@@ -371,6 +371,7 @@ public class AttributeTest {
}
+ @SuppressWarnings("unlikely-arg-type")
@Test public void cloneToString() {
IdPAttribute attrib = new IdPAttribute("foo");
IdPAttribute dupl = new IdPAttribute("foo");
diff --git a/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/ByteAttributeValueTest.java b/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/ByteAttributeValueTest.java
index bc6af80..8c528b1 100644
--- a/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/ByteAttributeValueTest.java
+++ b/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/ByteAttributeValueTest.java
@@ -46,6 +46,7 @@ public class ByteAttributeValueTest {
}
/** Test equality of two objects. */
+ @SuppressWarnings("unlikely-arg-type")
@Test public void equality() {
ByteAttributeValue value1 = new ByteAttributeValue(DATA1);
ByteAttributeValue value2 = new ByteAttributeValue(DATAEQUALS1);
diff --git a/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/EmptyAttributeValueTest.java b/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/EmptyAttributeValueTest.java
index 1cf27d5..4c1a7c4 100644
--- a/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/EmptyAttributeValueTest.java
+++ b/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/EmptyAttributeValueTest.java
@@ -41,6 +41,7 @@ public class EmptyAttributeValueTest {
}
/** Test equality of two objects. */
+ @SuppressWarnings("unlikely-arg-type")
@Test public void equality() {
EmptyAttributeValue value1 = new EmptyAttributeValue(EmptyType.NULL_VALUE);
EmptyAttributeValue value2 = new EmptyAttributeValue(EmptyType.ZERO_LENGTH_VALUE);
diff --git a/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/LocalizedStringAttributeValueTest.java b/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/LocalizedStringAttributeValueTest.java
index 0a25305..f18e4b4 100644
--- a/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/LocalizedStringAttributeValueTest.java
+++ b/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/LocalizedStringAttributeValueTest.java
@@ -29,6 +29,7 @@ import org.testng.annotations.Test;
*/
public class LocalizedStringAttributeValueTest {
+ @SuppressWarnings("unlikely-arg-type")
@Test public void localizedStringAttributeValue() {
Set foo = new HashSet();
diff --git a/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/ScopedStringAttributeValueTest.java b/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/ScopedStringAttributeValueTest.java
index 5b90cb1..dc62699 100644
--- a/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/ScopedStringAttributeValueTest.java
+++ b/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/ScopedStringAttributeValueTest.java
@@ -61,6 +61,7 @@ public class ScopedStringAttributeValueTest {
}
/** Test equality of two objects. */
+ @SuppressWarnings("unlikely-arg-type")
@Test public void equality() {
ScopedStringAttributeValue value1 = new ScopedStringAttributeValue(" foo ", " bar ");
ScopedStringAttributeValue value2 = new ScopedStringAttributeValue("foo", "bar");
diff --git a/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/StringAttributeValueTest.java b/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/StringAttributeValueTest.java
index 37b7f35..7edea9b 100644
--- a/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/StringAttributeValueTest.java
+++ b/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/StringAttributeValueTest.java
@@ -47,6 +47,7 @@ public class StringAttributeValueTest {
}
/** Test equality of two objects. */
+ @SuppressWarnings("unlikely-arg-type")
@Test public void equality() {
StringAttributeValue value1 = new StringAttributeValue(" foo ");
StringAttributeValue value2 = new StringAttributeValue("foo");
diff --git a/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/XMLObjectAttributeValueTest.java b/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/XMLObjectAttributeValueTest.java
index 78e5380..a86b9cf 100644
--- a/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/XMLObjectAttributeValueTest.java
+++ b/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/XMLObjectAttributeValueTest.java
@@ -64,6 +64,7 @@ public class XMLObjectAttributeValueTest extends XMLObjectBaseTestCase {
}
/** Test equality of two objects. */
+ @SuppressWarnings("unlikely-arg-type")
@Test public void equality() {
XMLObjectAttributeValue value1 = new XMLObjectAttributeValue(xsId1);
XMLObjectAttributeValue value2 = new XMLObjectAttributeValue(xsId2);
diff --git a/idp-attribute-filter-impl/src/test/java/net/shibboleth/idp/attribute/filter/matcher/impl/ScriptedMatcherTest.java b/idp-attribute-filter-impl/src/test/java/net/shibboleth/idp/attribute/filter/matcher/impl/ScriptedMatcherTest.java
index 29dd635..952330b 100644
--- a/idp-attribute-filter-impl/src/test/java/net/shibboleth/idp/attribute/filter/matcher/impl/ScriptedMatcherTest.java
+++ b/idp-attribute-filter-impl/src/test/java/net/shibboleth/idp/attribute/filter/matcher/impl/ScriptedMatcherTest.java
@@ -271,6 +271,7 @@ public class ScriptedMatcherTest extends AbstractMatcherPolicyRuleTest {
Assert.assertTrue(thrown, "getMatchingValues after destroy");
}
+ @SuppressWarnings("unlikely-arg-type")
@Test public void testEqualsHashToString() {
final ScriptedMatcher matcher = newScriptedMatcher(addedValuesScript);
diff --git a/idp-attribute-filter-impl/src/test/java/net/shibboleth/idp/attribute/filter/policyrule/impl/ScriptedPolicyRuleTest.java b/idp-attribute-filter-impl/src/test/java/net/shibboleth/idp/attribute/filter/policyrule/impl/ScriptedPolicyRuleTest.java
index 8fea82e..8e01427 100644
--- a/idp-attribute-filter-impl/src/test/java/net/shibboleth/idp/attribute/filter/policyrule/impl/ScriptedPolicyRuleTest.java
+++ b/idp-attribute-filter-impl/src/test/java/net/shibboleth/idp/attribute/filter/policyrule/impl/ScriptedPolicyRuleTest.java
@@ -162,6 +162,7 @@ public class ScriptedPolicyRuleTest extends AbstractMatcherPolicyRuleTest {
}
+ @SuppressWarnings("unlikely-arg-type")
@Test public void testEqualsHashToString() {
final ScriptedPolicyRule rule = newScriptedPolicyRule(trueReturnScript);
diff --git a/idp-attribute-resolver-api/src/test/java/net/shibboleth/idp/attribute/resolver/ResolvedAttributeDefinitionTest.java b/idp-attribute-resolver-api/src/test/java/net/shibboleth/idp/attribute/resolver/ResolvedAttributeDefinitionTest.java
index 3bde4e9..eac6f76 100644
--- a/idp-attribute-resolver-api/src/test/java/net/shibboleth/idp/attribute/resolver/ResolvedAttributeDefinitionTest.java
+++ b/idp-attribute-resolver-api/src/test/java/net/shibboleth/idp/attribute/resolver/ResolvedAttributeDefinitionTest.java
@@ -58,6 +58,7 @@ public class ResolvedAttributeDefinitionTest {
}
+ @SuppressWarnings("unlikely-arg-type")
@Test public void equalsHashToString() throws ComponentInitializationException {
IdPAttribute attribute = new IdPAttribute("foo");
MockStaticAttributeDefinition attrDef = new MockStaticAttributeDefinition();
diff --git a/idp-attribute-resolver-api/src/test/java/net/shibboleth/idp/attribute/resolver/ResolvedDataConnectorTest.java b/idp-attribute-resolver-api/src/test/java/net/shibboleth/idp/attribute/resolver/ResolvedDataConnectorTest.java
index c3f9191..3d84ea9 100644
--- a/idp-attribute-resolver-api/src/test/java/net/shibboleth/idp/attribute/resolver/ResolvedDataConnectorTest.java
+++ b/idp-attribute-resolver-api/src/test/java/net/shibboleth/idp/attribute/resolver/ResolvedDataConnectorTest.java
@@ -64,6 +64,7 @@ public class ResolvedDataConnectorTest {
}
+ @SuppressWarnings("unlikely-arg-type")
@Test public void equalsHashToString() throws ComponentInitializationException {
MockStaticDataConnector dc = new MockStaticDataConnector();
dc.setValues(Arrays.asList(new IdPAttribute("attr")));
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
More information about the commits
mailing list