[spring-extensions] branch master updated: IDP-1397 Remove deprecated SpringSupport.getAttributeValueAsManagedList

Rod Widdowson rdw at steadingsoftware.com
Tue Feb 12 11:56:49 EST 2019


This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch master
in repository spring-extensions.

View the commit online:
http://git.shibboleth.net/view/?p=spring-extensions.git;a=commit;h=b4ca75d07b97ea12e419e4573bd2bf8171e31453

The following commit(s) were added to refs/heads/master by this push:
       new  b4ca75d   IDP-1397 Remove deprecated SpringSupport.getAttributeValueAsManagedList
b4ca75d is described below

commit b4ca75d07b97ea12e419e4573bd2bf8171e31453
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Tue Feb 12 16:50:58 2019 +0000

    IDP-1397 Remove deprecated SpringSupport.getAttributeValueAsManagedList
    
    https://issues.shibboleth.net/jira/browse/IDP-1397
    
    The replacement (getAttributeValueAsList) handles properties correctly.
---
 .../shibboleth/ext/spring/util/SpringSupport.java  | 40 +++++++---------------
 1 file changed, 12 insertions(+), 28 deletions(-)

diff --git a/src/main/java/net/shibboleth/ext/spring/util/SpringSupport.java b/src/main/java/net/shibboleth/ext/spring/util/SpringSupport.java
index 513717e..60be724 100644
--- a/src/main/java/net/shibboleth/ext/spring/util/SpringSupport.java
+++ b/src/main/java/net/shibboleth/ext/spring/util/SpringSupport.java
@@ -28,19 +28,6 @@ import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
 import javax.xml.namespace.QName;
 
-import net.shibboleth.ext.spring.config.DurationToLongConverter;
-import net.shibboleth.ext.spring.config.StringBooleanToPredicateConverter;
-import net.shibboleth.ext.spring.config.StringToIPRangeConverter;
-import net.shibboleth.ext.spring.context.FilesystemGenericApplicationContext;
-import net.shibboleth.ext.spring.resource.PreferFileSystemResourceLoader;
-import net.shibboleth.utilities.java.support.annotation.constraint.NonnullElements;
-import net.shibboleth.utilities.java.support.annotation.constraint.NotEmpty;
-import net.shibboleth.utilities.java.support.logic.Constraint;
-import net.shibboleth.utilities.java.support.primitive.StringSupport;
-import net.shibboleth.utilities.java.support.xml.AttributeSupport;
-import net.shibboleth.utilities.java.support.xml.SerializeSupport;
-import net.shibboleth.utilities.java.support.xml.XMLConstants;
-
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.beans.factory.BeanFactory;
@@ -66,6 +53,18 @@ import org.xml.sax.InputSource;
 
 import com.google.common.base.Strings;
 
+import net.shibboleth.ext.spring.config.DurationToLongConverter;
+import net.shibboleth.ext.spring.config.StringBooleanToPredicateConverter;
+import net.shibboleth.ext.spring.config.StringToIPRangeConverter;
+import net.shibboleth.ext.spring.context.FilesystemGenericApplicationContext;
+import net.shibboleth.ext.spring.resource.PreferFileSystemResourceLoader;
+import net.shibboleth.utilities.java.support.annotation.constraint.NonnullElements;
+import net.shibboleth.utilities.java.support.annotation.constraint.NotEmpty;
+import net.shibboleth.utilities.java.support.logic.Constraint;
+import net.shibboleth.utilities.java.support.primitive.StringSupport;
+import net.shibboleth.utilities.java.support.xml.SerializeSupport;
+import net.shibboleth.utilities.java.support.xml.XMLConstants;
+
 /**
  * Helper class for performing some common Spring-related functions.
  */
@@ -270,21 +269,6 @@ public final class SpringSupport {
     }
 
     /**
-     * Gets the value of a list-type attribute as a {@link ManagedList}.
-     * 
-     * @param attribute attribute whose value will be turned into a list
-     * @deprecated - use {@link #getAttributeValueAsList(Attr)}
-     * @return list of values, never null
-     */
-    @Nonnull @Deprecated public static ManagedList<String> 
-                getAttributeValueAsManagedList(@Nullable final Attr attribute) {
-        final List<String> valuesAsList = AttributeSupport.getAttributeValueAsList(attribute);
-        final ManagedList<String> managedList = new ManagedList<>(valuesAsList.size());
-        managedList.addAll(valuesAsList);
-        return managedList;
-    }
-    
-    /**
      * Gets the value of a list-type attribute as a {@link BeanDefinitionBuilder}.
      * 
      * @param attribute attribute whose value will be turned into a list

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list