[java-identity-provider] 03/03: IDP-1121 Explicitly deprecate "native" configuration of ScriptedDataConnectors

Rod Widdowson rdw at steadingsoftware.com
Tue Feb 12 09:28:30 EST 2019


This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch master
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=85e0b63f852b6a16c0d01a10577440b0eaaf9361

commit 85e0b63f852b6a16c0d01a10577440b0eaaf9361
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Tue Feb 12 14:02:37 2019 +0000

    IDP-1121 Explicitly deprecate "native" configuration of ScriptedDataConnectors
    
    https://issues.shibboleth.net/jira/browse/IDP-1121
---
 .../resolver/spring/dc/impl/ScriptDataConnectorParser.java    | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/dc/impl/ScriptDataConnectorParser.java b/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/dc/impl/ScriptDataConnectorParser.java
index 64bf228..e70f8ad 100644
--- a/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/dc/impl/ScriptDataConnectorParser.java
+++ b/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/dc/impl/ScriptDataConnectorParser.java
@@ -34,6 +34,8 @@ import net.shibboleth.idp.attribute.resolver.dc.impl.ScriptedDataConnector;
 import net.shibboleth.idp.attribute.resolver.spring.ad.impl.ScriptedAttributeDefinitionParser;
 import net.shibboleth.idp.attribute.resolver.spring.dc.AbstractDataConnectorParser;
 import net.shibboleth.idp.attribute.resolver.spring.impl.AttributeResolverNamespaceHandler;
+import net.shibboleth.utilities.java.support.primitive.DeprecationSupport;
+import net.shibboleth.utilities.java.support.primitive.DeprecationSupport.ObjectType;
 import net.shibboleth.utilities.java.support.primitive.StringSupport;
 import net.shibboleth.utilities.java.support.xml.ElementSupport;
 
@@ -59,6 +61,15 @@ public class ScriptDataConnectorParser extends AbstractDataConnectorParser {
     @Override protected Class<ScriptedDataConnector> getNativeBeanClass() {
         return ScriptedDataConnector.class;
     }
+    
+    /** {@inheritDoc} */
+    @Override protected void doParse(@Nonnull final Element config, @Nonnull final ParserContext parserContext,
+            @Nonnull final BeanDefinitionBuilder builder) {
+        if (isNative(config)) {
+            DeprecationSupport.warnOnce(ObjectType.ATTRIBUTE, ATTR_SPRING_RESOURCE, null,null);
+        }
+        super.doParse(config, parserContext, builder);
+    }
 
     /** {@inheritDoc} */
     // Checkstyle: CyclomaticComplexity OFF

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list