[java-identity-provider] branch master updated: Correct some code comments.

Scott Cantor cantor.2 at osu.edu
Mon Dec 23 13:12:21 EST 2019


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch master
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=6cac23f91786230318b14869ac6d3f53322b9e51

The following commit(s) were added to refs/heads/master by this push:
       new  6cac23f   Correct some code comments.
6cac23f is described below

commit 6cac23f91786230318b14869ac6d3f53322b9e51
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Mon Dec 23 13:12:11 2019 -0500

    Correct some code comments.
---
 .../profile/config/navigate/ProxyRestrictionLookupFunction.java    | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/idp-saml-api/src/main/java/net/shibboleth/idp/saml/saml2/profile/config/navigate/ProxyRestrictionLookupFunction.java b/idp-saml-api/src/main/java/net/shibboleth/idp/saml/saml2/profile/config/navigate/ProxyRestrictionLookupFunction.java
index c1592d0..5d5c73c 100644
--- a/idp-saml-api/src/main/java/net/shibboleth/idp/saml/saml2/profile/config/navigate/ProxyRestrictionLookupFunction.java
+++ b/idp-saml-api/src/main/java/net/shibboleth/idp/saml/saml2/profile/config/navigate/ProxyRestrictionLookupFunction.java
@@ -68,13 +68,10 @@ public class ProxyRestrictionLookupFunction extends AbstractRelyingPartyLookupFu
     @Nullable public Pair<Integer,Set<String>> apply(@Nullable final ProfileRequestContext input) {
                 
         // The proxy count is normally set to the minimum of local policy and upstream - 1, but
-        // null values have to taken into account, and 0 is the minimum.
+        // null values have to be taken into account, and 0 is the minimum.
         
         Integer proxyCount = null;
 
-        // The empty set signals no constraint on proxy, but a null value is used to track when
-        // the interaction of existing sets has resulted in the null set, which means no proxying.
-        
         final Set<String> audiences = new HashSet<>();
         
         final RelyingPartyContext rpc = getRelyingPartyContextLookupStrategy().apply(input);
@@ -89,7 +86,7 @@ public class ProxyRestrictionLookupFunction extends AbstractRelyingPartyLookupFu
             }
         }
 
-        // At this point the local configuration applies, and lacking any upstream, that applies.
+        // At this point the local configuration is derived, and lacking any upstream constraint, that applies.
         
         final SubjectContext sc = subjectContextLookupStrategy.apply(input);
         final Set<ProxyAuthenticationPrincipal> proxieds =

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list