[spring-extensions] branch master updated: IDP-1319 - Reduce redundant stack traces in log

Scott Cantor cantor.2 at osu.edu
Thu Dec 19 10:56:02 EST 2019


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch master
in repository spring-extensions.

View the commit online:
http://git.shibboleth.net/view/?p=spring-extensions.git;a=commit;h=9551e66622ab3f4cd368c220c67dc19ea40ce870

The following commit(s) were added to refs/heads/master by this push:
       new  9551e66   IDP-1319 - Reduce redundant stack traces in log
9551e66 is described below

commit 9551e66622ab3f4cd368c220c67dc19ea40ce870
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Thu Dec 19 10:55:59 2019 -0500

    IDP-1319 - Reduce redundant stack traces in log
    
    https://issues.shibboleth.net/jira/browse/IDP-1319
---
 .../net/shibboleth/ext/spring/resource/FileBackedHTTPResource.java   | 5 +++--
 .../shibboleth/ext/spring/resource/RunnableFileSystemResource.java   | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/main/java/net/shibboleth/ext/spring/resource/FileBackedHTTPResource.java b/src/main/java/net/shibboleth/ext/spring/resource/FileBackedHTTPResource.java
index cc862dd..0a74eab 100644
--- a/src/main/java/net/shibboleth/ext/spring/resource/FileBackedHTTPResource.java
+++ b/src/main/java/net/shibboleth/ext/spring/resource/FileBackedHTTPResource.java
@@ -105,7 +105,7 @@ public class FileBackedHTTPResource extends HTTPResource {
         } catch (final IOException e) {
             // try to tidy up
             backingResource.getFile().delete();
-            log.error("{}: Copy failed", getDescription(), e);
+            log.error("{}: Copy failed: {}", getDescription(), e.getMessage());
             throw e;
         } finally {
             input.close();
@@ -124,7 +124,8 @@ public class FileBackedHTTPResource extends HTTPResource {
             try {
                 return new FileInputStream(backingResource.getFile());
             } catch (final IOException e) {
-                log.error("FileBackedHTTPResource {}: Could not read backing file", getDescription(), e);
+                log.error("FileBackedHTTPResource {}: Could not read backing file: {}", getDescription(),
+                        e.getMessage());
                 throw e;
             }
         }
diff --git a/src/main/java/net/shibboleth/ext/spring/resource/RunnableFileSystemResource.java b/src/main/java/net/shibboleth/ext/spring/resource/RunnableFileSystemResource.java
index 066c60b..55a0eb5 100644
--- a/src/main/java/net/shibboleth/ext/spring/resource/RunnableFileSystemResource.java
+++ b/src/main/java/net/shibboleth/ext/spring/resource/RunnableFileSystemResource.java
@@ -123,7 +123,7 @@ public class RunnableFileSystemResource extends FileSystemResource
         try {
             theRunnable.run();
         } catch (final Exception ex) {
-            log.error("{} : Runnable failed", thePrefix, ex);
+            log.error("{} : Runnable failed: {}", thePrefix, ex.getMessage());
             throw new IOException(ex);
         }
     }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list