[java-support] branch master updated: IDP-1319 - Reduce redundant stack traces in log

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch master
in repository java-support.

View the commit online:
http://git.shibboleth.net/view/?p=java-support.git;a=commit;h=a6c7763b3381588432cca84309de0962c8b86e74

The following commit(s) were added to refs/heads/master by this push:
       new  a6c7763   IDP-1319 - Reduce redundant stack traces in log
a6c7763 is described below

commit a6c7763b3381588432cca84309de0962c8b86e74
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Thu Dec 19 10:47:12 2019 -0500

    IDP-1319 - Reduce redundant stack traces in log
    
    https://issues.shibboleth.net/jira/browse/IDP-1319
---
 .../utilities/java/support/resolver/CriterionPredicateRegistry.java | 2 +-
 .../java/support/security/impl/BasicKeystoreKeyStrategy.java        | 6 +++---
 .../utilities/java/support/security/impl/ScriptedKeyStrategy.java   | 2 +-
 .../net/shibboleth/utilities/java/support/xml/BasicParserPool.java  | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/main/java/net/shibboleth/utilities/java/support/resolver/CriterionPredicateRegistry.java b/src/main/java/net/shibboleth/utilities/java/support/resolver/CriterionPredicateRegistry.java
index a22b877..28af293 100644
--- a/src/main/java/net/shibboleth/utilities/java/support/resolver/CriterionPredicateRegistry.java
+++ b/src/main/java/net/shibboleth/utilities/java/support/resolver/CriterionPredicateRegistry.java
@@ -86,7 +86,7 @@ public class CriterionPredicateRegistry<T> {
 
             } catch (final SecurityException | InstantiationException | IllegalAccessException 
                     | IllegalArgumentException | InvocationTargetException | NoSuchMethodException e) {
-                log.error("Error instantiating new Predicate instance", e);
+                log.error("Error instantiating new Predicate instance: {}", e.getMessage());
                 throw new ResolverException("Could not create new Predicate instance", e);
             }
         }
diff --git a/src/main/java/net/shibboleth/utilities/java/support/security/impl/BasicKeystoreKeyStrategy.java b/src/main/java/net/shibboleth/utilities/java/support/security/impl/BasicKeystoreKeyStrategy.java
index 67a6dee..984d765 100644
--- a/src/main/java/net/shibboleth/utilities/java/support/security/impl/BasicKeystoreKeyStrategy.java
+++ b/src/main/java/net/shibboleth/utilities/java/support/security/impl/BasicKeystoreKeyStrategy.java
@@ -248,7 +248,7 @@ public class BasicKeystoreKeyStrategy extends AbstractInitializableComponent imp
             updateDefaultKey();
     
         } catch (final KeyException e) {
-            log.error("Error loading default key from base name '{}'", keyAlias, e);
+            log.error("Error loading default key from base name '{}' {}", keyAlias, e.getMessage());
             throw new ComponentInitializationException("Exception loading the default key", e);
         }
 
@@ -327,7 +327,7 @@ public class BasicKeystoreKeyStrategy extends AbstractInitializableComponent imp
             return (SecretKey) loadedKey;
         } catch (final KeyStoreException | NoSuchAlgorithmException | CertificateException
                     | IOException | UnrecoverableKeyException e) {
-            log.error("Error loading key named '{}'", name, e);
+            log.error("Error loading key named '{}': {}", name, e.getMessage());
             throw new KeyException(e);
         }
     }
@@ -373,7 +373,7 @@ public class BasicKeystoreKeyStrategy extends AbstractInitializableComponent imp
                 log.info("Default key updated to {}", currentAlias);
                 
             } catch (final IOException e) {
-                log.error("IOException updating key version", e);
+                log.error("IOException updating key version: {}", e.getMessage());
                 throw new KeyException(e);
             }
         }
diff --git a/src/main/java/net/shibboleth/utilities/java/support/security/impl/ScriptedKeyStrategy.java b/src/main/java/net/shibboleth/utilities/java/support/security/impl/ScriptedKeyStrategy.java
index 071ce25..219fc4c 100644
--- a/src/main/java/net/shibboleth/utilities/java/support/security/impl/ScriptedKeyStrategy.java
+++ b/src/main/java/net/shibboleth/utilities/java/support/security/impl/ScriptedKeyStrategy.java
@@ -178,7 +178,7 @@ public class ScriptedKeyStrategy extends AbstractInitializableComponent implemen
             updateDefaultKey();
     
         } catch (final KeyException e) {
-            log.error("Error loading default key", e);
+            log.error("Error loading default key: {}", e.getMessage());
             throw new ComponentInitializationException("Exception loading the default key", e);
         }
 
diff --git a/src/main/java/net/shibboleth/utilities/java/support/xml/BasicParserPool.java b/src/main/java/net/shibboleth/utilities/java/support/xml/BasicParserPool.java
index 204ca58..bdccbdc 100644
--- a/src/main/java/net/shibboleth/utilities/java/support/xml/BasicParserPool.java
+++ b/src/main/java/net/shibboleth/utilities/java/support/xml/BasicParserPool.java
@@ -590,7 +590,7 @@ public class BasicParserPool extends AbstractInitializableComponent implements P
 
             return builder;
         } catch (final ParserConfigurationException e) {
-            log.debug("Unable to create new document builder", e);
+            log.debug("Unable to create new document builder: {}", e.getMessage());
             throw new XMLParserException("Unable to create new document builder", e);
         }
     }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.