[java-identity-provider] branch master updated: IDP-1476 - Need a filter to append SameSite to cookies

Scott Cantor cantor.2 at osu.edu
Wed Dec 18 19:57:53 EST 2019


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch master
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=4f2ad3e6b33827ad7d182fd40fde7e7f038211b6

The following commit(s) were added to refs/heads/master by this push:
       new  4f2ad3e   IDP-1476 - Need a filter to append SameSite to cookies
4f2ad3e is described below

commit 4f2ad3e6b33827ad7d182fd40fde7e7f038211b6
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Wed Dec 18 19:57:48 2019 -0500

    IDP-1476 - Need a filter to append SameSite to cookies
    
    https://issues.shibboleth.net/jira/browse/IDP-1476
    
    Expose filter configuration to deployer.
---
 idp-conf/src/main/resources/conf/idp.properties           | 1 +
 idp-conf/src/main/resources/system/conf/global-system.xml | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/idp-conf/src/main/resources/conf/idp.properties b/idp-conf/src/main/resources/conf/idp.properties
index b6caf41..1dab556 100644
--- a/idp-conf/src/main/resources/conf/idp.properties
+++ b/idp-conf/src/main/resources/conf/idp.properties
@@ -23,6 +23,7 @@ idp.scope = example.org
 #idp.cookie.domain =
 #idp.cookie.path =
 #idp.cookie.maxAge = 31536000
+#idp.cookie.sameSite = None
 
 # Enable cross-site request forgery mitigation for views. 
 idp.csrf.enabled = true
diff --git a/idp-conf/src/main/resources/system/conf/global-system.xml b/idp-conf/src/main/resources/system/conf/global-system.xml
index f719000..48b309f 100644
--- a/idp-conf/src/main/resources/system/conf/global-system.xml
+++ b/idp-conf/src/main/resources/system/conf/global-system.xml
@@ -173,7 +173,8 @@
         
     <bean id="shibboleth.SameSiteCookieFilter"
         class="net.shibboleth.utilities.java.support.net.SameSiteCookieHeaderFilter"
-        p:defaultValue="None" />
+        p:defaultValue="%{idp.cookie.sameSite:None}"
+        p:sameSiteCookies="#{getObject('shibboleth.SameSiteCookieMap')}" />
 
     <bean id="shibboleth.BuilderFactory" factory-method="getBuilderFactory" class="org.opensaml.core.xml.config.XMLObjectProviderRegistrySupport" depends-on="shibboleth.OpenSAMLConfig" />
     <bean id="shibboleth.MarshallerFactory" factory-method="getMarshallerFactory" class="org.opensaml.core.xml.config.XMLObjectProviderRegistrySupport" depends-on="shibboleth.OpenSAMLConfig" />

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list