[java-identity-provider] branch master updated: Remove redundant null check.

Scott Cantor cantor.2 at osu.edu
Wed Dec 4 11:21:35 EST 2019


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch master
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=792943d6d11ceab1ec665135b8d1f46407ab1531

The following commit(s) were added to refs/heads/master by this push:
       new  792943d   Remove redundant null check.
792943d is described below

commit 792943d6d11ceab1ec665135b8d1f46407ab1531
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Wed Dec 4 11:21:32 2019 -0500

    Remove redundant null check.
---
 .../shibboleth/idp/authn/impl/ValidateExternalAuthentication.java | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ValidateExternalAuthentication.java b/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ValidateExternalAuthentication.java
index 5af7892..70be416 100644
--- a/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ValidateExternalAuthentication.java
+++ b/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ValidateExternalAuthentication.java
@@ -57,7 +57,6 @@ import org.slf4j.LoggerFactory;
  * contents.
  *  
  * @event {@link EventIds#PROCEED_EVENT_ID}
- * @event {@link EventIds#INVALID_PROFILE_CTX}
  * @event {@link AuthnEventIds#INVALID_AUTHN_CTX}
  * @event {@link AuthnEventIds#AUTHN_EXCEPTION}
  * @event {@link AuthnEventIds#NO_CREDENTIALS}
@@ -141,13 +140,6 @@ public class ValidateExternalAuthentication extends AbstractValidationAction {
             return false;
         }
         
-        if (authenticationContext.getAttemptedFlow() == null) {
-            log.debug("{} No attempted flow within authentication context", getLogPrefix());
-            ActionSupport.buildEvent(profileRequestContext, EventIds.INVALID_PROFILE_CTX);
-            recordFailure();
-            return false;
-        }
-        
         extContext = authenticationContext.getSubcontext(ExternalAuthenticationContext.class);
         if (extContext == null) {
             log.debug("{} No ExternalAuthenticationContext available within authentication context", getLogPrefix());

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list