[java-opensaml] 14/16: Throw rather than warn on missing Status in ArtifactResponse.

Brent Putman putmanb at georgetown.edu
Fri Sep 21 22:48:52 EDT 2018


This is an automated email from the git hooks/post-receive script.

putmanb pushed a commit to branch master
in repository java-opensaml.

View the commit online:
http://git.shibboleth.net/view/?p=java-opensaml.git;a=commit;h=e7fbad00e864a1bbe387de8cf684d0e6a57cba3c

commit e7fbad00e864a1bbe387de8cf684d0e6a57cba3c
Author: Brent Putman <putmanb at georgetown.edu>
AuthorDate: Fri Sep 21 19:43:35 2018 -0400

    Throw rather than warn on missing Status in ArtifactResponse.
---
 .../opensaml/saml/saml2/binding/decoding/impl/HTTPArtifactDecoder.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/binding/decoding/impl/HTTPArtifactDecoder.java b/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/binding/decoding/impl/HTTPArtifactDecoder.java
index 4ded051..88cd9ae 100644
--- a/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/binding/decoding/impl/HTTPArtifactDecoder.java
+++ b/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/binding/decoding/impl/HTTPArtifactDecoder.java
@@ -487,7 +487,7 @@ public class HTTPArtifactDecoder extends BaseHttpServletRequestXMLMessageDecoder
                 || artifactResponse.getStatus().getStatusCode() == null 
                 || artifactResponse.getStatus().getStatusCode().getValue() == null) {
             
-            log.warn("ArtifactResponse included no StatusCode, could not validate");
+            throw new MessageDecodingException("ArtifactResponse included no StatusCode, could not validate");
             
         } else if (!StatusCode.SUCCESS.equals(artifactResponse.getStatus().getStatusCode().getValue())){
             throw new MessageDecodingException("ArtifactResponse carried non-success StatusCode: " 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list