[java-identity-provider] 01/02: IDP-1328 Use simpler regexp..

Rod Widdowson rdw at steadingsoftware.com
Wed Sep 12 04:10:00 EDT 2018


This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch master
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=3f85cd5bc94f2f02cb92a1b555be4e1acecc8e9c

commit 3f85cd5bc94f2f02cb92a1b555be4e1acecc8e9c
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Wed Sep 12 09:06:04 2018 +0100

    IDP-1328 Use simpler regexp..
    
    https://issues.shibboleth.net/jira/browse/IDP-1328
    
    Check that the attribute name consists of nothing but printing
    characters and not it rather than checking that the attribute
    name contains at least one non  printer.
---
 .../shibboleth/idp/attribute/resolver/AbstractAttributeDefinition.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/AbstractAttributeDefinition.java b/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/AbstractAttributeDefinition.java
index aef26d1..df1eb8e 100644
--- a/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/AbstractAttributeDefinition.java
+++ b/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/AbstractAttributeDefinition.java
@@ -230,7 +230,7 @@ public abstract class AbstractAttributeDefinition extends AbstractResolverPlugin
         // The Id is now definitive. Just in case it was used prior to that, reset the getPrefixCache
         logPrefix = null;
         
-        if (Pattern.matches(".*\\s.*", getId())) {
+        if (!Pattern.matches("\\S*", getId())) {
             DeprecationSupport.warn(ObjectType.CONFIGURATION, 
                     "Use of IdP Attributes names with spaces in them", 
                     getLogPrefix(), 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list