[java-opensaml] branch master updated: Checkstyle warnings.

Scott Cantor cantor.2 at osu.edu
Mon Nov 19 12:20:42 EST 2018


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch master
in repository java-opensaml.

View the commit online:
http://git.shibboleth.net/view/?p=java-opensaml.git;a=commit;h=b864b2d306f24376beb00ab7befa97e0a4bd344f

The following commit(s) were added to refs/heads/master by this push:
       new  b864b2d   Checkstyle warnings.
b864b2d is described below

commit b864b2d306f24376beb00ab7befa97e0a4bd344f
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Mon Nov 19 12:20:36 2018 -0500

    Checkstyle warnings.
---
 .../saml/saml2/profile/SAML2ObjectSupport.java         | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/profile/SAML2ObjectSupport.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/profile/SAML2ObjectSupport.java
index bc350e0..c763590 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/profile/SAML2ObjectSupport.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/profile/SAML2ObjectSupport.java
@@ -84,24 +84,30 @@ public final class SAML2ObjectSupport {
             @Nullable final String assertingParty, @Nullable final String relyingParty) {
         
         if (!areNameIDFormatsEquivalent(name1.getFormat(), name2.getFormat())
-                || !Objects.equals(name1.getValue(), name2.getValue()))
+                || !Objects.equals(name1.getValue(), name2.getValue())) {
             return false;
+        }
         
         String name1qual = name1.getNameQualifier();
         String name2qual = name2.getNameQualifier();
-        if (name1qual == null)
+        if (name1qual == null) {
             name1qual = assertingParty;
-        if (name2qual == null)
+        }
+        if (name2qual == null) {
             name2qual = assertingParty;
-        if (!Objects.equals(name1qual, name2qual))
+        }
+        if (!Objects.equals(name1qual, name2qual)) {
             return false;
+        }
 
         name1qual = name1.getSPNameQualifier();
         name2qual = name2.getSPNameQualifier();
-        if (name1qual == null)
+        if (name1qual == null) {
             name1qual = relyingParty;
-        if (name2qual == null)
+        }
+        if (name2qual == null) {
             name2qual = relyingParty;
+        }
         return Objects.equals(name1qual, name2qual);
     }
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list