[cpp-log4shib] 17/17: Fix compiler warnings.

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch master
in repository cpp-log4shib.

View the commit online:
http://git.shibboleth.net/view/?p=cpp-log4shib.git;a=commit;h=16b7cc3b02ccdc40cf6c12ff32038e5cc3000194

commit 16b7cc3b02ccdc40cf6c12ff32038e5cc3000194
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Mon Jun 25 10:18:06 2018 -0400

    Fix compiler warnings.
---
 include/log4shib/FixedContextCategory.hh |  6 ------
 include/log4shib/RemoteSyslogAppender.hh |  2 ++
 src/AbortAppender.cpp                    |  4 ++--
 src/FixedContextCategory.cpp             | 12 ++++--------
 src/NDC.cpp                              |  2 +-
 src/PatternLayout.cpp                    |  4 ++--
 src/PropertyConfiguratorImpl.cpp         |  1 -
 src/RemoteSyslogAppender.cpp             |  6 ++++--
 8 files changed, 15 insertions(+), 22 deletions(-)

diff --git a/include/log4shib/FixedContextCategory.hh b/include/log4shib/FixedContextCategory.hh
index 1e97300..2153aba 100644
--- a/include/log4shib/FixedContextCategory.hh
+++ b/include/log4shib/FixedContextCategory.hh
@@ -116,12 +116,6 @@ namespace log4shib {
          * FixedContextAppenders cannot own Appenders.
          * @returns false
          **/
-        virtual bool ownsAppender() const throw();
-
-        /**
-         * FixedContextAppenders cannot own Appenders.
-         * @returns false
-         **/
         virtual bool ownsAppender(Appender* appender)
             const throw();
 
diff --git a/include/log4shib/RemoteSyslogAppender.hh b/include/log4shib/RemoteSyslogAppender.hh
index ad09cf0..10cc57a 100644
--- a/include/log4shib/RemoteSyslogAppender.hh
+++ b/include/log4shib/RemoteSyslogAppender.hh
@@ -128,7 +128,9 @@ namespace log4shib {
         int _socket;
         in_addr_t _ipAddr;
         private:
+#ifdef WIN32
         int _cludge;
+#endif
     };
 }
 
diff --git a/src/AbortAppender.cpp b/src/AbortAppender.cpp
index af08685..45a6f55 100644
--- a/src/AbortAppender.cpp
+++ b/src/AbortAppender.cpp
@@ -25,7 +25,7 @@ namespace log4shib {
         // empty
     }
 
-    void AbortAppender::_append(const LoggingEvent& event) {
+    void AbortAppender::_append(const LoggingEvent&) {
         std::abort();
     }
 
@@ -37,7 +37,7 @@ namespace log4shib {
         return false;
     }
 
-    void AbortAppender::setLayout(Layout* layout) {
+    void AbortAppender::setLayout(Layout*) {
         return;
     }
 }
diff --git a/src/FixedContextCategory.cpp b/src/FixedContextCategory.cpp
index b864470..d185467 100644
--- a/src/FixedContextCategory.cpp
+++ b/src/FixedContextCategory.cpp
@@ -44,11 +44,11 @@ namespace log4shib {
         return result;
     }
     
-    void FixedContextCategory::addAppender(Appender* appender) throw() {
+    void FixedContextCategory::addAppender(Appender*) throw() {
         // XXX do nothing for now
     }
     
-    void FixedContextCategory::addAppender(Appender& appender) {
+    void FixedContextCategory::addAppender(Appender&) {
         // XXX do nothing for now
     }
     
@@ -68,12 +68,8 @@ namespace log4shib {
     void FixedContextCategory::removeAllAppenders() {
         // XXX do nothing for now
     }
-
-    bool FixedContextCategory::ownsAppender() const throw() {
-        return false;
-    }
     
-    bool FixedContextCategory::ownsAppender(Appender* appender) const throw() {
+    bool FixedContextCategory::ownsAppender(Appender*) const throw() {
         return false;
     }
     
@@ -82,7 +78,7 @@ namespace log4shib {
         _delegate.callAppenders(event);
     }
 
-    void FixedContextCategory::setAdditivity(bool additivity) {
+    void FixedContextCategory::setAdditivity(bool) {
         // XXX do nothing for now
     }
 
diff --git a/src/NDC.cpp b/src/NDC.cpp
index c39f5ac..ecaefbd 100644
--- a/src/NDC.cpp
+++ b/src/NDC.cpp
@@ -113,7 +113,7 @@ namespace log4shib {
         }
     }
 
-    void NDC::_setMaxDepth(int maxDepth) {
+    void NDC::_setMaxDepth(int) {
         // XXX no maximum
     }
 
diff --git a/src/PatternLayout.cpp b/src/PatternLayout.cpp
index 5fe2b3b..6ee2877 100644
--- a/src/PatternLayout.cpp
+++ b/src/PatternLayout.cpp
@@ -55,7 +55,7 @@ namespace log4shib {
             _literal(literal) {
         }
 
-        virtual void append(std::ostringstream& out, const LoggingEvent& event) {
+        virtual void append(std::ostringstream& out, const LoggingEvent&) {
             out << _literal;
         }
 
@@ -123,7 +123,7 @@ namespace log4shib {
     };
 
     struct ProcessorTimeComponent : public PatternLayout::PatternComponent {
-        virtual void append(std::ostringstream& out, const LoggingEvent& event) {
+        virtual void append(std::ostringstream& out, const LoggingEvent&) {
             out << ::clock();
         }
     };
diff --git a/src/PropertyConfiguratorImpl.cpp b/src/PropertyConfiguratorImpl.cpp
index 8372fb9..2bfef39 100644
--- a/src/PropertyConfiguratorImpl.cpp
+++ b/src/PropertyConfiguratorImpl.cpp
@@ -97,7 +97,6 @@ namespace log4shib {
         Properties::const_iterator to = _properties.lower_bound(prefix + '/');
         for(Properties::const_iterator i = from; i != to; ++i) {
             const std::string& key = (*i).first;
-            const std::string& value = (*i).second;
             std::list<std::string> propNameParts;
             std::back_insert_iterator<std::list<std::string> > pnpIt(propNameParts);
             StringUtil::split(pnpIt, key, '.');
diff --git a/src/RemoteSyslogAppender.cpp b/src/RemoteSyslogAppender.cpp
index d736232..77ec07c 100644
--- a/src/RemoteSyslogAppender.cpp
+++ b/src/RemoteSyslogAppender.cpp
@@ -66,8 +66,10 @@ namespace log4shib {
         _facility((facility == -1) ? LOG_USER : facility),
         _portNumber((portNumber == -1) ? 514 : portNumber),
         _socket (0),
-        _ipAddr (0),
-        _cludge (0)
+        _ipAddr (0)
+#ifdef WIN32
+        ,_cludge (0)
+#endif
     {
         open();
     }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.