[java-support] 03/07: IDP-1047 Add a couple of missing @ParameterName annotations

Ian Young ian at iay.org.uk
Mon Jul 30 11:55:20 EDT 2018


This is an automated email from the git hooks/post-receive script.

iay pushed a commit to branch master
in repository java-support.

View the commit online:
http://git.shibboleth.net/view/?p=java-support.git;a=commit;h=44673d1a9995df04de9bf901c1399e37e2896f4b

commit 44673d1a9995df04de9bf901c1399e37e2896f4b
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Mon May 28 15:45:56 2018 +0100

    IDP-1047 Add a couple of missing @ParameterName annotations
    
    https://issues.shibboleth.net/jira/browse/IDP-1047
---
 .../security/SecureRandomIdentifierGenerationStrategy.java       | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/src/main/java/net/shibboleth/utilities/java/support/security/SecureRandomIdentifierGenerationStrategy.java b/src/main/java/net/shibboleth/utilities/java/support/security/SecureRandomIdentifierGenerationStrategy.java
index 10d5307..77d29ad 100644
--- a/src/main/java/net/shibboleth/utilities/java/support/security/SecureRandomIdentifierGenerationStrategy.java
+++ b/src/main/java/net/shibboleth/utilities/java/support/security/SecureRandomIdentifierGenerationStrategy.java
@@ -23,6 +23,8 @@ import javax.annotation.Nonnull;
 
 import org.apache.commons.codec.BinaryEncoder;
 
+import net.shibboleth.utilities.java.support.annotation.ParameterName;
+
 /**
  * A specialized subclass of {@link RandomIdentifierGenerationStrategy} which constrains the supplied
  * random number generator to be an instance of {@link SecureRandom}.
@@ -43,7 +45,7 @@ public class SecureRandomIdentifierGenerationStrategy extends RandomIdentifierGe
      * 
      * @param identifierSize number of random bytes in identifier
      */
-    public SecureRandomIdentifierGenerationStrategy(final int identifierSize) {
+    public SecureRandomIdentifierGenerationStrategy(@ParameterName(name="identifierSize") final int identifierSize) {
         super(identifierSize);
     }
 
@@ -54,8 +56,9 @@ public class SecureRandomIdentifierGenerationStrategy extends RandomIdentifierGe
      * @param identifierSize number of random bytes in the identifier
      * @param identifierEncoder encoder used to convert random bytes to string identifier
      */
-    public SecureRandomIdentifierGenerationStrategy(@Nonnull final SecureRandom source, final int identifierSize,
-            @Nonnull final BinaryEncoder identifierEncoder) {
+    public SecureRandomIdentifierGenerationStrategy(@ParameterName(name="source") @Nonnull final SecureRandom source, 
+            @ParameterName(name="identifierSize") final int identifierSize,
+            @ParameterName(name="identifierEncoder") @Nonnull final BinaryEncoder identifierEncoder) {
         super(source, identifierSize, identifierEncoder);
     }
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list