[cpp-sp] branch master updated: SSPCPP-774 - Missing nullptr check in implicit std::string construction

[Rod Widdowson]

This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch master
in repository cpp-sp.

View the commit online:
http://git.shibboleth.net/view/?p=cpp-sp.git;a=commit;h=a80ca88e1e4f0be98906aa7752f99c0c40ce6a65

The following commit(s) were added to refs/heads/master by this push:
       new  a80ca88   SSPCPP-774 - Missing nullptr check in implicit std::string construction
a80ca88 is described below

commit a80ca88e1e4f0be98906aa7752f99c0c40ce6a65
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Sun Nov 12 21:07:39 2017 -0500

    SSPCPP-774 - Missing nullptr check in implicit std::string construction
    
    https://issues.shibboleth.net/jira/browse/SSPCPP-728
    https://issues.shibboleth.net/jira/browse/SSPCPP-774
---
 shibsp/handler/impl/RemotedHandler.cpp | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/shibsp/handler/impl/RemotedHandler.cpp b/shibsp/handler/impl/RemotedHandler.cpp
index 57b26ca..cc4e96c 100644
--- a/shibsp/handler/impl/RemotedHandler.cpp
+++ b/shibsp/handler/impl/RemotedHandler.cpp
@@ -484,8 +484,11 @@ pair<bool,long> RemotedHandler::unwrap(SPRequest& request, DDF& out) const
         return make_pair(true, request.sendRedirect(h.string()));
     h = out["response"];
     if (h.isstruct()) {
-        istringstream s(h["data"].string());
-        return make_pair(true, request.sendResponse(s, h["status"].integer()));
+        const char* data = h["data"].string();
+        if (data) {
+            istringstream s(data);
+            return make_pair(true, request.sendResponse(s, h["status"].integer()));
+        }
     }
     return make_pair(false, 0L);
 }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.