[spring-extensions] branch maint-5 updated: Provisionally document the factory beans as a deprecated API.

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch maint-5
in repository spring-extensions.

View the commit online:
http://git.shibboleth.net/view/?p=spring-extensions.git;a=commit;h=da73d09a6c4ec4f095ed90e1eb97dad231942343

The following commit(s) were added to refs/heads/maint-5 by this push:
       new  da73d09   Provisionally document the factory beans as a deprecated API.
da73d09 is described below

commit da73d09a6c4ec4f095ed90e1eb97dad231942343
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Wed Jan 17 12:05:50 2018 -0500

    Provisionally document the factory beans as a deprecated API.
---
 .../ext/spring/factory/FileCachingHttpClientFactoryBean.java     | 9 +++++++--
 .../net/shibboleth/ext/spring/factory/HttpClientFactoryBean.java | 5 +++++
 .../ext/spring/factory/InMemoryCachingHttpClientFactoryBean.java | 9 +++++++--
 3 files changed, 19 insertions(+), 4 deletions(-)

diff --git a/src/main/java/net/shibboleth/ext/spring/factory/FileCachingHttpClientFactoryBean.java b/src/main/java/net/shibboleth/ext/spring/factory/FileCachingHttpClientFactoryBean.java
index 6f021d9..b639489 100644
--- a/src/main/java/net/shibboleth/ext/spring/factory/FileCachingHttpClientFactoryBean.java
+++ b/src/main/java/net/shibboleth/ext/spring/factory/FileCachingHttpClientFactoryBean.java
@@ -27,8 +27,13 @@ import net.shibboleth.utilities.java.support.httpclient.HttpClientBuilder;
 import org.apache.http.client.HttpClient;
 
 /**
+ * @deprecated
+ * 
  * Factory bean to accumulate the parameters into a {@link FileCachingHttpClientBuilder} 
  * and to then emit a {@link org.apache.http.client.HttpClient}.
+ * 
+ * <p>This class will likely either be removed or moved into an implementation package.
+ * Use {@link FileCachingHttpClientBuilder} instead.</p>
  */
 public class FileCachingHttpClientFactoryBean extends HttpClientFactoryBean {
     
@@ -38,7 +43,6 @@ public class FileCachingHttpClientFactoryBean extends HttpClientFactoryBean {
 
     /** Constructor. */
     public FileCachingHttpClientFactoryBean() {
-        super();
         clientRefs = new ArrayList<>();
     }
 
@@ -90,4 +94,5 @@ public class FileCachingHttpClientFactoryBean extends HttpClientFactoryBean {
         }
         return client;
     }
-}
+    
+}
\ No newline at end of file
diff --git a/src/main/java/net/shibboleth/ext/spring/factory/HttpClientFactoryBean.java b/src/main/java/net/shibboleth/ext/spring/factory/HttpClientFactoryBean.java
index 0a37401..d2356ae 100644
--- a/src/main/java/net/shibboleth/ext/spring/factory/HttpClientFactoryBean.java
+++ b/src/main/java/net/shibboleth/ext/spring/factory/HttpClientFactoryBean.java
@@ -26,7 +26,12 @@ import org.apache.http.client.HttpClient;
 import org.apache.http.conn.socket.LayeredConnectionSocketFactory;
 
 /**
+ * @deprecated
+ * 
  * Factory bean to accumulate the parameters into a {@link HttpClientBuilder} and to then emit a {@link HttpClient}.
+ * 
+ * <p>This class will likely either be removed or moved into an implementation package.
+ * Use {@link HttpClientBuilder} instead.</p>
  */
 public class HttpClientFactoryBean extends AbstractComponentAwareFactoryBean<HttpClient> {
 
diff --git a/src/main/java/net/shibboleth/ext/spring/factory/InMemoryCachingHttpClientFactoryBean.java b/src/main/java/net/shibboleth/ext/spring/factory/InMemoryCachingHttpClientFactoryBean.java
index 33e95e2..c162ae5 100644
--- a/src/main/java/net/shibboleth/ext/spring/factory/InMemoryCachingHttpClientFactoryBean.java
+++ b/src/main/java/net/shibboleth/ext/spring/factory/InMemoryCachingHttpClientFactoryBean.java
@@ -21,14 +21,19 @@ import net.shibboleth.utilities.java.support.httpclient.HttpClientBuilder;
 import net.shibboleth.utilities.java.support.httpclient.InMemoryCachingHttpClientBuilder;
 
 /**
+ * @deprecated
+ * 
  * Factory bean to accumulate the parameters into a {@link InMemoryCachingHttpClientBuilder} and to then emit a
  * {@link org.apache.http.client.HttpClient}.
+ * 
+ * <p>This class will likely either be removed or moved into an implementation package.
+ * Use {@link InMemoryCachingHttpClientBuilder} instead.</p>
  */
 public class InMemoryCachingHttpClientFactoryBean extends HttpClientFactoryBean {
 
     /** Constructor. */
     public InMemoryCachingHttpClientFactoryBean() {
-        super();
+        
     }
 
     /**
@@ -54,4 +59,4 @@ public class InMemoryCachingHttpClientFactoryBean extends HttpClientFactoryBean
         return new InMemoryCachingHttpClientBuilder();
     }
 
-}
+}
\ No newline at end of file

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.