[cpp-sp] 02/02: Convert some late-added methods into pure-virtuals.

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch master
in repository cpp-sp.

View the commit online:
http://git.shibboleth.net/view/?p=cpp-sp.git;a=commit;h=1fb86ba81ab4f7af093e461cc8d214cf5b5aa7b1

commit 1fb86ba81ab4f7af093e461cc8d214cf5b5aa7b1
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Tue Feb 6 09:00:54 2018 -0500

    Convert some late-added methods into pure-virtuals.
---
 shibsp/AbstractSPRequest.cpp | 19 ++++++++++---------
 shibsp/AbstractSPRequest.h   |  2 ++
 shibsp/SPRequest.h           |  4 ++--
 3 files changed, 14 insertions(+), 11 deletions(-)

diff --git a/shibsp/AbstractSPRequest.cpp b/shibsp/AbstractSPRequest.cpp
index fe0de14..68f6b23 100644
--- a/shibsp/AbstractSPRequest.cpp
+++ b/shibsp/AbstractSPRequest.cpp
@@ -48,15 +48,6 @@ SPRequest::~SPRequest()
 {
 }
 
-string SPRequest::getSecureHeader(const char* name) const
-{
-    return getHeader(name);
-}
-
-void SPRequest::setAuthType(const char* authtype)
-{
-}
-
 #ifdef SHIBSP_HAVE_GSSAPI
 GSSRequest::GSSRequest()
 {
@@ -342,6 +333,16 @@ const char* AbstractSPRequest::getHandlerURL(const char* resource) const
     return m_handlerURL.c_str();
 }
 
+string AbstractSPRequest::getSecureHeader(const char* name) const
+{
+    return getHeader(name);
+}
+
+void AbstractSPRequest::setAuthType(const char* authtype)
+{
+
+}
+
 void AbstractSPRequest::log(SPLogLevel level, const std::string& msg) const
 {
     reinterpret_cast<Category*>(m_log)->log(
diff --git a/shibsp/AbstractSPRequest.h b/shibsp/AbstractSPRequest.h
index 0a2799b..cc6144c 100644
--- a/shibsp/AbstractSPRequest.h
+++ b/shibsp/AbstractSPRequest.h
@@ -74,6 +74,8 @@ namespace shibsp {
         const char* getParameter(const char* name) const;
         std::vector<const char*>::size_type getParameters(const char* name, std::vector<const char*>& values) const;
         const char* getHandlerURL(const char* resource=nullptr) const;
+        std::string getSecureHeader(const char* name) const;
+        void setAuthType(const char* authtype);
         void log(SPLogLevel level, const std::string& msg) const;
         bool isPriorityEnabled(SPLogLevel level) const;
 
diff --git a/shibsp/SPRequest.h b/shibsp/SPRequest.h
index 7187be8..8764d79 100644
--- a/shibsp/SPRequest.h
+++ b/shibsp/SPRequest.h
@@ -102,7 +102,7 @@ namespace shibsp {
          * @param name  the name of the secure header to return
          * @return the header's value, or an empty string
          */
-        virtual std::string getSecureHeader(const char* name) const;
+        virtual std::string getSecureHeader(const char* name) const=0;
 
         /**
          * Ensures no value exists for a request header.
@@ -132,7 +132,7 @@ namespace shibsp {
          *
          * @param authtype  AUTH_TYPE value to set or nullptr to clear
          */
-        virtual void setAuthType(const char* authtype);
+        virtual void setAuthType(const char* authtype)=0;
 
         /** Portable logging levels. */
         enum SPLogLevel {

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.