[cpp-sp] 30/34: Fix logic mistake in shibd as non-root user probe

Scott Cantor cantor.2 at osu.edu
Thu Dec 20 19:43:36 EST 2018


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to annotated tag debian/2.3+dfsg-1
in repository cpp-sp.

View the commit online:
http://git.shibboleth.net/view/?p=cpp-sp.git;a=commit;h=f9647c21285bf4f9c6f26ed2ac65f6df3b702e97

commit f9647c21285bf4f9c6f26ed2ac65f6df3b702e97
Author: Russ Allbery <rra at debian.org>
AuthorDate: Tue Nov 10 17:34:29 2009 -0800

    Fix logic mistake in shibd as non-root user probe
    
    I introduced a logic error when refactoring the init script.  shibd -t
    doesn't return non-zero status when it can't open the private key file.
---
 configs/shibd-debian.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configs/shibd-debian.in b/configs/shibd-debian.in
index cbe55e6..c96f2d6 100644
--- a/configs/shibd-debian.in
+++ b/configs/shibd-debian.in
@@ -64,7 +64,7 @@ prepare_environment () {
     # read.  If we get that error, we fall back on running shibd as root.
     if [ -n "$DAEMON_USER" ]; then
         DIAG=$(su -s $DAEMON $DAEMON_USER -- -t $DAEMON_OPTS 2>/dev/null)
-        if [ $? != 0 ] ; then
+        if [ $? = 0 ] ; then
             # openssl errstr 200100D (hex for 33558541) says:
             # error:0200100D:system library:fopen:Permission denied
             ERROR='ERROR OpenSSL : error code: 33558541 '

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list