[java-identity-provider] branch master updated: IDP-1371 Address code review feedback.

[Marvin S. Addison]

This is an automated email from the git hooks/post-receive script.

serac pushed a commit to branch master
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=4b1d1d4395a9d92f6f1e552d66d3b4b7cbf89b51

The following commit(s) were added to refs/heads/master by this push:
       new  4b1d1d4   IDP-1371 Address code review feedback.
4b1d1d4 is described below

commit 4b1d1d4395a9d92f6f1e552d66d3b4b7cbf89b51
Author: Marvin S. Addison <serac at vt.edu>
AuthorDate: Wed Dec 12 10:05:57 2018 -0500

    IDP-1371 Address code review feedback.
---
 .../net/shibboleth/idp/cas/proxy/impl/HttpClientProxyValidator.java     | 1 +
 idp-conf/src/main/resources/system/conf/cas-protocol-system.xml         | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/idp-cas-impl/src/main/java/net/shibboleth/idp/cas/proxy/impl/HttpClientProxyValidator.java b/idp-cas-impl/src/main/java/net/shibboleth/idp/cas/proxy/impl/HttpClientProxyValidator.java
index f39ab3f..a578c37 100644
--- a/idp-cas-impl/src/main/java/net/shibboleth/idp/cas/proxy/impl/HttpClientProxyValidator.java
+++ b/idp-cas-impl/src/main/java/net/shibboleth/idp/cas/proxy/impl/HttpClientProxyValidator.java
@@ -159,6 +159,7 @@ public class HttpClientProxyValidator implements ProxyValidator {
             log.debug("Attempting to validate CAS proxy callback URI {}", uri);
             final HttpGet request = new HttpGet(uri);
             response = httpClient.execute(request, clientContext);
+            HttpClientSecuritySupport.checkTLSCredentialEvaluated(clientContext, request.getURI().getScheme());
             return response.getStatusLine().getStatusCode();
         } catch (final ClientProtocolException e) {
             throw new GeneralSecurityException("HTTP protocol error", e);
diff --git a/idp-conf/src/main/resources/system/conf/cas-protocol-system.xml b/idp-conf/src/main/resources/system/conf/cas-protocol-system.xml
index b9e505a..d52702f 100644
--- a/idp-conf/src/main/resources/system/conf/cas-protocol-system.xml
+++ b/idp-conf/src/main/resources/system/conf/cas-protocol-system.xml
@@ -48,7 +48,7 @@
                               c:resolver-ref="shibboleth.MetadataCredentialResolver" />
                         <bean parent="shibboleth.StaticPKIXTrustEngine"
                               p:certificates="#{getObject('shibboleth.CASProxyTrustedCertificates') ?: getObject('shibboleth.DefaultCASProxyTrustedCertificates')}"
-                              p:checkNames="false" />
+                              p:checkNames="true" />
                     </list>
                 </constructor-arg>
             </bean>

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.