[java-identity-provider] 01/02: IDP-1361 Modify tests to exercise all SourceAttribute waring paths

Rod Widdowson rdw at steadingsoftware.com
Sat Dec 8 12:23:35 EST 2018


This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch master
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=17bb31430ce11e959d4cf3b3c3c3cf166b575bce

commit 17bb31430ce11e959d4cf3b3c3c3cf166b575bce
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Sat Dec 8 17:14:05 2018 +0000

    IDP-1361 Modify tests to exercise all SourceAttribute waring paths
    
    https://issues.shibboleth.net/jira/browse/IDP-1361
---
 .../idp/attribute/resolver/ad/impl/TemplateAttributeTest.java        | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/idp-attribute-resolver-impl/src/test/java/net/shibboleth/idp/attribute/resolver/ad/impl/TemplateAttributeTest.java b/idp-attribute-resolver-impl/src/test/java/net/shibboleth/idp/attribute/resolver/ad/impl/TemplateAttributeTest.java
index eb08d31..e5fea2d 100644
--- a/idp-attribute-resolver-impl/src/test/java/net/shibboleth/idp/attribute/resolver/ad/impl/TemplateAttributeTest.java
+++ b/idp-attribute-resolver-impl/src/test/java/net/shibboleth/idp/attribute/resolver/ad/impl/TemplateAttributeTest.java
@@ -18,7 +18,6 @@
 package net.shibboleth.idp.attribute.resolver.ad.impl;
 
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.List;
@@ -169,7 +168,7 @@ public class TemplateAttributeTest {
         attr = new TemplateAttributeDefinition();
         attr.setId(name);
         attr.setVelocityEngine(getEngine());
-        attr.setDependencies(Collections.singleton(TestSources.makeResolverPluginDependency("foo", "bar")));
+        attr.setDependencies(Collections.singleton(TestSources.makeResolverPluginDependency("foo", TestSources.DEPENDS_ON_ATTRIBUTE_NAME_ATTR)));
         try {
             attr.initialize();
             Assert.fail("No Text or attributes");
@@ -241,7 +240,7 @@ public class TemplateAttributeTest {
      * @throws ComponentInitializationException if it goes wrong.
      */
     @Test public void templateWithValuesTestSources() throws ResolutionException, ComponentInitializationException {
-        templateWithValues(false);
+        templateWithValues(true);
     }
 
     /** Worker function for the templateWithValues and templateWithValuesTestSources tests.

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list