[java-opensaml] branch master updated: IDP-1319 - Reduce redundant stack traces in log

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch master
in repository java-opensaml.

View the commit online:
http://git.shibboleth.net/view/?p=java-opensaml.git;a=commit;h=3628729ce93019391f5fddebef5f92e39134ba50

The following commit(s) were added to refs/heads/master by this push:
       new  3628729   IDP-1319 - Reduce redundant stack traces in log
3628729 is described below

commit 3628729ce93019391f5fddebef5f92e39134ba50
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Mon Aug 20 11:44:18 2018 -0400

    IDP-1319 - Reduce redundant stack traces in log
    
    https://issues.shibboleth.net/jira/browse/IDP-1319
---
 .../saml/metadata/resolver/impl/AbstractMetadataResolver.java      | 2 +-
 .../metadata/resolver/impl/AbstractReloadingMetadataResolver.java  | 7 ++++---
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/opensaml-saml-impl/src/main/java/org/opensaml/saml/metadata/resolver/impl/AbstractMetadataResolver.java b/opensaml-saml-impl/src/main/java/org/opensaml/saml/metadata/resolver/impl/AbstractMetadataResolver.java
index a1dd1bc..bab1dc6 100644
--- a/opensaml-saml-impl/src/main/java/org/opensaml/saml/metadata/resolver/impl/AbstractMetadataResolver.java
+++ b/opensaml-saml-impl/src/main/java/org/opensaml/saml/metadata/resolver/impl/AbstractMetadataResolver.java
@@ -288,7 +288,7 @@ public abstract class AbstractMetadataResolver extends AbstractIdentifiableIniti
         } catch (final ComponentInitializationException e) {
             if (failFastInitialization) {
                 log.error("{} Metadata provider failed to properly initialize, fail-fast=true, halting", 
-                        getLogPrefix(), e);
+                        getLogPrefix());
                 throw e;
             } else {
                 log.error("{} Metadata provider failed to properly initialize, fail-fast=false, "
diff --git a/opensaml-saml-impl/src/main/java/org/opensaml/saml/metadata/resolver/impl/AbstractReloadingMetadataResolver.java b/opensaml-saml-impl/src/main/java/org/opensaml/saml/metadata/resolver/impl/AbstractReloadingMetadataResolver.java
index 5d9beb8..bb4f5d3 100644
--- a/opensaml-saml-impl/src/main/java/org/opensaml/saml/metadata/resolver/impl/AbstractReloadingMetadataResolver.java
+++ b/opensaml-saml-impl/src/main/java/org/opensaml/saml/metadata/resolver/impl/AbstractReloadingMetadataResolver.java
@@ -93,7 +93,7 @@ public abstract class AbstractReloadingMetadataResolver extends AbstractBatchMet
     
     /** Impending expiration warning threshold for metadata refresh, in milliseconds. 
      * Default value: 0ms (disabled). */
-    @Duration @Positive private long expirationWarningThreshold = 0;
+    @Duration @Positive private long expirationWarningThreshold;
 
     /** Last time the metadata was updated. */
     private DateTime lastUpdate;
@@ -359,11 +359,12 @@ public abstract class AbstractReloadingMetadataResolver extends AbstractBatchMet
             }
         } catch (final Throwable t) {
             trackRefreshSuccess = false;
-            log.error("{} Error occurred while attempting to refresh metadata from '{}'", getLogPrefix(), mdId, t);
             nextRefresh = new DateTime(ISOChronology.getInstanceUTC()).plus(minRefreshDelay);
             if (t instanceof Exception) {
+                log.error("{} Error occurred while attempting to refresh metadata from '{}'", getLogPrefix(), mdId);
                 throw new ResolverException((Exception) t);
             } else {
+                log.error("{} Error occurred while attempting to refresh metadata from '{}'", getLogPrefix(), mdId, t);
                 throw new ResolverException(String.format("Saw an error of type '%s' with message '%s'", 
                         t.getClass().getName(), t.getMessage()));
             }
@@ -445,7 +446,7 @@ public abstract class AbstractReloadingMetadataResolver extends AbstractBatchMet
             return unmarshallMetadata(new ByteArrayInputStream(metadataBytes));
         } catch (final UnmarshallingException e) {
             final String errorMsg = "Unable to unmarshall metadata";
-            log.error("{} " + errorMsg, getLogPrefix(), e);
+            log.error("{} " + errorMsg, getLogPrefix());
             throw new ResolverException(errorMsg, e);
         }
     }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.