[cpp-sp] branch master updated: Remove unused map member.

Scott Cantor cantor.2 at osu.edu
Thu Apr 26 20:13:34 EDT 2018


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch master
in repository cpp-sp.

View the commit online:
http://git.shibboleth.net/view/?p=cpp-sp.git;a=commit;h=42c3e230072429d9c5035dbbd4f475b8a2df2c95

The following commit(s) were added to refs/heads/master by this push:
       new  42c3e23   Remove unused map member.
42c3e23 is described below

commit 42c3e230072429d9c5035dbbd4f475b8a2df2c95
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Thu Apr 26 20:13:29 2018 -0400

    Remove unused map member.
---
 shibsp/impl/XMLApplication.cpp | 4 +---
 shibsp/impl/XMLApplication.h   | 4 ----
 2 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/shibsp/impl/XMLApplication.cpp b/shibsp/impl/XMLApplication.cpp
index 5c08609..944f0fb 100644
--- a/shibsp/impl/XMLApplication.cpp
+++ b/shibsp/impl/XMLApplication.cpp
@@ -540,8 +540,7 @@ void XMLApplication::doHandlers(const ProtocolProvider* pp, const DOMElement* e,
                     continue;
                 }
                 handler.reset(conf.AssertionConsumerServiceManager.newPlugin(bindprop.c_str(), pair<const DOMElement*,const char*>(child, getId())));
-                // Map by binding and protocol (may be > 1 per protocol and binding)
-                m_acsBindingMap[handler->getXMLString("Binding").second].push_back(handler.get());
+                // Map by protocol.
                 const XMLCh* protfamily = handler->getProtocolFamily();
                 if (protfamily)
                     m_acsProtocolMap[protfamily].push_back(handler.get());
@@ -737,7 +736,6 @@ void XMLApplication::doSSO(const ProtocolProvider& pp, set<string>& protocols, D
                     m_handlers.push_back(handler);
 
                     // Setup maps and defaults.
-                    m_acsBindingMap[handler->getXMLString("Binding").second].push_back(handler.get());
                     const XMLCh* protfamily = handler->getProtocolFamily();
                     if (protfamily)
                         m_acsProtocolMap[protfamily].push_back(handler.get());
diff --git a/shibsp/impl/XMLApplication.h b/shibsp/impl/XMLApplication.h
index 62d150c..043f405 100644
--- a/shibsp/impl/XMLApplication.h
+++ b/shibsp/impl/XMLApplication.h
@@ -192,10 +192,6 @@ namespace shibsp {
         // pointer to default consumer service
         const Handler* m_acsDefault;
 
-        // maps binding strings to supporting consumer service(s)
-        typedef std::map< xmltooling::xstring, std::vector<const Handler*> > ACSBindingMap;
-        ACSBindingMap m_acsBindingMap;
-
         // maps protocol strings to supporting consumer service(s)
         typedef std::map< xmltooling::xstring, std::vector<const Handler*> > ACSProtocolMap;
         ACSProtocolMap m_acsProtocolMap;

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list