[cpp-sp] branch master updated: SSPCPP-792 - Artifact responses are invalid

Scott Cantor cantor.2 at osu.edu
Fri Apr 6 09:42:05 EDT 2018


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch master
in repository cpp-sp.

View the commit online:
http://git.shibboleth.net/view/?p=cpp-sp.git;a=commit;h=f2e806ba5600020a7aeefc93cf0763f194612277

The following commit(s) were added to refs/heads/master by this push:
       new  f2e806b   SSPCPP-792 - Artifact responses are invalid
f2e806b is described below

commit f2e806ba5600020a7aeefc93cf0763f194612277
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Fri Apr 6 09:41:52 2018 -0400

    SSPCPP-792 - Artifact responses are invalid
    
    https://issues.shibboleth.net/jira/browse/SSPCPP-792
---
 shibsp/handler/impl/SAML2ArtifactResolution.cpp | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/shibsp/handler/impl/SAML2ArtifactResolution.cpp b/shibsp/handler/impl/SAML2ArtifactResolution.cpp
index 0d3576d..acf7c08 100644
--- a/shibsp/handler/impl/SAML2ArtifactResolution.cpp
+++ b/shibsp/handler/impl/SAML2ArtifactResolution.cpp
@@ -315,9 +315,11 @@ pair<bool,long> SAML2ArtifactResolution::processMessage(const Application& appli
         auto_ptr<ArtifactResponse> resp(ArtifactResponseBuilder::buildArtifactResponse());
         resp->setInResponseTo(req->getID());
         Issuer* me = IssuerBuilder::buildIssuer();
+        resp->setIssuer(me);
         me->setName(application.getRelyingParty(entity)->getXMLString("entityID").second);
         resp->setPayload(payload.get());
         payload.release();
+        fillStatus(*resp, StatusCode::SUCCESS);
 
         long ret = sendMessage(
             *m_encoder, resp.get(), relayState.c_str(), nullptr, policy->getIssuerMetadata(), application, httpResponse, "conditional"
@@ -343,6 +345,7 @@ pair<bool,long> SAML2ArtifactResolution::emptyResponse(
     auto_ptr<ArtifactResponse> resp(ArtifactResponseBuilder::buildArtifactResponse());
     resp->setInResponseTo(request.getID());
     Issuer* me = IssuerBuilder::buildIssuer();
+    resp->setIssuer(me);
     me->setName(app.getRelyingParty(recipient)->getXMLString("entityID").second);
     fillStatus(*resp, StatusCode::SUCCESS);
     long ret = m_encoder->encode(httpResponse, resp.get(), nullptr);

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list