[java-identity-provider] branch master updated: IDP-1206 - Clarify javadoc.

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch master
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=d5cb77754b92d6b2898968b82bab79b1fbbfcfdf

The following commit(s) were added to refs/heads/master by this push:
       new  d5cb777   IDP-1206 - Clarify javadoc.
d5cb777 is described below

commit d5cb77754b92d6b2898968b82bab79b1fbbfcfdf
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Thu Apr 5 20:40:43 2018 -0400

    IDP-1206 - Clarify javadoc.
---
 .../net/shibboleth/idp/profile/logic/SimpleAttributePredicate.java   | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/idp-profile-api/src/main/java/net/shibboleth/idp/profile/logic/SimpleAttributePredicate.java b/idp-profile-api/src/main/java/net/shibboleth/idp/profile/logic/SimpleAttributePredicate.java
index 5edadd5..283521f 100644
--- a/idp-profile-api/src/main/java/net/shibboleth/idp/profile/logic/SimpleAttributePredicate.java
+++ b/idp-profile-api/src/main/java/net/shibboleth/idp/profile/logic/SimpleAttributePredicate.java
@@ -46,7 +46,8 @@ import com.google.common.collect.ListMultimap;
  * <p>This handles only simple string-valued data.</p>
  * 
  * <p>For the special case of checking for an attribute's presence, regardless of values, the '*' value is
- * supported.</p>
+ * supported. Note that this does NOT exclude pathological cases such as empty or null values. A more
+ * advanced predicate should be used to deal with such cases.</p>
  */
 public class SimpleAttributePredicate extends AbstractAttributePredicate {
 
@@ -76,11 +77,13 @@ public class SimpleAttributePredicate extends AbstractAttributePredicate {
         }
     }
 
+    /** {@inheritDoc} */
     @Override
     protected boolean allowNullAttributeContext() {
         return attributeValueMap.isEmpty();
     }
 
+    /** {@inheritDoc} */
     @Override
     protected boolean hasMatch(final Map<String, IdPAttribute> attributeMap) {
         for (final String id : attributeValueMap.keySet()) {

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.