[java-opensaml] 10/24: OSJ-173 - Audit Guava Collections transform and filter for problematic usage

[Brent Putman]

This is an automated email from the git hooks/post-receive script.

putmanb pushed a commit to branch maint-3.3
in repository java-opensaml.

View the commit online:
http://git.shibboleth.net/view/?p=java-opensaml.git;a=commit;h=bbf8725067f6be77fa7ee940144ebd84bcc73dd7

commit bbf8725067f6be77fa7ee940144ebd84bcc73dd7
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Fri Jan 13 22:18:54 2017 +0000

    OSJ-173 - Audit Guava Collections transform and filter for problematic usage
    
    https://issues.shibboleth.net/jira/browse/OSJ-173
---
 .../impl/client/PopulateClientStorageSaveContext.java   | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/opensaml-storage-impl/src/main/java/org/opensaml/storage/impl/client/PopulateClientStorageSaveContext.java b/opensaml-storage-impl/src/main/java/org/opensaml/storage/impl/client/PopulateClientStorageSaveContext.java
index f1eec1c..70406cf 100644
--- a/opensaml-storage-impl/src/main/java/org/opensaml/storage/impl/client/PopulateClientStorageSaveContext.java
+++ b/opensaml-storage-impl/src/main/java/org/opensaml/storage/impl/client/PopulateClientStorageSaveContext.java
@@ -115,14 +115,17 @@ public class PopulateClientStorageSaveContext<InboundMessageType, OutboundMessag
             log.debug("{} No ClientStorageServices require saving, nothing to do", getLogPrefix());
             ActionSupport.buildEvent(profileRequestContext, SAVE_NOT_NEEDED);
         } else {
-            final Collection<String> ids = Collections2.transform(saveCtx.getStorageOperations(),
-                    new Function<ClientStorageServiceOperation,String>() {
-                public String apply(ClientStorageServiceOperation input) {
-                    return input.getStorageServiceID();
-                }
-            });
-            log.debug("{} ClientStorageServices requiring save: {}", getLogPrefix(), ids);
             profileRequestContext.addSubcontext(saveCtx, true);
+            
+            if (log.isDebugEnabled()) {
+                final Collection<String> ids = Collections2.transform(saveCtx.getStorageOperations(),
+                        new Function<ClientStorageServiceOperation,String>() {
+                    public String apply(ClientStorageServiceOperation input) {
+                        return input.getStorageServiceID();
+                    }
+                });
+                log.debug("{} ClientStorageServices requiring save: {}", getLogPrefix(), ids);
+            }
         }
     }
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.