[java-identity-provider] 06/16: IDP-1165 Bark more loudly if the to-be-encoded type mismatches.

Scott Cantor cantor.2 at osu.edu
Tue Sep 26 12:41:16 EDT 2017


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch maint-3.3
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=7be56b224b274e21cf38b96e76343c59d42bdfb6

commit 7be56b224b274e21cf38b96e76343c59d42bdfb6
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Fri Apr 28 15:16:13 2017 +0100

    IDP-1165 Bark more loudly if the to-be-encoded type mismatches.
    
    https://issues.shibboleth.net/jira/browse/IDP-1165
    
    see also http://shibboleth.net/pipermail/users/2017-April/035555.html
---
 .../idp/saml/attribute/encoding/AbstractSAMLAttributeEncoder.java   | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/idp-saml-api/src/main/java/net/shibboleth/idp/saml/attribute/encoding/AbstractSAMLAttributeEncoder.java b/idp-saml-api/src/main/java/net/shibboleth/idp/saml/attribute/encoding/AbstractSAMLAttributeEncoder.java
index e821f98..ac1b4a4 100644
--- a/idp-saml-api/src/main/java/net/shibboleth/idp/saml/attribute/encoding/AbstractSAMLAttributeEncoder.java
+++ b/idp-saml-api/src/main/java/net/shibboleth/idp/saml/attribute/encoding/AbstractSAMLAttributeEncoder.java
@@ -25,8 +25,8 @@ import javax.annotation.Nullable;
 
 import net.shibboleth.idp.attribute.AttributeEncoder;
 import net.shibboleth.idp.attribute.AttributeEncodingException;
-import net.shibboleth.idp.attribute.IdPAttributeValue;
 import net.shibboleth.idp.attribute.IdPAttribute;
+import net.shibboleth.idp.attribute.IdPAttributeValue;
 import net.shibboleth.utilities.java.support.annotation.constraint.NonnullAfterInit;
 import net.shibboleth.utilities.java.support.annotation.constraint.NonnullElements;
 import net.shibboleth.utilities.java.support.annotation.constraint.NotEmpty;
@@ -170,8 +170,8 @@ public abstract class AbstractSAMLAttributeEncoder<AttributeType extends SAMLObj
             }
 
             if (!canEncodeValue(attribute, o)) {
-                log.debug("Skipping value of attribute {}; Type {} cannot be encoded by this encoder.", attributeId,
-                        o.getClass().getName());
+                log.warn("Skipping value of attribute '{}'; Type {} cannot be encoded by this encoder ({}).", attributeId,
+                        o.getClass().getName(), this.getClass().getName());
                 continue;
             }
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list