[java-identity-provider] 01/16: Add defensive warning if inbound flows are cleared.

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch maint-3.3
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=7e4ea9bba0c856f32dea23cf63d1e3a76b5b4160

commit 7e4ea9bba0c856f32dea23cf63d1e3a76b5b4160
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Wed Mar 15 16:07:56 2017 +0000

    Add defensive warning if inbound flows are cleared.
---
 .../config/AbstractSAMLProfileConfiguration.java        | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/idp-saml-api/src/main/java/net/shibboleth/idp/saml/profile/config/AbstractSAMLProfileConfiguration.java b/idp-saml-api/src/main/java/net/shibboleth/idp/saml/profile/config/AbstractSAMLProfileConfiguration.java
index 0c632a5..0320e17 100644
--- a/idp-saml-api/src/main/java/net/shibboleth/idp/saml/profile/config/AbstractSAMLProfileConfiguration.java
+++ b/idp-saml-api/src/main/java/net/shibboleth/idp/saml/profile/config/AbstractSAMLProfileConfiguration.java
@@ -20,6 +20,7 @@ package net.shibboleth.idp.saml.profile.config;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.HashSet;
+import java.util.List;
 import java.util.Set;
 
 import javax.annotation.Nonnull;
@@ -31,10 +32,12 @@ import net.shibboleth.utilities.java.support.annotation.constraint.NonnullElemen
 import net.shibboleth.utilities.java.support.annotation.constraint.NotEmpty;
 import net.shibboleth.utilities.java.support.annotation.constraint.NotLive;
 import net.shibboleth.utilities.java.support.annotation.constraint.Positive;
+import net.shibboleth.utilities.java.support.annotation.constraint.Unmodifiable;
 import net.shibboleth.utilities.java.support.logic.Constraint;
 import net.shibboleth.utilities.java.support.primitive.StringSupport;
 
 import org.opensaml.profile.context.ProfileRequestContext;
+import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 import com.google.common.base.Function;
@@ -46,6 +49,9 @@ import com.google.common.collect.ImmutableSet;
 public abstract class AbstractSAMLProfileConfiguration extends AbstractProfileConfiguration implements
         SAMLProfileConfiguration {
 
+    /** Class logger. */
+    @Nonnull private final Logger log = LoggerFactory.getLogger(AbstractSAMLProfileConfiguration.class);
+    
     /** Predicate used to determine if the generated request should be signed. Default returns false. */
     @Nonnull private Predicate<ProfileRequestContext> signRequestsPredicate;
 
@@ -87,6 +93,17 @@ public abstract class AbstractSAMLProfileConfiguration extends AbstractProfileCo
     }
 
     /** {@inheritDoc} */
+    @Override
+    @Nonnull @NonnullElements @NotLive @Unmodifiable public List<String> getInboundInterceptorFlows() {
+        
+        final List<String> flows = super.getInboundInterceptorFlows();
+        if (flows.isEmpty()) {
+            log.warn("Inbound interceptor collection is empty, this disables default inbound message security checks");
+        }
+        return flows;
+    }
+    
+    /** {@inheritDoc} */
     @Override @Nonnull public Predicate<ProfileRequestContext> getSignAssertions() {
         return signAssertionsPredicate;
     }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.