[cpp-opensaml] branch master updated: SSPCPP-756 Fix self deadlock

[Rod Widdowson]

This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch master
in repository cpp-opensaml.

View the commit online:
http://git.shibboleth.net/view/?p=cpp-opensaml.git;a=commit;h=1296a4e7e7399286e916a697c08dbea5bbc15151

The following commit(s) were added to refs/heads/master by this push:
       new  1296a4e   SSPCPP-756 Fix self deadlock
1296a4e is described below

commit 1296a4e7e7399286e916a697c08dbea5bbc15151
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Thu Nov 9 16:29:02 2017 +0000

    SSPCPP-756 Fix self deadlock
    
    https://issues.shibboleth.net/jira/browse/SSPCPP-756
    
    When using a Locker to guarda lock and doing the locking oneself,
    it helps to use the correct constructor.
---
 saml/saml2/metadata/impl/AbstractDynamicMetadataProvider.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/saml/saml2/metadata/impl/AbstractDynamicMetadataProvider.cpp b/saml/saml2/metadata/impl/AbstractDynamicMetadataProvider.cpp
index 7fe90df..9c4aafa 100644
--- a/saml/saml2/metadata/impl/AbstractDynamicMetadataProvider.cpp
+++ b/saml/saml2/metadata/impl/AbstractDynamicMetadataProvider.cpp
@@ -367,7 +367,7 @@ time_t  AbstractDynamicMetadataProvider::cacheEntity(EntityDescriptor* entity, b
     if (!writeLocked) {
         m_lock->wrlock();
     }
-    Locker locker(writeLocked ? nullptr : const_cast<AbstractDynamicMetadataProvider*>(this));
+    Locker locker(writeLocked ? nullptr : const_cast<AbstractDynamicMetadataProvider*>(this), false);
 
     // Compute the smaller of the validUntil / cacheDuration constraints.
     time_t cacheExp = (entity->getValidUntil() ? entity->getValidUntilEpoch() : SAMLTIME_MAX) - now;

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.