[java-identity-provider] branch master updated: Add a defensive check against an empty NameID.

Scott Cantor cantor.2 at osu.edu
Tue May 2 10:44:40 EDT 2017


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch master
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=96a3a4503b5453d333694a64fb72fceece73fde7

The following commit(s) were added to refs/heads/master by this push:
       new  96a3a45   Add a defensive check against an empty NameID.
96a3a45 is described below

commit 96a3a4503b5453d333694a64fb72fceece73fde7
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Tue May 2 10:44:38 2017 -0400

    Add a defensive check against an empty NameID.
---
 .../shibboleth/idp/saml/saml2/profile/impl/ProcessLogoutRequest.java  | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/saml2/profile/impl/ProcessLogoutRequest.java b/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/saml2/profile/impl/ProcessLogoutRequest.java
index 2c957e6..b4318f0 100644
--- a/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/saml2/profile/impl/ProcessLogoutRequest.java
+++ b/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/saml2/profile/impl/ProcessLogoutRequest.java
@@ -244,6 +244,10 @@ public class ProcessLogoutRequest extends AbstractProfileAction {
             log.warn("{} LogoutRequest did not contain NameID", getLogPrefix());
             ActionSupport.buildEvent(profileRequestContext, EventIds.INVALID_MESSAGE);
             return false;
+        } else if (logoutRequest.getNameID().getValue() == null) {
+            log.warn("{} LogoutRequest contained an empty (therefore invalid) NameID", getLogPrefix());
+            ActionSupport.buildEvent(profileRequestContext, EventIds.INVALID_MESSAGE);
+            return false;
         }
         
         if (log.isDebugEnabled() && logoutRequest.getExtensions() != null

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list