[java-identity-provider COMMIT] in /branches/3.3: ./ idp-saml-api/src/main/java/net/shibboleth/idp/saml/profile/confi...

[noreply at shibboleth.net]

Author: scantor
Date: Mon Mar  6 21:48:45 2017
New Revision: 8657

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=8657&view=rev
Log:
BPr8574 - Correct sense of signRequests field variable and documentation.

Modified:
    branches/3.3/   (props changed)
    branches/3.3/idp-saml-api/src/main/java/net/shibboleth/idp/saml/profile/config/AbstractSAMLProfileConfiguration.java

Modified: branches/3.3/idp-saml-api/src/main/java/net/shibboleth/idp/saml/profile/config/AbstractSAMLProfileConfiguration.java
URL: http://svn.shibboleth.net/view/java-identity-provider/branches/3.3/idp-saml-api/src/main/java/net/shibboleth/idp/saml/profile/config/AbstractSAMLProfileConfiguration.java?rev=8657&r1=8656&r2=8657&view=diff
==============================================================================
--- branches/3.3/idp-saml-api/src/main/java/net/shibboleth/idp/saml/profile/config/AbstractSAMLProfileConfiguration.java	(original)
+++ branches/3.3/idp-saml-api/src/main/java/net/shibboleth/idp/saml/profile/config/AbstractSAMLProfileConfiguration.java	Mon Mar  6 21:48:45 2017
@@ -46,8 +46,8 @@
 public abstract class AbstractSAMLProfileConfiguration extends AbstractProfileConfiguration implements
         SAMLProfileConfiguration {
 
-    /** Predicate used to determine if the received request should be signed. Default returns false. */
-    @Nonnull private Predicate<ProfileRequestContext> signedRequestsPredicate;
+    /** Predicate used to determine if the generated request should be signed. Default returns false. */
+    @Nonnull private Predicate<ProfileRequestContext> signRequestsPredicate;
 
     /** Predicate used to determine if the generated response should be signed. Default returns true. */
     @Nonnull private Predicate<ProfileRequestContext> signResponsesPredicate;
@@ -78,7 +78,7 @@
     public AbstractSAMLProfileConfiguration(@Nonnull @NotEmpty final String profileId) {
         super(profileId);
 
-        signedRequestsPredicate = Predicates.alwaysFalse();
+        signRequestsPredicate = Predicates.alwaysFalse();
         signResponsesPredicate = Predicates.alwaysFalse();
         signAssertionsPredicate = Predicates.alwaysFalse();
         includeNotBeforePredicate = Predicates.alwaysTrue();
@@ -103,7 +103,7 @@
 
     /** {@inheritDoc} */
     @Override @Nonnull public Predicate<ProfileRequestContext> getSignRequests() {
-        return signedRequestsPredicate;
+        return signRequestsPredicate;
     }
 
     /**
@@ -112,9 +112,9 @@
      * @param predicate predicate used to determine if generated requests should be signed
      */
     public void setSignRequests(@Nonnull final Predicate<ProfileRequestContext> predicate) {
-        signedRequestsPredicate =
+        signRequestsPredicate =
                 Constraint.isNotNull(predicate,
-                        "Predicate to determine if received requests should be signed cannot be null");
+                        "Predicate to determine if requests should be signed cannot be null");
     }
 
     /** {@inheritDoc} */