[java-identity-provider COMMIT] /trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/attribute/resolver/impl/Co...

[noreply at shibboleth.net]

Author: rdw
Date: Mon Mar  6 10:07:14 2017
New Revision: 8648

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=8648&view=rev
Log:
IDP-1138 Suppress logging of salt at all but TRACE

https://issues.shibboleth.net/jira/browse/IDP-1138

Modified:
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/attribute/resolver/impl/ComputedIDDataConnector.java

Modified: trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/attribute/resolver/impl/ComputedIDDataConnector.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/attribute/resolver/impl/ComputedIDDataConnector.java?rev=8648&r1=8647&r2=8648&view=diff
==============================================================================
--- trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/attribute/resolver/impl/ComputedIDDataConnector.java	(original)
+++ trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/attribute/resolver/impl/ComputedIDDataConnector.java	Mon Mar  6 10:07:14 2017
@@ -93,7 +93,8 @@
         ComponentSupport.ifInitializedThrowUnmodifiabledComponentException(this);
         
         if (null != salt) {
-            log.debug("{} Salt set as bytes to {}", getLogPrefix(), Arrays.toString(salt));
+            log.debug("{} Salt set (secret is logged a TRACE)");
+            log.trace("{} Salt set as bytes to {}", getLogPrefix(), Arrays.toString(salt));
             idStrategy.setSalt(salt);
         } else {
             log.debug("{} Null salt passed, nothing set", getLogPrefix());
@@ -109,8 +110,7 @@
         ComponentSupport.ifInitializedThrowUnmodifiabledComponentException(this);
         
         if (null != salt) {
-            log.debug("{} Salt set as bytes to {}", getLogPrefix(), Arrays.toString(salt.getBytes()));
-            idStrategy.setSalt(salt.getBytes());
+            setSalt(salt.getBytes());
         } else {
             log.debug("{} Null salt passed, nothing set", getLogPrefix());
         }