[java-identity-provider] branch master updated: IDP-1177 - Centralize deprecation warnings through dedicated function
Scott Cantor
cantor.2 at osu.edu
Sat Jun 3 16:51:25 EDT 2017
This is an automated email from the git hooks/post-receive script.
scantor pushed a commit to branch master
in repository java-identity-provider.
View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=56717476a42c2bf96e0b08dbde1902598765d991
The following commit(s) were added to refs/heads/master by this push:
new 5671747 IDP-1177 - Centralize deprecation warnings through dedicated function
5671747 is described below
commit 56717476a42c2bf96e0b08dbde1902598765d991
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Sat Jun 3 16:51:23 2017 -0400
IDP-1177 - Centralize deprecation warnings through dedicated function
https://issues.shibboleth.net/jira/browse/IDP-1177
Add warnings to deprecated classes.
---
.../encoding/AbstractSAML1NameIdentifierEncoder.java | 11 +++++++++++
.../saml/attribute/encoding/AbstractSAML2NameIDEncoder.java | 11 +++++++++++
.../resolver/impl/TransientIdAttributeDefinition.java | 4 ++++
3 files changed, 26 insertions(+)
diff --git a/idp-saml-api/src/main/java/net/shibboleth/idp/saml/attribute/encoding/AbstractSAML1NameIdentifierEncoder.java b/idp-saml-api/src/main/java/net/shibboleth/idp/saml/attribute/encoding/AbstractSAML1NameIdentifierEncoder.java
index 148c3b5..fb24963 100644
--- a/idp-saml-api/src/main/java/net/shibboleth/idp/saml/attribute/encoding/AbstractSAML1NameIdentifierEncoder.java
+++ b/idp-saml-api/src/main/java/net/shibboleth/idp/saml/attribute/encoding/AbstractSAML1NameIdentifierEncoder.java
@@ -21,8 +21,11 @@ import javax.annotation.Nonnull;
import net.shibboleth.idp.saml.nameid.SAML1NameIdentifierAttributeEncoder;
import net.shibboleth.utilities.java.support.component.AbstractInitializableComponent;
+import net.shibboleth.utilities.java.support.component.ComponentInitializationException;
import net.shibboleth.utilities.java.support.component.ComponentSupport;
import net.shibboleth.utilities.java.support.logic.Constraint;
+import net.shibboleth.utilities.java.support.primitive.DeprecationSupport;
+import net.shibboleth.utilities.java.support.primitive.DeprecationSupport.ObjectType;
import org.opensaml.profile.context.ProfileRequestContext;
import org.opensaml.saml.common.xml.SAMLConstants;
@@ -68,5 +71,13 @@ public abstract class AbstractSAML1NameIdentifierEncoder extends AbstractInitial
@Nonnull public final String getProtocol() {
return SAMLConstants.SAML11P_NS;
}
+
+ /** {@inheritDoc} */
+ @Override
+ protected void doInitialize() throws ComponentInitializationException {
+ super.doInitialize();
+
+ DeprecationSupport.warn(ObjectType.CLASS, getClass().getName(), null, "via NameID Generation configuration");
+ }
}
\ No newline at end of file
diff --git a/idp-saml-api/src/main/java/net/shibboleth/idp/saml/attribute/encoding/AbstractSAML2NameIDEncoder.java b/idp-saml-api/src/main/java/net/shibboleth/idp/saml/attribute/encoding/AbstractSAML2NameIDEncoder.java
index b63b586..1b99f2a 100644
--- a/idp-saml-api/src/main/java/net/shibboleth/idp/saml/attribute/encoding/AbstractSAML2NameIDEncoder.java
+++ b/idp-saml-api/src/main/java/net/shibboleth/idp/saml/attribute/encoding/AbstractSAML2NameIDEncoder.java
@@ -21,8 +21,11 @@ import javax.annotation.Nonnull;
import net.shibboleth.idp.saml.nameid.SAML2NameIDAttributeEncoder;
import net.shibboleth.utilities.java.support.component.AbstractInitializableComponent;
+import net.shibboleth.utilities.java.support.component.ComponentInitializationException;
import net.shibboleth.utilities.java.support.component.ComponentSupport;
import net.shibboleth.utilities.java.support.logic.Constraint;
+import net.shibboleth.utilities.java.support.primitive.DeprecationSupport;
+import net.shibboleth.utilities.java.support.primitive.DeprecationSupport.ObjectType;
import org.opensaml.profile.context.ProfileRequestContext;
import org.opensaml.saml.common.xml.SAMLConstants;
@@ -69,4 +72,12 @@ public abstract class AbstractSAML2NameIDEncoder extends AbstractInitializableCo
return SAMLConstants.SAML20P_NS;
}
+ /** {@inheritDoc} */
+ @Override
+ protected void doInitialize() throws ComponentInitializationException {
+ super.doInitialize();
+
+ DeprecationSupport.warn(ObjectType.CLASS, getClass().getName(), null, "via NameID Generation configuration");
+ }
+
}
\ No newline at end of file
diff --git a/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/attribute/resolver/impl/TransientIdAttributeDefinition.java b/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/attribute/resolver/impl/TransientIdAttributeDefinition.java
index f5d7130..b463953 100644
--- a/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/attribute/resolver/impl/TransientIdAttributeDefinition.java
+++ b/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/attribute/resolver/impl/TransientIdAttributeDefinition.java
@@ -32,6 +32,8 @@ import net.shibboleth.utilities.java.support.annotation.constraint.NotEmpty;
import net.shibboleth.utilities.java.support.component.ComponentInitializationException;
import net.shibboleth.utilities.java.support.component.ComponentSupport;
import net.shibboleth.utilities.java.support.logic.Constraint;
+import net.shibboleth.utilities.java.support.primitive.DeprecationSupport;
+import net.shibboleth.utilities.java.support.primitive.DeprecationSupport.ObjectType;
import org.opensaml.saml.common.SAMLException;
import org.slf4j.Logger;
@@ -63,6 +65,8 @@ public class TransientIdAttributeDefinition extends AbstractAttributeDefinition
if (null == idGenerator) {
throw new ComponentInitializationException("Id generator must be non null");
}
+
+ DeprecationSupport.warn(ObjectType.CLASS, getClass().getName(), null, "via NameID Generation configuration");
}
/** Set the id generator being used.
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
More information about the commits
mailing list