[java-identity-provider COMMIT] in /trunk/idp-profile-spring/src: main/java/net/shibboleth/idp/profile/spring/relying...

[noreply at shibboleth.net]

Author: scantor
Date: Wed Jan 25 13:49:57 2017
New Revision: 8605

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=8605&view=rev
Log:
IDP-688 - Fix bug with deprecated property setter.

https://issues.shibboleth.net/jira/browse/IDP-688


Added:
    trunk/idp-profile-spring/src/test/resources/net/shibboleth/idp/profile/spring/relyingparty/metadata/dynamicDeprecated.xml
Modified:
    trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/impl/AbstractDynamicHTTPMetadataProviderParser.java
    trunk/idp-profile-spring/src/test/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/DynamicHTTPMetadataProviderParserTest.java
    trunk/idp-profile-spring/src/test/resources/net/shibboleth/idp/profile/spring/relyingparty/metadata/beans.xml

Modified: trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/impl/AbstractDynamicHTTPMetadataProviderParser.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/impl/AbstractDynamicHTTPMetadataProviderParser.java?rev=8605&r1=8604&r2=8605&view=diff
==============================================================================
--- trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/impl/AbstractDynamicHTTPMetadataProviderParser.java	(original)
+++ trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/impl/AbstractDynamicHTTPMetadataProviderParser.java	Wed Jan 25 13:49:57 2017
@@ -125,7 +125,7 @@
         }
 
         if (element.hasAttributeNS(null, "credentialsProviderRef")) {
-            builder.addPropertyReference("credentialsProviderRef",
+            builder.addPropertyReference("credentialsProvider",
                     StringSupport.trimOrNull(element.getAttributeNS(null, "credentialsProviderRef")));
             if (element.hasAttributeNS(null, BASIC_AUTH_USER) || element.hasAttributeNS(null, BASIC_AUTH_PASSWORD)) {
                 log.warn("credentialsProviderRef overrides settings for basicAuthUser and basicAuthPassword");

Modified: trunk/idp-profile-spring/src/test/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/DynamicHTTPMetadataProviderParserTest.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-profile-spring/src/test/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/DynamicHTTPMetadataProviderParserTest.java?rev=8605&r1=8604&r2=8605&view=diff
==============================================================================
--- trunk/idp-profile-spring/src/test/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/DynamicHTTPMetadataProviderParserTest.java	(original)
+++ trunk/idp-profile-spring/src/test/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/DynamicHTTPMetadataProviderParserTest.java	Wed Jan 25 13:49:57 2017
@@ -76,7 +76,15 @@
         
         Assert.assertEquals(resolver.getRequestURLBuilder().getClass(), HTTPEntityIDRequestURLBuilder.class);
     }
-    
+
+    @Test
+    public void testDeprecated() throws Exception {
+        getBean(FunctionDrivenDynamicHTTPMetadataResolver.class, 
+                "dynamicDeprecated.xml", "beans.xml", "httpClient.xml");
+        
+        // We can't really test the actual values, this is just to test that parser, factory bean, etc are ok.
+    }
+
     @Test
     public void testClientSecurityParamsParams() throws Exception {
         getBean(FunctionDrivenDynamicHTTPMetadataResolver.class, 

Modified: trunk/idp-profile-spring/src/test/resources/net/shibboleth/idp/profile/spring/relyingparty/metadata/beans.xml
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-profile-spring/src/test/resources/net/shibboleth/idp/profile/spring/relyingparty/metadata/beans.xml?rev=8605&r1=8604&r2=8605&view=diff
==============================================================================
--- trunk/idp-profile-spring/src/test/resources/net/shibboleth/idp/profile/spring/relyingparty/metadata/beans.xml	(original)
+++ trunk/idp-profile-spring/src/test/resources/net/shibboleth/idp/profile/spring/relyingparty/metadata/beans.xml	Wed Jan 25 13:49:57 2017
@@ -72,6 +72,8 @@
     <bean id="metadata.persistentCacheManager" class="org.opensaml.core.xml.persist.MapLoadSaveManager" />
     
     <bean id="metadata.HttpClientSecurityParameters" class="org.opensaml.security.httpclient.HttpClientSecurityParameters" />
+    
+    <bean id="metadata.CredentialsProvider" class="org.apache.http.impl.client.SystemDefaultCredentialsProvider" />
             
     <util:set id="metadata.Indexes">
         <bean class="org.opensaml.saml.metadata.resolver.index.impl.RoleMetadataIndex" />