[cpp-sp] branch master updated: SSPCPP-705 Test against misconfigured AttributeChecker Handler

[Rod Widdowson]

This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch master
in repository cpp-sp.

View the commit online:
http://git.shibboleth.net/view/?p=cpp-sp.git;a=commit;h=81375040470235400dffcc0f5136e8cbb58ce785

The following commit(s) were added to refs/heads/master by this push:
       new  8137504   SSPCPP-705 Test against misconfigured AttributeChecker Handler
8137504 is described below

commit 81375040470235400dffcc0f5136e8cbb58ce785
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Sat Feb 25 14:14:02 2017 +0000

    SSPCPP-705 Test against misconfigured AttributeChecker Handler
    
    https://issues.shibboleth.net/jira/browse/SSPCPP-705
---
 shibsp/handler/impl/AttributeCheckerHandler.cpp | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/shibsp/handler/impl/AttributeCheckerHandler.cpp b/shibsp/handler/impl/AttributeCheckerHandler.cpp
index d4b86a9..a46194e 100644
--- a/shibsp/handler/impl/AttributeCheckerHandler.cpp
+++ b/shibsp/handler/impl/AttributeCheckerHandler.cpp
@@ -128,6 +128,9 @@ AttributeCheckerHandler::AttributeCheckerHandler(const DOMElement* e, const char
         if (m_attributes.empty())
             throw ConfigurationException("AttributeChecker unable to parse attributes setting.");
     }
+    else if (nullptr == XMLHelper::getFirstChildElement(e)) {
+        throw ConfigurationException("AttributeChecker requires either the attributes setting or an ACL");
+    }
     else {
         m_acl.reset(SPConfig::getConfig().AccessControlManager.newPlugin(XML_ACCESS_CONTROL, e));
     }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.