[java-identity-provider] branch master updated: IDP-1207 - donotcache ignored on forceauthn

Scott Cantor cantor.2 at osu.edu
Tue Aug 29 11:33:54 EDT 2017


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch master
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=f716a2102db922e65a09d24d8584a060df3f0342

The following commit(s) were added to refs/heads/master by this push:
       new  f716a21   IDP-1207 - donotcache ignored on forceauthn
f716a21 is described below

commit f716a2102db922e65a09d24d8584a060df3f0342
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Tue Aug 29 11:33:53 2017 -0400

    IDP-1207 - donotcache ignored on forceauthn
    
    https://issues.shibboleth.net/jira/browse/IDP-1207
    
    Switch to a more sensible default conditonal, suppress
    checkbox if a matching result is already cached.
---
 idp-conf/src/main/resources/views/login.vm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/idp-conf/src/main/resources/views/login.vm b/idp-conf/src/main/resources/views/login.vm
index 47c8f89..4ebf9bf 100644
--- a/idp-conf/src/main/resources/views/login.vm
+++ b/idp-conf/src/main/resources/views/login.vm
@@ -20,7 +20,6 @@
 ## custom - arbitrary object injected by deployer
 ##
 #set ($rpContext = $profileRequestContext.getSubcontext('net.shibboleth.idp.profile.context.RelyingPartyContext'))
-#set ($sessionContext = $profileRequestContext.getSubcontext('net.shibboleth.idp.session.context.SessionContext'))
 #set ($username = $authenticationContext.getSubcontext('net.shibboleth.idp.authn.context.UsernamePasswordContext', true).getUsername())
 #set ($passwordEnabled = false)
 #if (!$passwordPrincipals or $passwordPrincipals.isEmpty() or $authenticationContext.isAcceptable($passwordPrincipals))
@@ -67,12 +66,14 @@
                 <input class="form-element form-field" id="password" name="j_password" type="password" value="">
               </div>
 
-              #if (!$sessionContext || !$sessionContext.getIdPSession())
+              ## You may need to modify this to taste, such as changing the flow name its checking for to authn/MFA.
+              #if (!$authenticationContext.getActiveResults().containsKey('authn/Password'))
               <div class="form-element-wrapper">
                 <input type="checkbox" name="donotcache" value="1" id="donotcache">
                 <label for="donotcache">#springMessageText("idp.login.donotcache", "Don't Remember Login")</label>
                </div>
               #end
+              
             #end
 
               <div class="form-element-wrapper">

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list