[java-opensaml] 08/12: JPAR-85 - Checkstyle, check final variables

Tom Zeller tzeller at dragonacea.biz
Thu Aug 10 18:25:57 EDT 2017


This is an automated email from the git hooks/post-receive script.

tzeller pushed a commit to branch master
in repository java-opensaml.

View the commit online:
http://git.shibboleth.net/view/?p=java-opensaml.git;a=commit;h=92d7ec0f9f313fe7b1b1d2754ebce63e9b2c9de9

commit 92d7ec0f9f313fe7b1b1d2754ebce63e9b2c9de9
Author: Tom Zeller <tzeller at dragonacea.biz>
AuthorDate: Thu Aug 10 16:53:54 2017 -0500

    JPAR-85 - Checkstyle, check final variables
---
 .../opensaml/xacml/profile/saml/impl/ReferencedPoliciesTypeImpl.java  | 2 +-
 .../xacml/profile/saml/impl/ReferencedPoliciesTypeUnmarshaller.java   | 2 +-
 .../xacml/profile/saml/impl/XACMLAuthzDecisionQueryTypeImpl.java      | 2 +-
 .../profile/saml/impl/XACMLAuthzDecisionQueryTypeMarshaller.java      | 2 +-
 .../profile/saml/impl/XACMLAuthzDecisionQueryTypeUnmarshaller.java    | 4 ++--
 .../xacml/profile/saml/impl/XACMLAuthzDecisionStatementTypeImpl.java  | 2 +-
 .../saml/impl/XACMLAuthzDecisionStatementTypeUnmarshaller.java        | 3 ++-
 .../opensaml/xacml/profile/saml/impl/XACMLPolicyQueryTypeImpl.java    | 2 +-
 .../xacml/profile/saml/impl/XACMLPolicyQueryTypeUnmarshaller.java     | 2 +-
 .../xacml/profile/saml/impl/XACMLPolicyStatementTypeImpl.java         | 2 +-
 .../xacml/profile/saml/impl/XACMLPolicyStatementTypeUnmarshaller.java | 2 +-
 11 files changed, 13 insertions(+), 12 deletions(-)

diff --git a/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/ReferencedPoliciesTypeImpl.java b/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/ReferencedPoliciesTypeImpl.java
index 3418b8c..0b9b698 100644
--- a/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/ReferencedPoliciesTypeImpl.java
+++ b/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/ReferencedPoliciesTypeImpl.java
@@ -65,7 +65,7 @@ public class ReferencedPoliciesTypeImpl extends AbstractSAMLObject implements Re
 
     /** {@inheritDoc} */
     public List<XMLObject> getOrderedChildren() {
-        ArrayList<XMLObject> children = new ArrayList<>();
+        final ArrayList<XMLObject> children = new ArrayList<>();
         
         if(!policies.isEmpty()) {
             children.addAll(policies);
diff --git a/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/ReferencedPoliciesTypeUnmarshaller.java b/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/ReferencedPoliciesTypeUnmarshaller.java
index 8f7b734..ab81249 100644
--- a/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/ReferencedPoliciesTypeUnmarshaller.java
+++ b/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/ReferencedPoliciesTypeUnmarshaller.java
@@ -32,7 +32,7 @@ public class ReferencedPoliciesTypeUnmarshaller extends AbstractSAMLObjectUnmars
     /** {@inheritDoc} */
     protected void processChildElement(final XMLObject parentObject, final XMLObject childObject)
             throws UnmarshallingException {
-        ReferencedPoliciesType referencedpoliciesType = (ReferencedPoliciesType) parentObject;
+        final ReferencedPoliciesType referencedpoliciesType = (ReferencedPoliciesType) parentObject;
 
         if (childObject instanceof PolicyType) {
             referencedpoliciesType.getPolicies().add((PolicyType) childObject);
diff --git a/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLAuthzDecisionQueryTypeImpl.java b/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLAuthzDecisionQueryTypeImpl.java
index a6b4740..eb2f59f 100644
--- a/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLAuthzDecisionQueryTypeImpl.java
+++ b/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLAuthzDecisionQueryTypeImpl.java
@@ -82,7 +82,7 @@ public class XACMLAuthzDecisionQueryTypeImpl extends RequestAbstractTypeImpl imp
 
     /** {@inheritDoc} */
     public List<XMLObject> getOrderedChildren() {
-        ArrayList<XMLObject> children = new ArrayList<>();
+        final ArrayList<XMLObject> children = new ArrayList<>();
 
         if (super.getOrderedChildren() != null) {
             children.addAll(super.getOrderedChildren());
diff --git a/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLAuthzDecisionQueryTypeMarshaller.java b/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLAuthzDecisionQueryTypeMarshaller.java
index a630c2e..70d3f44 100644
--- a/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLAuthzDecisionQueryTypeMarshaller.java
+++ b/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLAuthzDecisionQueryTypeMarshaller.java
@@ -31,7 +31,7 @@ public class XACMLAuthzDecisionQueryTypeMarshaller extends RequestAbstractTypeMa
     /** {@inheritDoc} */
     protected void marshallAttributes(final XMLObject samlObject, final Element domElement)
             throws MarshallingException {
-        XACMLAuthzDecisionQueryType query = (XACMLAuthzDecisionQueryType) samlObject;
+        final XACMLAuthzDecisionQueryType query = (XACMLAuthzDecisionQueryType) samlObject;
 
         if (query.getInputContextOnlyXSBooleanValue() != null) {
             domElement.setAttributeNS(null, XACMLAuthzDecisionQueryType.INPUTCONTEXTONLY_ATTRIB_NAME, query
diff --git a/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLAuthzDecisionQueryTypeUnmarshaller.java b/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLAuthzDecisionQueryTypeUnmarshaller.java
index 14e6785..f9ca93a 100644
--- a/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLAuthzDecisionQueryTypeUnmarshaller.java
+++ b/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLAuthzDecisionQueryTypeUnmarshaller.java
@@ -36,7 +36,7 @@ public class XACMLAuthzDecisionQueryTypeUnmarshaller extends RequestAbstractType
     /** {@inheritDoc} */
     protected void processChildElement(final XMLObject parentObject, final XMLObject childObject)
             throws UnmarshallingException {
-        XACMLAuthzDecisionQueryType xacmlauthzdecisionquery = (XACMLAuthzDecisionQueryType) parentObject;
+        final XACMLAuthzDecisionQueryType xacmlauthzdecisionquery = (XACMLAuthzDecisionQueryType) parentObject;
 
         if (childObject instanceof RequestType) {
             xacmlauthzdecisionquery.setRequest((RequestType) childObject);
@@ -53,7 +53,7 @@ public class XACMLAuthzDecisionQueryTypeUnmarshaller extends RequestAbstractType
 
     /** {@inheritDoc} */
     protected void processAttribute(final XMLObject samlObject, final Attr attribute) throws UnmarshallingException {
-        XACMLAuthzDecisionQueryType authzDS = (XACMLAuthzDecisionQueryType) samlObject;
+        final XACMLAuthzDecisionQueryType authzDS = (XACMLAuthzDecisionQueryType) samlObject;
 
         if (attribute.getLocalName().equals(XACMLAuthzDecisionQueryType.INPUTCONTEXTONLY_ATTRIB_NAME)) {
             authzDS.setInputContextOnly(XSBooleanValue.valueOf(attribute.getValue()));
diff --git a/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLAuthzDecisionStatementTypeImpl.java b/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLAuthzDecisionStatementTypeImpl.java
index a244f48..42b83ed 100644
--- a/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLAuthzDecisionStatementTypeImpl.java
+++ b/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLAuthzDecisionStatementTypeImpl.java
@@ -70,7 +70,7 @@ public class XACMLAuthzDecisionStatementTypeImpl extends AbstractSAMLObject impl
 
     /** {@inheritDoc} */
     public List<XMLObject> getOrderedChildren() {
-        ArrayList<XMLObject> children = new ArrayList<>();
+        final ArrayList<XMLObject> children = new ArrayList<>();
 
         if (request != null) {
             children.add(request);
diff --git a/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLAuthzDecisionStatementTypeUnmarshaller.java b/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLAuthzDecisionStatementTypeUnmarshaller.java
index 1627e86..61cc649 100644
--- a/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLAuthzDecisionStatementTypeUnmarshaller.java
+++ b/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLAuthzDecisionStatementTypeUnmarshaller.java
@@ -32,7 +32,8 @@ public class XACMLAuthzDecisionStatementTypeUnmarshaller extends AbstractSAMLObj
     /** {@inheritDoc} */
     protected void processChildElement(final XMLObject parentObject, final XMLObject childObject)
             throws UnmarshallingException {
-        XACMLAuthzDecisionStatementType xacmlauthzdecisionstatement = (XACMLAuthzDecisionStatementType) parentObject;
+        final XACMLAuthzDecisionStatementType xacmlauthzdecisionstatement =
+                (XACMLAuthzDecisionStatementType) parentObject;
 
         if (childObject instanceof RequestType) {
             xacmlauthzdecisionstatement.setRequest((RequestType) childObject);
diff --git a/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLPolicyQueryTypeImpl.java b/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLPolicyQueryTypeImpl.java
index 06a0a37..da4ac3f 100644
--- a/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLPolicyQueryTypeImpl.java
+++ b/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLPolicyQueryTypeImpl.java
@@ -67,7 +67,7 @@ public class XACMLPolicyQueryTypeImpl extends RequestAbstractTypeImpl implements
     /** {@inheritDoc} */
     public List<XMLObject> getOrderedChildren() {
                     
-        ArrayList<XMLObject> children = new ArrayList<>();
+        final ArrayList<XMLObject> children = new ArrayList<>();
         
         if(super.getOrderedChildren() != null){
             children.addAll(super.getOrderedChildren());
diff --git a/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLPolicyQueryTypeUnmarshaller.java b/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLPolicyQueryTypeUnmarshaller.java
index 939f070..13dd6aa 100644
--- a/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLPolicyQueryTypeUnmarshaller.java
+++ b/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLPolicyQueryTypeUnmarshaller.java
@@ -30,7 +30,7 @@ public class XACMLPolicyQueryTypeUnmarshaller extends RequestAbstractTypeUnmarsh
     /** {@inheritDoc} */
     protected void processChildElement(final XMLObject parentObject, final XMLObject childObject)
             throws UnmarshallingException {
-        XACMLPolicyQueryType xacmlpolicyquery = (XACMLPolicyQueryType) parentObject;
+        final XACMLPolicyQueryType xacmlpolicyquery = (XACMLPolicyQueryType) parentObject;
 
         if (childObject instanceof RequestType) {
             xacmlpolicyquery.getRequests().add((RequestType) childObject);
diff --git a/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLPolicyStatementTypeImpl.java b/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLPolicyStatementTypeImpl.java
index ac08cf6..2c682f4 100644
--- a/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLPolicyStatementTypeImpl.java
+++ b/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLPolicyStatementTypeImpl.java
@@ -54,7 +54,7 @@ public class XACMLPolicyStatementTypeImpl extends AbstractSAMLObject implements
 
     /** {@inheritDoc} */
     public List<XMLObject> getOrderedChildren() {
-        ArrayList<XMLObject> children = new ArrayList<>();
+        final ArrayList<XMLObject> children = new ArrayList<>();
 
         children.addAll(choiceGroup);
 
diff --git a/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLPolicyStatementTypeUnmarshaller.java b/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLPolicyStatementTypeUnmarshaller.java
index cdee8cd..a4011c8 100644
--- a/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLPolicyStatementTypeUnmarshaller.java
+++ b/opensaml-xacml-saml-impl/src/main/java/org/opensaml/xacml/profile/saml/impl/XACMLPolicyStatementTypeUnmarshaller.java
@@ -33,7 +33,7 @@ public class XACMLPolicyStatementTypeUnmarshaller extends AbstractSAMLObjectUnma
     /** {@inheritDoc} */
     protected void processChildElement(final XMLObject parentObject, final XMLObject childObject)
             throws UnmarshallingException {
-        XACMLPolicyStatementType xacmlpolicystatement = (XACMLPolicyStatementType) parentObject;
+        final XACMLPolicyStatementType xacmlpolicystatement = (XACMLPolicyStatementType) parentObject;
 
         if (childObject instanceof PolicyType) {
             xacmlpolicystatement.getPolicies().add((PolicyType) childObject);

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list