[java-opensaml] 04/12: JPAR-85 - Checkstyle, check final variables

[Tom Zeller]

This is an automated email from the git hooks/post-receive script.

tzeller pushed a commit to branch master
in repository java-opensaml.

View the commit online:
http://git.shibboleth.net/view/?p=java-opensaml.git;a=commit;h=653325dd9d296d8e33066fe6a7f391e7f10d3c27

commit 653325dd9d296d8e33066fe6a7f391e7f10d3c27
Author: Tom Zeller <tzeller at dragonacea.biz>
AuthorDate: Thu Aug 10 16:24:50 2017 -0500

    JPAR-85 - Checkstyle, check final variables
---
 .../src/main/java/org/opensaml/storage/impl/JPAStorageService.java  | 4 ++--
 .../main/java/org/opensaml/storage/impl/MemoryStorageService.java   | 4 ++--
 .../opensaml/storage/impl/ServletRequestScopedStorageService.java   | 4 ++--
 .../java/org/opensaml/storage/impl/client/ClientStorageService.java | 2 +-
 .../opensaml/storage/impl/memcached/MemcachedStorageService.java    | 6 +++---
 5 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/opensaml-storage-impl/src/main/java/org/opensaml/storage/impl/JPAStorageService.java b/opensaml-storage-impl/src/main/java/org/opensaml/storage/impl/JPAStorageService.java
index 1e6a9de..7adcb5e 100644
--- a/opensaml-storage-impl/src/main/java/org/opensaml/storage/impl/JPAStorageService.java
+++ b/opensaml-storage-impl/src/main/java/org/opensaml/storage/impl/JPAStorageService.java
@@ -673,7 +673,7 @@ public class JPAStorageService extends AbstractStorageService implements Storage
                     transaction = manager.getTransaction();
                     transaction.begin();
                     // cannot set lock mode on a non-select query
-                    Query queryResults;
+                    final Query queryResults;
                     if (expiration == null) {
                         queryResults = manager.createNamedQuery("JPAStorageRecord.deleteByContext");
                     } else {
@@ -810,7 +810,7 @@ public class JPAStorageService extends AbstractStorageService implements Storage
             final Query queryResults = manager.createNamedQuery(query, clazz);
             queryResults.setLockMode(lockMode);
             if (params != null && !params.isEmpty()) {
-                for (Map.Entry<String, Object> entry : params.entrySet()) {
+                for (final Map.Entry<String, Object> entry : params.entrySet()) {
                     queryResults.setParameter(entry.getKey(), entry.getValue());
                 }
             }
diff --git a/opensaml-storage-impl/src/main/java/org/opensaml/storage/impl/MemoryStorageService.java b/opensaml-storage-impl/src/main/java/org/opensaml/storage/impl/MemoryStorageService.java
index 3fc8864..2959671 100644
--- a/opensaml-storage-impl/src/main/java/org/opensaml/storage/impl/MemoryStorageService.java
+++ b/opensaml-storage-impl/src/main/java/org/opensaml/storage/impl/MemoryStorageService.java
@@ -112,8 +112,8 @@ public class MemoryStorageService extends AbstractMapBackedStorageService implem
                 try {
                     writeLock.lock();
                     
-                    Collection<Map<String, MutableStorageRecord>> contexts = getContextMap().values();
-                    Iterator<Map<String, MutableStorageRecord>> i = contexts.iterator();
+                    final Collection<Map<String, MutableStorageRecord>> contexts = getContextMap().values();
+                    final Iterator<Map<String, MutableStorageRecord>> i = contexts.iterator();
                     while (i.hasNext()) {
                         final Map<String, MutableStorageRecord> context = i.next(); 
                         if (reapWithLock(context, now)) {
diff --git a/opensaml-storage-impl/src/main/java/org/opensaml/storage/impl/ServletRequestScopedStorageService.java b/opensaml-storage-impl/src/main/java/org/opensaml/storage/impl/ServletRequestScopedStorageService.java
index 7d3c4a7..442c72d 100644
--- a/opensaml-storage-impl/src/main/java/org/opensaml/storage/impl/ServletRequestScopedStorageService.java
+++ b/opensaml-storage-impl/src/main/java/org/opensaml/storage/impl/ServletRequestScopedStorageService.java
@@ -341,7 +341,7 @@ public class ServletRequestScopedStorageService extends AbstractMapBackedStorage
                 }
                 
                 final JsonObject contextRecords = (JsonObject) context.getValue();
-                for (Map.Entry<String,JsonValue> record : contextRecords.entrySet()) {
+                for (final Map.Entry<String,JsonValue> record : contextRecords.entrySet()) {
                 
                     final JsonObject fields = (JsonObject) record.getValue();
                     Long exp = null;
@@ -414,7 +414,7 @@ public class ServletRequestScopedStorageService extends AbstractMapBackedStorage
             for (final Map.Entry<String,Map<String, MutableStorageRecord>> context : contextMap.entrySet()) {
                 
                 gen.writeStartObject(context.getKey());
-                for (Map.Entry<String,MutableStorageRecord> entry : context.getValue().entrySet()) {
+                for (final Map.Entry<String,MutableStorageRecord> entry : context.getValue().entrySet()) {
                     final MutableStorageRecord record = entry.getValue();
                     final Long recexp = record.getExpiration();
                     if (recexp == null || recexp > now) {
diff --git a/opensaml-storage-impl/src/main/java/org/opensaml/storage/impl/client/ClientStorageService.java b/opensaml-storage-impl/src/main/java/org/opensaml/storage/impl/client/ClientStorageService.java
index da870f8..935348b 100644
--- a/opensaml-storage-impl/src/main/java/org/opensaml/storage/impl/client/ClientStorageService.java
+++ b/opensaml-storage-impl/src/main/java/org/opensaml/storage/impl/client/ClientStorageService.java
@@ -544,7 +544,7 @@ public class ClientStorageService extends AbstractMapBackedStorageService implem
                     }
                     
                     final JsonObject contextRecords = (JsonObject) context.getValue();
-                    for (Map.Entry<String,JsonValue> record : contextRecords.entrySet()) {
+                    for (final Map.Entry<String,JsonValue> record : contextRecords.entrySet()) {
                     
                         final JsonObject fields = (JsonObject) record.getValue();
                         Long exp = null;
diff --git a/opensaml-storage-impl/src/main/java/org/opensaml/storage/impl/memcached/MemcachedStorageService.java b/opensaml-storage-impl/src/main/java/org/opensaml/storage/impl/memcached/MemcachedStorageService.java
index 6f90f74..c52ecf2 100644
--- a/opensaml-storage-impl/src/main/java/org/opensaml/storage/impl/memcached/MemcachedStorageService.java
+++ b/opensaml-storage-impl/src/main/java/org/opensaml/storage/impl/memcached/MemcachedStorageService.java
@@ -539,11 +539,11 @@ public class MemcachedStorageService extends AbstractIdentifiableInitializableCo
             keySet.removeAll(Arrays.asList(blacklistKeys.getValue().split(CTX_KEY_LIST_DELIMITER)));
         }
         final List<OperationFuture<Boolean>> results = new ArrayList<>(keySet.size());
-        for (String key : keySet) {
+        for (final String key : keySet) {
             logger.debug("Updating expiration of key {} to {}", key, expiry);
             results.add(memcacheClient.touch(key, expiry));
         }
-        for (OperationFuture<Boolean> result : results) {
+        for (final OperationFuture<Boolean> result : results) {
             handleAsyncResult(result);
         }
     }
@@ -635,7 +635,7 @@ public class MemcachedStorageService extends AbstractIdentifiableInitializableCo
         if (parts.length > 0) {
             final StringBuilder sb = new StringBuilder();
             int i = 0;
-            for (String part : parts) {
+            for (final String part : parts) {
                 if (i++ > 0) {
                     sb.append(':');
                 }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.