[java-opensaml] 02/04: JPAR-85 - Checkstyle, check final variables

Tom Zeller tzeller at dragonacea.biz
Wed Aug 9 22:49:41 EDT 2017


This is an automated email from the git hooks/post-receive script.

tzeller pushed a commit to branch master
in repository java-opensaml.

View the commit online:
http://git.shibboleth.net/view/?p=java-opensaml.git;a=commit;h=95d0117522bf323e369201ed13a8dd53ba2e83e1

commit 95d0117522bf323e369201ed13a8dd53ba2e83e1
Author: Tom Zeller <tzeller at dragonacea.biz>
AuthorDate: Wed Aug 9 21:37:03 2017 -0500

    JPAR-85 - Checkstyle, check final variables
---
 .../security/criteria/KeyAlgorithmCriterion.java   |  4 ++--
 .../security/criteria/KeyLengthCriterion.java      |  2 +-
 .../security/criteria/KeyNameCriterion.java        |  4 ++--
 .../security/criteria/PeerEntityIDCriterion.java   |  4 ++--
 .../security/criteria/PublicKeyCriterion.java      |  2 +-
 .../opensaml/security/criteria/UsageCriterion.java |  2 +-
 .../org/opensaml/security/crypto/KeySupport.java   |  2 +-
 .../org/opensaml/security/crypto/SigningUtil.java  | 28 +++++++++++-----------
 .../httpclient/HttpClientSecurityParameters.java   |  2 +-
 .../ServletRequestX509CredentialAdapter.java       |  2 +-
 .../security/x509/BasicX509Credential.java         |  2 +-
 .../security/x509/TrustedNamesCriterion.java       |  4 ++--
 .../security/x509/X509DigestCriterion.java         |  6 ++---
 .../security/x509/X509IssuerSerialCriterion.java   |  4 ++--
 .../x509/X509SubjectKeyIdentifierCriterion.java    |  2 +-
 .../security/x509/X509SubjectNameCriterion.java    |  2 +-
 .../org/opensaml/security/x509/X509Support.java    |  2 +-
 .../security/x509/tls/CertificateNameOptions.java  |  2 +-
 .../ClientTLSValidationConfigurationCriterion.java |  2 +-
 19 files changed, 39 insertions(+), 39 deletions(-)

diff --git a/opensaml-security-api/src/main/java/org/opensaml/security/criteria/KeyAlgorithmCriterion.java b/opensaml-security-api/src/main/java/org/opensaml/security/criteria/KeyAlgorithmCriterion.java
index fa19afb..1c819f4 100644
--- a/opensaml-security-api/src/main/java/org/opensaml/security/criteria/KeyAlgorithmCriterion.java
+++ b/opensaml-security-api/src/main/java/org/opensaml/security/criteria/KeyAlgorithmCriterion.java
@@ -56,7 +56,7 @@ public final class KeyAlgorithmCriterion implements Criterion {
      * @param algorithm The keyAlgorithm to set.
      */
     public void setKeyAlgorithm(@Nonnull final String algorithm) {
-        String trimmed = StringSupport.trimOrNull(algorithm);
+        final String trimmed = StringSupport.trimOrNull(algorithm);
         Constraint.isNotNull(trimmed, "Key algorithm criteria cannot be null or empty");
 
         keyAlgorithm = trimmed;
@@ -64,7 +64,7 @@ public final class KeyAlgorithmCriterion implements Criterion {
     
     /** {@inheritDoc} */
     public String toString() {
-        StringBuilder builder = new StringBuilder();
+        final StringBuilder builder = new StringBuilder();
         builder.append("KeyAlgorithmCriterion [keyAlgorithm=");
         builder.append(keyAlgorithm);
         builder.append("]");
diff --git a/opensaml-security-api/src/main/java/org/opensaml/security/criteria/KeyLengthCriterion.java b/opensaml-security-api/src/main/java/org/opensaml/security/criteria/KeyLengthCriterion.java
index 671c4c9..49a7edb 100644
--- a/opensaml-security-api/src/main/java/org/opensaml/security/criteria/KeyLengthCriterion.java
+++ b/opensaml-security-api/src/main/java/org/opensaml/security/criteria/KeyLengthCriterion.java
@@ -61,7 +61,7 @@ public final class KeyLengthCriterion implements Criterion {
     
     /** {@inheritDoc} */
     public String toString() {
-        StringBuilder builder = new StringBuilder();
+        final StringBuilder builder = new StringBuilder();
         builder.append("KeyLengthCriterion [keyLength=");
         builder.append(keyLength);
         builder.append("]");
diff --git a/opensaml-security-api/src/main/java/org/opensaml/security/criteria/KeyNameCriterion.java b/opensaml-security-api/src/main/java/org/opensaml/security/criteria/KeyNameCriterion.java
index 472a2b5..c012260 100644
--- a/opensaml-security-api/src/main/java/org/opensaml/security/criteria/KeyNameCriterion.java
+++ b/opensaml-security-api/src/main/java/org/opensaml/security/criteria/KeyNameCriterion.java
@@ -56,7 +56,7 @@ public final class KeyNameCriterion implements Criterion {
      * @param name The keyName to set.
      */
     public void setKeyName(@Nonnull final String name) {
-        String trimmed = StringSupport.trimOrNull(name);
+        final String trimmed = StringSupport.trimOrNull(name);
         Constraint.isNotNull(trimmed, "Key name criteria value cannot be null or empty");
 
         keyName = trimmed;
@@ -64,7 +64,7 @@ public final class KeyNameCriterion implements Criterion {
     
     /** {@inheritDoc} */
     public String toString() {
-        StringBuilder builder = new StringBuilder();
+        final StringBuilder builder = new StringBuilder();
         builder.append("KeyNameCriterion [keyName=");
         builder.append(keyName);
         builder.append("]");
diff --git a/opensaml-security-api/src/main/java/org/opensaml/security/criteria/PeerEntityIDCriterion.java b/opensaml-security-api/src/main/java/org/opensaml/security/criteria/PeerEntityIDCriterion.java
index a68982e..6deef15 100644
--- a/opensaml-security-api/src/main/java/org/opensaml/security/criteria/PeerEntityIDCriterion.java
+++ b/opensaml-security-api/src/main/java/org/opensaml/security/criteria/PeerEntityIDCriterion.java
@@ -61,7 +61,7 @@ public final class PeerEntityIDCriterion implements Criterion {
      * @param peer The peerID to set.
      */
     public void setPeerID(@Nonnull final String peer) {
-        String trimmed = StringSupport.trimOrNull(peer);
+        final String trimmed = StringSupport.trimOrNull(peer);
         Constraint.isNotNull(trimmed, "Peer entity ID criteria cannot be null");
         
         peerID = trimmed;
@@ -69,7 +69,7 @@ public final class PeerEntityIDCriterion implements Criterion {
     
     /** {@inheritDoc} */
     public String toString() {
-        StringBuilder builder = new StringBuilder();
+        final StringBuilder builder = new StringBuilder();
         builder.append("PeerEntityIDCriterion [peerID=");
         builder.append(peerID);
         builder.append("]");
diff --git a/opensaml-security-api/src/main/java/org/opensaml/security/criteria/PublicKeyCriterion.java b/opensaml-security-api/src/main/java/org/opensaml/security/criteria/PublicKeyCriterion.java
index 7591c4b..9d35721 100644
--- a/opensaml-security-api/src/main/java/org/opensaml/security/criteria/PublicKeyCriterion.java
+++ b/opensaml-security-api/src/main/java/org/opensaml/security/criteria/PublicKeyCriterion.java
@@ -63,7 +63,7 @@ public final class PublicKeyCriterion implements Criterion {
     
     /** {@inheritDoc} */
     public String toString() {
-        StringBuilder builder = new StringBuilder();
+        final StringBuilder builder = new StringBuilder();
         builder.append("PublicKeyCriterion [publicKey=");
         builder.append(publicKey);
         builder.append("]");
diff --git a/opensaml-security-api/src/main/java/org/opensaml/security/criteria/UsageCriterion.java b/opensaml-security-api/src/main/java/org/opensaml/security/criteria/UsageCriterion.java
index dfb830d..b823d28 100644
--- a/opensaml-security-api/src/main/java/org/opensaml/security/criteria/UsageCriterion.java
+++ b/opensaml-security-api/src/main/java/org/opensaml/security/criteria/UsageCriterion.java
@@ -67,7 +67,7 @@ public final class UsageCriterion implements Criterion {
     
     /** {@inheritDoc} */
     public String toString() {
-        StringBuilder builder = new StringBuilder();
+        final StringBuilder builder = new StringBuilder();
         builder.append("UsageCriterion [credUsage=");
         builder.append(credUsage);
         builder.append("]");
diff --git a/opensaml-security-api/src/main/java/org/opensaml/security/crypto/KeySupport.java b/opensaml-security-api/src/main/java/org/opensaml/security/crypto/KeySupport.java
index 9b5e868..19f3b76 100644
--- a/opensaml-security-api/src/main/java/org/opensaml/security/crypto/KeySupport.java
+++ b/opensaml-security-api/src/main/java/org/opensaml/security/crypto/KeySupport.java
@@ -261,7 +261,7 @@ public final class KeySupport {
      *             public key
      */
     @Nonnull public static PublicKey derivePublicKey(@Nonnull final PrivateKey key) throws KeyException {
-        KeyFactory factory;
+        final KeyFactory factory;
         if (key instanceof DSAPrivateKey) {
             final DSAPrivateKey dsaKey = (DSAPrivateKey) key;
             final DSAParams keyParams = dsaKey.getParams();
diff --git a/opensaml-security-api/src/main/java/org/opensaml/security/crypto/SigningUtil.java b/opensaml-security-api/src/main/java/org/opensaml/security/crypto/SigningUtil.java
index 60b3295..c6a4877 100644
--- a/opensaml-security-api/src/main/java/org/opensaml/security/crypto/SigningUtil.java
+++ b/opensaml-security-api/src/main/java/org/opensaml/security/crypto/SigningUtil.java
@@ -62,9 +62,9 @@ public final class SigningUtil {
     @Nonnull public static byte[] sign(@Nonnull final Credential signingCredential,
             @Nonnull final String jcaAlgorithmID, final boolean isMAC, @Nonnull final byte[] input)
             throws SecurityException {
-        Logger log = getLogger();
+        final Logger log = getLogger();
 
-        Key signingKey = CredentialSupport.extractSigningKey(signingCredential);
+        final Key signingKey = CredentialSupport.extractSigningKey(signingCredential);
         if (signingKey == null) {
             log.error("No signing key supplied in signing credential for signature computation");
             throw new SecurityException("No signing key supplied in signing credential");
@@ -98,15 +98,15 @@ public final class SigningUtil {
         Constraint.isNotNull(jcaAlgorithmID, "JCA algorithm ID cannot be null");
         Constraint.isNotNull(input, "Input data to sign cannot be null");
 
-        Logger log = getLogger();
+        final Logger log = getLogger();
         log.debug("Computing signature over input using private key of type {} and JCA algorithm ID {}", signingKey
                 .getAlgorithm(), jcaAlgorithmID);
 
         try {
-            Signature signature = Signature.getInstance(jcaAlgorithmID);
+            final Signature signature = Signature.getInstance(jcaAlgorithmID);
             signature.initSign(signingKey);
             signature.update(input);
-            byte[] rawSignature = signature.sign();
+            final byte[] rawSignature = signature.sign();
             log.debug("Computed signature: {}", Hex.encodeHex(rawSignature));
             return rawSignature;
         } catch (final GeneralSecurityException e) {
@@ -133,15 +133,15 @@ public final class SigningUtil {
         Constraint.isNotNull(jcaAlgorithmID, "JCA algorithm ID cannot be null");
         Constraint.isNotNull(input, "Input data to sign cannot be null");
 
-        Logger log = getLogger();
+        final Logger log = getLogger();
         log.debug("Computing MAC over input using key of type {} and JCA algorithm ID {}", signingKey.getAlgorithm(),
                 jcaAlgorithmID);
 
         try {
-            Mac mac = Mac.getInstance(jcaAlgorithmID);
+            final Mac mac = Mac.getInstance(jcaAlgorithmID);
             mac.init(signingKey);
             mac.update(input);
-            byte[] rawMAC = mac.doFinal();
+            final byte[] rawMAC = mac.doFinal();
             log.debug("Computed MAC: {}", Hex.encodeHexString(rawMAC));
             return rawMAC;
         } catch (final GeneralSecurityException e) {
@@ -168,9 +168,9 @@ public final class SigningUtil {
     public static boolean verify(@Nonnull final Credential verificationCredential,
             @Nonnull final String jcaAlgorithmID, final boolean isMAC, @Nonnull final byte[] signature,
             @Nonnull final byte[] input) throws SecurityException {
-        Logger log = getLogger();
+        final Logger log = getLogger();
 
-        Key verificationKey = CredentialSupport.extractVerificationKey(verificationCredential);
+        final Key verificationKey = CredentialSupport.extractVerificationKey(verificationCredential);
         if (verificationKey == null) {
             log.error("No verification key supplied in verification credential for signature verification");
             throw new SecurityException("No verification key supplied in verification credential");
@@ -207,12 +207,12 @@ public final class SigningUtil {
         Constraint.isNotNull(signature, "Signature data to verify cannot be null");
         Constraint.isNotNull(input, "Input data to verify cannot be null");
 
-        Logger log = getLogger();
+        final Logger log = getLogger();
         log.debug("Verifying signature over input using public key of type {} and JCA algorithm ID {}", verificationKey
                 .getAlgorithm(), jcaAlgorithmID);
 
         try {
-            Signature sig = Signature.getInstance(jcaAlgorithmID);
+            final Signature sig = Signature.getInstance(jcaAlgorithmID);
             sig.initVerify(verificationKey);
             sig.update(input);
             return sig.verify(signature);
@@ -244,14 +244,14 @@ public final class SigningUtil {
         Constraint.isNotNull(signature, "Signature data to verify cannot be null");
         Constraint.isNotNull(input, "Input data to verify cannot be null");
 
-        Logger log = getLogger();
+        final Logger log = getLogger();
         log.debug("Verifying MAC over input using key of type {} and JCA algorithm ID {}", verificationKey
                 .getAlgorithm(), jcaAlgorithmID);
 
         // Java JCA/JCE Mac interface doesn't have a verification op,
         // so have to compute the Mac and compare the byte arrays manually.
 
-        byte[] computed = signMAC(verificationKey, jcaAlgorithmID, input);
+        final byte[] computed = signMAC(verificationKey, jcaAlgorithmID, input);
         return Arrays.equals(computed, signature);
     }
     
diff --git a/opensaml-security-api/src/main/java/org/opensaml/security/httpclient/HttpClientSecurityParameters.java b/opensaml-security-api/src/main/java/org/opensaml/security/httpclient/HttpClientSecurityParameters.java
index 8c14104..c31ec37 100644
--- a/opensaml-security-api/src/main/java/org/opensaml/security/httpclient/HttpClientSecurityParameters.java
+++ b/opensaml-security-api/src/main/java/org/opensaml/security/httpclient/HttpClientSecurityParameters.java
@@ -118,7 +118,7 @@ public class HttpClientSecurityParameters {
             if (authScope == null) {
                 authScope = new AuthScope(AuthScope.ANY_HOST, AuthScope.ANY_PORT);
             }
-            BasicCredentialsProvider provider = new BasicCredentialsProvider();
+            final BasicCredentialsProvider provider = new BasicCredentialsProvider();
             provider.setCredentials(authScope, credentials);
             credentialsProvider = provider;
         } else {
diff --git a/opensaml-security-api/src/main/java/org/opensaml/security/messaging/ServletRequestX509CredentialAdapter.java b/opensaml-security-api/src/main/java/org/opensaml/security/messaging/ServletRequestX509CredentialAdapter.java
index deddda2..924642f 100644
--- a/opensaml-security-api/src/main/java/org/opensaml/security/messaging/ServletRequestX509CredentialAdapter.java
+++ b/opensaml-security-api/src/main/java/org/opensaml/security/messaging/ServletRequestX509CredentialAdapter.java
@@ -55,7 +55,7 @@ public class ServletRequestX509CredentialAdapter extends AbstractCredential impl
      *  request attribute 'javax.servlet.request.X509Certificate'
      */
     public ServletRequestX509CredentialAdapter(final ServletRequest request) throws SecurityException {
-        X509Certificate[] chain = (X509Certificate[]) request.getAttribute(X509_CERT_REQUEST_ATTRIBUTE);
+        final X509Certificate[] chain = (X509Certificate[]) request.getAttribute(X509_CERT_REQUEST_ATTRIBUTE);
         if (chain == null || chain.length == 0) {
             throw new SecurityException("Servlet request does not contain X.509 certificates in attribute "
                     + X509_CERT_REQUEST_ATTRIBUTE);
diff --git a/opensaml-security-api/src/main/java/org/opensaml/security/x509/BasicX509Credential.java b/opensaml-security-api/src/main/java/org/opensaml/security/x509/BasicX509Credential.java
index 2bf55e3..42c471b 100644
--- a/opensaml-security-api/src/main/java/org/opensaml/security/x509/BasicX509Credential.java
+++ b/opensaml-security-api/src/main/java/org/opensaml/security/x509/BasicX509Credential.java
@@ -122,7 +122,7 @@ public class BasicX509Credential extends BasicCredential implements X509Credenti
     /** {@inheritDoc} */
     @Nonnull public Collection<X509Certificate> getEntityCertificateChain() {
         if (entityCertChain == null) {
-            LazySet<X509Certificate> constructedChain = new LazySet<>();
+            final LazySet<X509Certificate> constructedChain = new LazySet<>();
             constructedChain.add(entityCert);
             return constructedChain;
         } else {
diff --git a/opensaml-security-api/src/main/java/org/opensaml/security/x509/TrustedNamesCriterion.java b/opensaml-security-api/src/main/java/org/opensaml/security/x509/TrustedNamesCriterion.java
index 5dd94ac..f61b1d0 100644
--- a/opensaml-security-api/src/main/java/org/opensaml/security/x509/TrustedNamesCriterion.java
+++ b/opensaml-security-api/src/main/java/org/opensaml/security/x509/TrustedNamesCriterion.java
@@ -76,7 +76,7 @@ public class TrustedNamesCriterion implements Criterion {
     
     /** {@inheritDoc} */
     public String toString() {
-        StringBuilder builder = new StringBuilder();
+        final StringBuilder builder = new StringBuilder();
         builder.append("TrustedNamesCriterion [names=");
         builder.append(trustedNames);
         builder.append("]");
@@ -101,7 +101,7 @@ public class TrustedNamesCriterion implements Criterion {
         }
 
         if (obj instanceof TrustedNamesCriterion) {
-            TrustedNamesCriterion other = (TrustedNamesCriterion) obj;
+            final TrustedNamesCriterion other = (TrustedNamesCriterion) obj;
             return trustedNames.equals(other.trustedNames);
         }
 
diff --git a/opensaml-security-api/src/main/java/org/opensaml/security/x509/X509DigestCriterion.java b/opensaml-security-api/src/main/java/org/opensaml/security/x509/X509DigestCriterion.java
index b832117..3f644ea 100644
--- a/opensaml-security-api/src/main/java/org/opensaml/security/x509/X509DigestCriterion.java
+++ b/opensaml-security-api/src/main/java/org/opensaml/security/x509/X509DigestCriterion.java
@@ -65,7 +65,7 @@ public final class X509DigestCriterion implements Criterion {
      * @param alg the digest algorithm to set
      */
     public void setAlgorithm(@Nonnull final String alg) {
-        String trimmed = StringSupport.trimOrNull(alg);
+        final String trimmed = StringSupport.trimOrNull(alg);
         Constraint.isNotNull(trimmed, "Certificate digest algorithm cannot be null or empty");
 
         algorithm = trimmed;
@@ -94,7 +94,7 @@ public final class X509DigestCriterion implements Criterion {
     
     /** {@inheritDoc} */
     public String toString() {
-        StringBuilder builder = new StringBuilder();
+        final StringBuilder builder = new StringBuilder();
         builder.append("X509DigestCriterion [algorithm=");
         builder.append(algorithm);
         builder.append(", digest=");
@@ -122,7 +122,7 @@ public final class X509DigestCriterion implements Criterion {
         }
 
         if (obj instanceof X509DigestCriterion) {
-            X509DigestCriterion other = (X509DigestCriterion) obj;
+            final X509DigestCriterion other = (X509DigestCriterion) obj;
             return algorithm.equals(other.algorithm) && Arrays.equals(x509digest, other.x509digest);
         }
 
diff --git a/opensaml-security-api/src/main/java/org/opensaml/security/x509/X509IssuerSerialCriterion.java b/opensaml-security-api/src/main/java/org/opensaml/security/x509/X509IssuerSerialCriterion.java
index 931df10..6f26d2a 100644
--- a/opensaml-security-api/src/main/java/org/opensaml/security/x509/X509IssuerSerialCriterion.java
+++ b/opensaml-security-api/src/main/java/org/opensaml/security/x509/X509IssuerSerialCriterion.java
@@ -87,7 +87,7 @@ public final class X509IssuerSerialCriterion implements Criterion {
     
     /** {@inheritDoc} */
     public String toString() {
-        StringBuilder builder = new StringBuilder();
+        final StringBuilder builder = new StringBuilder();
         builder.append("BindingCriterion [issuerName=");
         builder.append(issuerName.getName());
         builder.append(", serialNumber=");
@@ -115,7 +115,7 @@ public final class X509IssuerSerialCriterion implements Criterion {
         }
 
         if (obj instanceof X509IssuerSerialCriterion) {
-            X509IssuerSerialCriterion other = (X509IssuerSerialCriterion) obj;
+            final X509IssuerSerialCriterion other = (X509IssuerSerialCriterion) obj;
             return issuerName.equals(other.issuerName) && serialNumber.equals(other.serialNumber);
         }
 
diff --git a/opensaml-security-api/src/main/java/org/opensaml/security/x509/X509SubjectKeyIdentifierCriterion.java b/opensaml-security-api/src/main/java/org/opensaml/security/x509/X509SubjectKeyIdentifierCriterion.java
index 14339c1..7bb14d4 100644
--- a/opensaml-security-api/src/main/java/org/opensaml/security/x509/X509SubjectKeyIdentifierCriterion.java
+++ b/opensaml-security-api/src/main/java/org/opensaml/security/x509/X509SubjectKeyIdentifierCriterion.java
@@ -64,7 +64,7 @@ public final class X509SubjectKeyIdentifierCriterion implements Criterion {
     
     /** {@inheritDoc} */
     public String toString() {
-        StringBuilder builder = new StringBuilder();
+        final StringBuilder builder = new StringBuilder();
         builder.append("X509SubjectKeyIdentifierCriterion [subjectKeyIdentifier=");
         builder.append(Hex.encodeHexString(subjectKeyIdentifier));
         builder.append("]");
diff --git a/opensaml-security-api/src/main/java/org/opensaml/security/x509/X509SubjectNameCriterion.java b/opensaml-security-api/src/main/java/org/opensaml/security/x509/X509SubjectNameCriterion.java
index 4c70dac..85e16e6 100644
--- a/opensaml-security-api/src/main/java/org/opensaml/security/x509/X509SubjectNameCriterion.java
+++ b/opensaml-security-api/src/main/java/org/opensaml/security/x509/X509SubjectNameCriterion.java
@@ -62,7 +62,7 @@ public final class X509SubjectNameCriterion implements Criterion {
     
     /** {@inheritDoc} */
     public String toString() {
-        StringBuilder builder = new StringBuilder();
+        final StringBuilder builder = new StringBuilder();
         builder.append("X509SubjectNameCriterion [subjectName=");
         builder.append(subjectName.getName());
         builder.append("]");
diff --git a/opensaml-security-api/src/main/java/org/opensaml/security/x509/X509Support.java b/opensaml-security-api/src/main/java/org/opensaml/security/x509/X509Support.java
index ae0ca8c..d8089af 100644
--- a/opensaml-security-api/src/main/java/org/opensaml/security/x509/X509Support.java
+++ b/opensaml-security-api/src/main/java/org/opensaml/security/x509/X509Support.java
@@ -502,7 +502,7 @@ public class X509Support {
             @Nullable final X500DNHandler handler) {
         Constraint.isNotNull(credential, "Credential cannot be null");
         
-        X500DNHandler x500DNHandler;
+        final X500DNHandler x500DNHandler;
         if (handler != null) {
             x500DNHandler = handler;
         } else {
diff --git a/opensaml-security-api/src/main/java/org/opensaml/security/x509/tls/CertificateNameOptions.java b/opensaml-security-api/src/main/java/org/opensaml/security/x509/tls/CertificateNameOptions.java
index 374f9e5..b2f7b4c 100644
--- a/opensaml-security-api/src/main/java/org/opensaml/security/x509/tls/CertificateNameOptions.java
+++ b/opensaml-security-api/src/main/java/org/opensaml/security/x509/tls/CertificateNameOptions.java
@@ -171,7 +171,7 @@ public class CertificateNameOptions implements Cloneable {
     
     /** {@inheritDoc} */
     public CertificateNameOptions clone() {
-        CertificateNameOptions clonedOptions;
+        final CertificateNameOptions clonedOptions;
         try {
             clonedOptions = (CertificateNameOptions) super.clone();
         } catch (final CloneNotSupportedException e) {
diff --git a/opensaml-security-api/src/main/java/org/opensaml/security/x509/tls/ClientTLSValidationConfigurationCriterion.java b/opensaml-security-api/src/main/java/org/opensaml/security/x509/tls/ClientTLSValidationConfigurationCriterion.java
index 3d8dcae..14fcc45 100644
--- a/opensaml-security-api/src/main/java/org/opensaml/security/x509/tls/ClientTLSValidationConfigurationCriterion.java
+++ b/opensaml-security-api/src/main/java/org/opensaml/security/x509/tls/ClientTLSValidationConfigurationCriterion.java
@@ -79,7 +79,7 @@ public class ClientTLSValidationConfigurationCriterion implements Criterion {
     /** {@inheritDoc} */
     @Override
     public String toString() {
-        StringBuilder builder = new StringBuilder();
+        final StringBuilder builder = new StringBuilder();
         builder.append("ClientTLSValidationConfigurationCriterion [configs=");
         builder.append(configs);
         builder.append("]");

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list