[java-opensaml] 01/03: JPAR-85 - Checkstyle, check final parameters

Tom Zeller tzeller at dragonacea.biz
Wed Aug 9 22:28:20 EDT 2017


This is an automated email from the git hooks/post-receive script.

tzeller pushed a commit to branch master
in repository java-opensaml.

View the commit online:
http://git.shibboleth.net/view/?p=java-opensaml.git;a=commit;h=638e6d198cf70a29ebf589a885abc9fe98d438d5

commit 638e6d198cf70a29ebf589a885abc9fe98d438d5
Author: Tom Zeller <tzeller at dragonacea.biz>
AuthorDate: Tue Aug 8 16:29:59 2017 -0500

    JPAR-85 - Checkstyle, check final parameters
---
 .../opensaml/saml/common/AbstractSAMLObject.java   |  2 +-
 .../saml/common/AbstractSAMLObjectMarshaller.java  |  8 ++--
 .../common/AbstractSAMLObjectUnmarshaller.java     |  2 +-
 .../saml/common/AbstractSignableSAMLObject.java    |  2 +-
 .../saml/common/SAMLObjectContentReference.java    |  4 +-
 .../assertion/AssertionValidationException.java    |  6 +--
 .../saml/common/assertion/ValidationContext.java   |  4 +-
 .../common/binding/AbstractEndpointResolver.java   |  2 +-
 .../saml/common/binding/BindingDescriptor.java     |  2 +-
 .../saml/common/binding/SAMLBindingSupport.java    |  8 ++--
 .../binding/artifact/AbstractSAMLArtifact.java     |  2 +-
 .../messaging/SAMLMessageSecuritySupport.java      |  2 +-
 .../messaging/context/SAMLBindingContext.java      |  4 +-
 .../messaging/context/SAMLPeerEntityContext.java   |  2 +-
 .../navigate/EntityDescriptorLookupFunction.java   |  2 +-
 .../logic/SignatureCapableBindingPredicate.java    |  2 +-
 .../opensaml/saml/config/SAMLConfiguration.java    |  8 ++--
 .../saml/config/SAMLConfigurationSupport.java      |  8 ++--
 .../opensaml/saml/criterion/ArtifactCriterion.java |  2 +-
 .../opensaml/saml/criterion/BindingCriterion.java  |  2 +-
 .../saml/criterion/BindingLocationCriterion.java   |  2 +-
 .../BindingResponseLocationCriterion.java          |  2 +-
 .../opensaml/saml/criterion/EndpointCriterion.java |  2 +-
 .../saml/criterion/EntityRoleCriterion.java        |  2 +-
 .../opensaml/saml/criterion/ProtocolCriterion.java |  2 +-
 .../saml/criterion/RoleDescriptorCriterion.java    |  2 +-
 .../criterion/StartsWithLocationCriterion.java     |  4 +-
 .../opensaml/saml/metadata/EntityGroupName.java    |  2 +-
 .../resolver/ChainingMetadataResolver.java         |  4 +-
 .../index/SimpleStringMetadataIndexKey.java        |  2 +-
 .../support/AttributeConsumingServiceSelector.java | 10 ++---
 .../metadata/support/SAML2MetadataSupport.java     |  2 +-
 .../binding/artifact/AbstractSAML1Artifact.java    |  2 +-
 .../artifact/SAML1ArtifactBuilderFactory.java      |  6 +--
 .../binding/artifact/SAML1ArtifactType0001.java    |  8 ++--
 .../artifact/SAML1ArtifactType0001Builder.java     |  2 +-
 .../binding/artifact/SAML1ArtifactType0002.java    |  8 ++--
 .../artifact/SAML1ArtifactType0002Builder.java     |  2 +-
 .../saml/saml1/core/DecisionTypeEnumeration.java   |  2 +-
 .../saml2/assertion/SAML20AssertionValidator.java  | 10 ++---
 .../binding/artifact/AbstractSAML2Artifact.java    |  6 +--
 .../artifact/SAML2ArtifactBuilderFactory.java      |  6 +--
 .../binding/artifact/SAML2ArtifactType0004.java    |  8 ++--
 .../artifact/SAML2ArtifactType0004Builder.java     |  2 +-
 .../IsTimeboundSAMLObjectValidPredicate.java       |  2 +-
 .../opensaml/saml/saml2/common/SAML2Support.java   | 10 ++---
 .../AuthnContextComparisonTypeEnumeration.java     |  2 +-
 .../saml/saml2/core/DecisionTypeEnumeration.java   |  2 +-
 .../opensaml/saml/saml2/encryption/Decrypter.java  |  4 +-
 .../EncryptedElementTypeEncryptedKeyResolver.java  |  2 +-
 .../opensaml/saml/saml2/encryption/Encrypter.java  | 44 +++++++++++-----------
 .../metadata/ContactPersonTypeEnumeration.java     |  2 +-
 52 files changed, 120 insertions(+), 120 deletions(-)

diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSAMLObject.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSAMLObject.java
index 4c96cdf..ba6ff11 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSAMLObject.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSAMLObject.java
@@ -42,7 +42,7 @@ public abstract class AbstractSAMLObject extends AbstractXMLObject {
     }
 
     /** {@inheritDoc} */
-    public final boolean equals(Object obj) {
+    public final boolean equals(final Object obj) {
         if(obj == this){
             return true;
         }
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSAMLObjectMarshaller.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSAMLObjectMarshaller.java
index 0e993bb..83a3f29 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSAMLObjectMarshaller.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSAMLObjectMarshaller.java
@@ -35,7 +35,7 @@ public abstract class AbstractSAMLObjectMarshaller extends AbstractXMLObjectMars
      * 
      * {@inheritDoc}
      */
-    protected void marshallAttributes(XMLObject xmlObject, Element domElement) throws MarshallingException {
+    protected void marshallAttributes(final XMLObject xmlObject, final Element domElement) throws MarshallingException {
 
     }
 
@@ -45,12 +45,12 @@ public abstract class AbstractSAMLObjectMarshaller extends AbstractXMLObjectMars
      * 
      * {@inheritDoc}
      */
-    protected void marshallElementContent(XMLObject xmlObject, Element domElement) throws MarshallingException {
+    protected void marshallElementContent(final XMLObject xmlObject, final Element domElement) throws MarshallingException {
 
     }
 
     /** {@inheritDoc} */
-    public Element marshall(XMLObject xmlObject, Document document) throws MarshallingException {
+    public Element marshall(final XMLObject xmlObject, final Document document) throws MarshallingException {
         if (xmlObject instanceof SignableSAMLObject) {
             SAMLObjectSupport.declareNonVisibleNamespaces((SignableSAMLObject) xmlObject);
         }
@@ -58,7 +58,7 @@ public abstract class AbstractSAMLObjectMarshaller extends AbstractXMLObjectMars
     }
 
     /** {@inheritDoc} */
-    public Element marshall(XMLObject xmlObject, Element parentElement) throws MarshallingException {
+    public Element marshall(final XMLObject xmlObject, final Element parentElement) throws MarshallingException {
         if (xmlObject instanceof SignableSAMLObject) {
             SAMLObjectSupport.declareNonVisibleNamespaces((SignableSAMLObject) xmlObject);
         }
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSAMLObjectUnmarshaller.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSAMLObjectUnmarshaller.java
index b387e60..9aa7763 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSAMLObjectUnmarshaller.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSAMLObjectUnmarshaller.java
@@ -41,7 +41,7 @@ public abstract class AbstractSAMLObjectUnmarshaller extends AbstractXMLObjectUn
     @Nonnull protected SAMLVersion parseSAMLVersion(@Nonnull final Attr attribute) throws UnmarshallingException {
         try {
             return SAMLVersion.valueOf(attribute.getValue());
-        } catch (RuntimeException e) {
+        } catch (final RuntimeException e) {
             throw new UnmarshallingException(String.format("Could not parse SAMLVersion from DOM attribute value '%s'",
                     attribute.getValue()), e);
         }
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSignableSAMLObject.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSignableSAMLObject.java
index beb90bb..c8f7353 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSignableSAMLObject.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSignableSAMLObject.java
@@ -45,7 +45,7 @@ public abstract class AbstractSignableSAMLObject extends AbstractSignableXMLObje
     }
 
     /** {@inheritDoc} */
-    public final boolean equals(Object obj) {
+    public final boolean equals(final Object obj) {
         if(obj == this){
             return true;
         }
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/SAMLObjectContentReference.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/SAMLObjectContentReference.java
index 143ae59..62b52d4 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/SAMLObjectContentReference.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/SAMLObjectContentReference.java
@@ -145,9 +145,9 @@ public class SAMLObjectContentReference implements ConfigurableContentReference
                 signature.addDocument("" , dsigTransforms, digestAlgorithm);
             }
             
-        } catch (TransformationException e) {
+        } catch (final TransformationException e) {
             log.error("Unsupported signature transformation", e);
-        } catch (XMLSignatureException e) {
+        } catch (final XMLSignatureException e) {
             log.error("Error adding content reference to signature", e);
         }
     }
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/assertion/AssertionValidationException.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/assertion/AssertionValidationException.java
index 6c237cb..a1b6c95 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/assertion/AssertionValidationException.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/assertion/AssertionValidationException.java
@@ -35,7 +35,7 @@ public class AssertionValidationException extends SAMLException {
      *
      * @param message the detail message.
      */
-    public AssertionValidationException(String message) {
+    public AssertionValidationException(final String message) {
         super(message);
     }
 
@@ -44,7 +44,7 @@ public class AssertionValidationException extends SAMLException {
      *
      * @param cause the exception cause
      */
-    public AssertionValidationException(Exception cause) {
+    public AssertionValidationException(final Exception cause) {
         super(cause);
     }
 
@@ -54,7 +54,7 @@ public class AssertionValidationException extends SAMLException {
      * @param message the detail message
      * @param cause the exception cause
      */
-    public AssertionValidationException(String message, Exception cause) {
+    public AssertionValidationException(final String message, final Exception cause) {
         super(message, cause);
     }
 
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/assertion/ValidationContext.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/assertion/ValidationContext.java
index e69a516..165ab88 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/assertion/ValidationContext.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/assertion/ValidationContext.java
@@ -50,7 +50,7 @@ public class ValidationContext {
      * 
      * @param newStaticParameters static parameters for the validation evaluation
      */
-    public ValidationContext(Map<String, Object> newStaticParameters) {
+    public ValidationContext(final Map<String, Object> newStaticParameters) {
         if (newStaticParameters == null) {
             staticParameters = Collections.unmodifiableMap(Collections.EMPTY_MAP);
         } else {
@@ -91,7 +91,7 @@ public class ValidationContext {
      * 
      * @param message message describing why the validation process failed
      */
-    public void setValidationFailureMessage(String message) {
+    public void setValidationFailureMessage(final String message) {
         validationFailureMessage = StringSupport.trimOrNull(message);
     }
 }
\ No newline at end of file
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/AbstractEndpointResolver.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/AbstractEndpointResolver.java
index d78f379..751d8fd 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/AbstractEndpointResolver.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/AbstractEndpointResolver.java
@@ -233,7 +233,7 @@ public abstract class AbstractEndpointResolver<EndpointType extends Endpoint>
      */
     // Checkstyle: CyclomaticComplexity OFF
     @Nonnull @NonnullElements private List<EndpointType> sortCandidates(
-            @Nonnull @NonnullElements List<Endpoint> candidates) {
+            @Nonnull @NonnullElements final List<Endpoint> candidates) {
         
         // Use a linked list, and move the default endpoint to the head of the list.
         // SAML defaulting rules apply to IndexedEnpdoint types, and require checking
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/BindingDescriptor.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/BindingDescriptor.java
index c12779c..b5a9314 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/BindingDescriptor.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/BindingDescriptor.java
@@ -177,7 +177,7 @@ public class BindingDescriptor extends AbstractIdentifiableInitializableComponen
 
     /** {@inheritDoc} */
     @Override
-    public boolean equals(Object obj) {
+    public boolean equals(final Object obj) {
         if (obj == null) {
             return false;
         }
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/SAMLBindingSupport.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/SAMLBindingSupport.java
index 4d62100..5147b82 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/SAMLBindingSupport.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/SAMLBindingSupport.java
@@ -76,7 +76,7 @@ public final class SAMLBindingSupport {
      * @param relayState the relay state to set
      */
     public static void setRelayState(@Nonnull final MessageContext<SAMLObject> messageContext, 
-            @Nullable String relayState) {
+            @Nullable final String relayState) {
         messageContext.getSubcontext(SAMLBindingContext.class, true).setRelayState(relayState);
     }
     
@@ -133,7 +133,7 @@ public final class SAMLBindingSupport {
                 && !Strings.isNullOrEmpty(endpoint.getResponseLocation())) {
             try {
                 return new URI(endpoint.getResponseLocation());
-            } catch (URISyntaxException e) {
+            } catch (final URISyntaxException e) {
                 throw new BindingException("The endpoint response location " + endpoint.getResponseLocation()
                         + " is not a valid URL", e);
             }
@@ -143,7 +143,7 @@ public final class SAMLBindingSupport {
             }
             try {
                 return new URI(endpoint.getLocation());
-            } catch (URISyntaxException e) {
+            } catch (final URISyntaxException e) {
                 throw new BindingException("The endpoint location " + endpoint.getLocation()
                         + " is not a valid URL", e);
             }
@@ -315,7 +315,7 @@ public final class SAMLBindingSupport {
      * @param artifactEndpointIndex the endpoint index byte array, must have length == 2, and big endian byte order.
      * @return the convert integer value
      */
-    @Nonnull public static int convertSAML2ArtifactEndpointIndex(@Nonnull byte[] artifactEndpointIndex) {
+    @Nonnull public static int convertSAML2ArtifactEndpointIndex(@Nonnull final byte[] artifactEndpointIndex) {
         Constraint.isNotNull(artifactEndpointIndex, "Artifact endpoint index cannot be null");
         Constraint.isTrue(artifactEndpointIndex.length == 2, "Artifact endpoint index length was not 2, was: "
                 + artifactEndpointIndex.length);
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/artifact/AbstractSAMLArtifact.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/artifact/AbstractSAMLArtifact.java
index d929e9a..523c7d7 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/artifact/AbstractSAMLArtifact.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/artifact/AbstractSAMLArtifact.java
@@ -100,7 +100,7 @@ public abstract class AbstractSAMLArtifact implements SAMLArtifact {
     }
 
     /** {@inheritDoc} */
-    public boolean equals(Object o) {
+    public boolean equals(final Object o) {
         if (o == this) {
             return true;
         }
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/messaging/SAMLMessageSecuritySupport.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/messaging/SAMLMessageSecuritySupport.java
index 59f5a20..4c91964 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/messaging/SAMLMessageSecuritySupport.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/messaging/SAMLMessageSecuritySupport.java
@@ -92,7 +92,7 @@ public final class SAMLMessageSecuritySupport {
      * 
      * @return true if allowed, otherwise false
      */
-    public static boolean checkURLScheme(@Nonnull @NotEmpty String scheme) {
+    public static boolean checkURLScheme(@Nonnull @NotEmpty final String scheme) {
         String normalized = StringSupport.trimOrNull(scheme);
         if (normalized == null) {
             return false;
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/messaging/context/SAMLBindingContext.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/messaging/context/SAMLBindingContext.java
index 8bd9e39..015e57c 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/messaging/context/SAMLBindingContext.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/messaging/context/SAMLBindingContext.java
@@ -60,7 +60,7 @@ public class SAMLBindingContext extends BaseContext {
      * 
      * @param state relay state associated with this protocol exchange
      */
-    public void setRelayState(@Nullable String state) {
+    public void setRelayState(@Nullable final String state) {
         relayState = StringSupport.trimOrNull(state);
     }
 
@@ -140,7 +140,7 @@ public class SAMLBindingContext extends BaseContext {
      * 
      * @param flag true if required, false otherwise
      */
-    public void setIntendedDestinationEndpointURIRequired(boolean flag) {
+    public void setIntendedDestinationEndpointURIRequired(final boolean flag) {
         isIntendedDestinationEndpointURIRequired = flag;
     }
 
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/messaging/context/SAMLPeerEntityContext.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/messaging/context/SAMLPeerEntityContext.java
index 3d81f9e..e0b6a13 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/messaging/context/SAMLPeerEntityContext.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/messaging/context/SAMLPeerEntityContext.java
@@ -87,7 +87,7 @@ public class SAMLPeerEntityContext extends AbstractAuthenticatableSAMLEntityCont
      * 
      * @param useResource whether to use the Resource attribute of some SAML 1 queries to resolve the entity ID
      */
-    public void setUseSAML1QueryResourceAsEntityId(boolean useResource) {
+    public void setUseSAML1QueryResourceAsEntityId(final boolean useResource) {
         useSAML1QueryResourceAsEntityId = useResource;
     }
 
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/messaging/context/navigate/EntityDescriptorLookupFunction.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/messaging/context/navigate/EntityDescriptorLookupFunction.java
index efaadc0..c70eb5a 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/messaging/context/navigate/EntityDescriptorLookupFunction.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/messaging/context/navigate/EntityDescriptorLookupFunction.java
@@ -29,7 +29,7 @@ import org.opensaml.saml.saml2.metadata.EntityDescriptor;
 public class EntityDescriptorLookupFunction implements ContextDataLookupFunction<SAMLMetadataContext,EntityDescriptor> {
 
     /** {@inheritDoc} */
-    @Override @Nullable public EntityDescriptor apply(@Nullable SAMLMetadataContext input) {
+    @Override @Nullable public EntityDescriptor apply(@Nullable final SAMLMetadataContext input) {
         if (null == input) {
             return null;
         }
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/messaging/logic/SignatureCapableBindingPredicate.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/messaging/logic/SignatureCapableBindingPredicate.java
index e27e3b4..f7d5d7e 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/messaging/logic/SignatureCapableBindingPredicate.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/messaging/logic/SignatureCapableBindingPredicate.java
@@ -31,7 +31,7 @@ public class SignatureCapableBindingPredicate implements Predicate<MessageContex
 
     /** {@inheritDoc} */
     @Override
-    public boolean apply(MessageContext<SAMLObject> input) {
+    public boolean apply(final MessageContext<SAMLObject> input) {
         return input != null && SAMLBindingSupport.isSigningCapableBinding(input);
     }
 
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/config/SAMLConfiguration.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/config/SAMLConfiguration.java
index b4e132e..a214bbd 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/config/SAMLConfiguration.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/config/SAMLConfiguration.java
@@ -102,7 +102,7 @@ public class SAMLConfiguration {
      * 
      * @param format date format used to string'ify date objects
      */
-    public void setSAMLDateFormat(String format) {
+    public void setSAMLDateFormat(final String format) {
         DateTimeFormatter formatter = DateTimeFormat.forPattern(format);
         dateFormatter = formatter.withChronology(ISOChronology.getInstanceUTC());
     }
@@ -121,7 +121,7 @@ public class SAMLConfiguration {
      * 
      * @param factory artifact factory for the library
      */
-    public void setSAML1ArtifactBuilderFactory(SAML1ArtifactBuilderFactory factory) {
+    public void setSAML1ArtifactBuilderFactory(final SAML1ArtifactBuilderFactory factory) {
         saml1ArtifactBuilderFactory = factory;
     }
 
@@ -139,7 +139,7 @@ public class SAMLConfiguration {
      * 
      * @param factory artifact factory for the library
      */
-    public void setSAML2ArtifactBuilderFactory(SAML2ArtifactBuilderFactory factory) {
+    public void setSAML2ArtifactBuilderFactory(final SAML2ArtifactBuilderFactory factory) {
         saml2ArtifactBuilderFactory = factory;
     }
 
@@ -191,7 +191,7 @@ public class SAMLConfiguration {
     private static class LowercaseFunction implements Function<String, String> {
 
         /** {@inheritDoc} */
-        public String apply(String input) {
+        public String apply(final String input) {
             if (input == null) {
                 return null;
             } else {
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/config/SAMLConfigurationSupport.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/config/SAMLConfigurationSupport.java
index 1c07294..f703f94 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/config/SAMLConfigurationSupport.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/config/SAMLConfigurationSupport.java
@@ -52,7 +52,7 @@ public final class SAMLConfigurationSupport {
      * 
      * @param format date format used to string'ify date objects
      */
-    public static void setSAMLDateFormat(String format) {
+    public static void setSAMLDateFormat(final String format) {
         ConfigurationService.get(SAMLConfiguration.class).setSAMLDateFormat(format);
     }
 
@@ -70,7 +70,7 @@ public final class SAMLConfigurationSupport {
      * 
      * @param factory artifact factory for the library
      */
-    public static void setSAML1ArtifactBuilderFactory(SAML1ArtifactBuilderFactory factory) {
+    public static void setSAML1ArtifactBuilderFactory(final SAML1ArtifactBuilderFactory factory) {
         ConfigurationService.get(SAMLConfiguration.class).setSAML1ArtifactBuilderFactory(factory);
     }
 
@@ -88,7 +88,7 @@ public final class SAMLConfigurationSupport {
      * 
      * @param factory artifact factory for the library
      */
-    public static void setSAML2ArtifactBuilderFactory(SAML2ArtifactBuilderFactory factory) {
+    public static void setSAML2ArtifactBuilderFactory(final SAML2ArtifactBuilderFactory factory) {
         ConfigurationService.get(SAMLConfiguration.class).setSAML2ArtifactBuilderFactory(factory);
     }
     
@@ -106,7 +106,7 @@ public final class SAMLConfigurationSupport {
      * 
      * @param schemes the new list of allowed URL schemes
      */
-    public static void setAllowedBindingURLSchemes(List<String>schemes) {
+    public static void setAllowedBindingURLSchemes(final List<String>schemes) {
         ConfigurationService.get(SAMLConfiguration.class).setAllowedBindingURLSchemes(schemes);
     }
 }
\ No newline at end of file
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/ArtifactCriterion.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/ArtifactCriterion.java
index a515183..0075c54 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/ArtifactCriterion.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/ArtifactCriterion.java
@@ -69,7 +69,7 @@ public final class ArtifactCriterion implements Criterion {
 
     /** {@inheritDoc} */
     @Override
-    public boolean equals(Object obj) {
+    public boolean equals(final Object obj) {
         if (this == obj) {
             return true;
         }
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/BindingCriterion.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/BindingCriterion.java
index 735a400..3c5f5c7 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/BindingCriterion.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/BindingCriterion.java
@@ -81,7 +81,7 @@ public final class BindingCriterion implements Criterion {
 
     /** {@inheritDoc} */
     @Override
-    public boolean equals(Object obj) {
+    public boolean equals(final Object obj) {
         if (this == obj) {
             return true;
         }
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/BindingLocationCriterion.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/BindingLocationCriterion.java
index 2046ec9..7a60517 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/BindingLocationCriterion.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/BindingLocationCriterion.java
@@ -66,7 +66,7 @@ public final class BindingLocationCriterion implements Criterion {
 
     /** {@inheritDoc} */
     @Override
-    public boolean equals(Object obj) {
+    public boolean equals(final Object obj) {
         if (this == obj) {
             return true;
         }
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/BindingResponseLocationCriterion.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/BindingResponseLocationCriterion.java
index 1b3e222..6ab6a41 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/BindingResponseLocationCriterion.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/BindingResponseLocationCriterion.java
@@ -68,7 +68,7 @@ public final class BindingResponseLocationCriterion implements Criterion {
 
     /** {@inheritDoc} */
     @Override
-    public boolean equals(Object obj) {
+    public boolean equals(final Object obj) {
         if (this == obj) {
             return true;
         }
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/EndpointCriterion.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/EndpointCriterion.java
index f8c542a..bdf93c7 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/EndpointCriterion.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/EndpointCriterion.java
@@ -112,7 +112,7 @@ public final class EndpointCriterion<EndpointType extends Endpoint> implements C
 
     /** {@inheritDoc} */
     @Override
-    public boolean equals(Object obj) {
+    public boolean equals(final Object obj) {
         if (this == obj) {
             return true;
         }
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/EntityRoleCriterion.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/EntityRoleCriterion.java
index 29ad78b..bae5aab 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/EntityRoleCriterion.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/EntityRoleCriterion.java
@@ -65,7 +65,7 @@ public final class EntityRoleCriterion implements Criterion {
 
     /** {@inheritDoc} */
     @Override
-    public boolean equals(Object obj) {
+    public boolean equals(final Object obj) {
         if (this == obj) {
             return true;
         }
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/ProtocolCriterion.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/ProtocolCriterion.java
index 865fb7a..1cbd70d 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/ProtocolCriterion.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/ProtocolCriterion.java
@@ -67,7 +67,7 @@ public final class ProtocolCriterion implements Criterion {
 
     /** {@inheritDoc} */
     @Override
-    public boolean equals(Object obj) {
+    public boolean equals(final Object obj) {
         if (this == obj) {
             return true;
         }
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/RoleDescriptorCriterion.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/RoleDescriptorCriterion.java
index 7be88fd..924af7d 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/RoleDescriptorCriterion.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/RoleDescriptorCriterion.java
@@ -66,7 +66,7 @@ public final class RoleDescriptorCriterion implements Criterion {
 
     /** {@inheritDoc} */
     @Override
-    public boolean equals(Object obj) {
+    public boolean equals(final Object obj) {
         if (this == obj) {
             return true;
         }
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/StartsWithLocationCriterion.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/StartsWithLocationCriterion.java
index a390d6b..9c686d4 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/StartsWithLocationCriterion.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/StartsWithLocationCriterion.java
@@ -44,7 +44,7 @@ public class StartsWithLocationCriterion implements Criterion {
      *
      * @param value the matchStartsWith flag value
      */
-    public StartsWithLocationCriterion(boolean value) {
+    public StartsWithLocationCriterion(final boolean value) {
         matchStartsWith = value;
     }
 
@@ -63,7 +63,7 @@ public class StartsWithLocationCriterion implements Criterion {
     }
 
     /** {@inheritDoc} */
-    public boolean equals(Object other) {
+    public boolean equals(final Object other) {
         if (this == other) {
             return true;
         }
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/metadata/EntityGroupName.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/metadata/EntityGroupName.java
index ade3a9e..ce23b92 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/metadata/EntityGroupName.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/metadata/EntityGroupName.java
@@ -61,7 +61,7 @@ public class EntityGroupName {
 
     /** {@inheritDoc} */
     @Override
-    public boolean equals(Object obj) {
+    public boolean equals(final Object obj) {
         if (obj == this) {
             return true;
         }
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/metadata/resolver/ChainingMetadataResolver.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/metadata/resolver/ChainingMetadataResolver.java
index 2751df1..b8a256f 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/metadata/resolver/ChainingMetadataResolver.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/metadata/resolver/ChainingMetadataResolver.java
@@ -100,7 +100,7 @@ public class ChainingMetadataResolver extends AbstractIdentifiableInitializableC
     }
 
     /** {@inheritDoc} */
-    @Override public void setRequireValidMetadata(boolean requireValidMetadata) {
+    @Override public void setRequireValidMetadata(final boolean requireValidMetadata) {
         throw new UnsupportedOperationException("Setting requireValidMetadata is not supported on chaining resolver");
     }
 
@@ -111,7 +111,7 @@ public class ChainingMetadataResolver extends AbstractIdentifiableInitializableC
     }
 
     /** {@inheritDoc} */
-    @Override public void setMetadataFilter(MetadataFilter newFilter) {
+    @Override public void setMetadataFilter(final MetadataFilter newFilter) {
         throw new UnsupportedOperationException("Metadata filters are not supported on ChainingMetadataResolver");
     }
 
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/metadata/resolver/index/SimpleStringMetadataIndexKey.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/metadata/resolver/index/SimpleStringMetadataIndexKey.java
index c3e7a06..d6524c7 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/metadata/resolver/index/SimpleStringMetadataIndexKey.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/metadata/resolver/index/SimpleStringMetadataIndexKey.java
@@ -64,7 +64,7 @@ public class SimpleStringMetadataIndexKey implements MetadataIndexKey {
 
     /** {@inheritDoc} */
     @Override
-    public boolean equals(Object obj) {
+    public boolean equals(final Object obj) {
         if (this == obj) {
             return true;
         }
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/metadata/support/AttributeConsumingServiceSelector.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/metadata/support/AttributeConsumingServiceSelector.java
index 5f5f6a7..e8f7324 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/metadata/support/AttributeConsumingServiceSelector.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/metadata/support/AttributeConsumingServiceSelector.java
@@ -87,7 +87,7 @@ public class AttributeConsumingServiceSelector {
      * 
      * @param requestedIndex The index to set.
      */
-    public void setIndex(Integer requestedIndex) {
+    public void setIndex(final Integer requestedIndex) {
         index = requestedIndex;
     }
 
@@ -105,7 +105,7 @@ public class AttributeConsumingServiceSelector {
      * 
      * @param descriptor The roleDescriptor to set.
      */
-    public void setRoleDescriptor(RoleDescriptor descriptor) {
+    public void setRoleDescriptor(final RoleDescriptor descriptor) {
         roleDescriptor = descriptor;
     }
 
@@ -115,7 +115,7 @@ public class AttributeConsumingServiceSelector {
      * 
      * @param flag The onBadIndexUseDefault to set.
      */
-    public void setOnBadIndexUseDefault(boolean flag) {
+    public void setOnBadIndexUseDefault(final boolean flag) {
         onBadIndexUseDefault = flag;
     }
 
@@ -201,7 +201,7 @@ public class AttributeConsumingServiceSelector {
      * @param candidates the list of candiate services
      * @return the selected candidate or null
      */
-    private AttributeConsumingService selectByIndex(List<AttributeConsumingService> candidates) {
+    private AttributeConsumingService selectByIndex(final List<AttributeConsumingService> candidates) {
         log.debug("Selecting AttributeConsumingService by index");
         for (AttributeConsumingService attribCS : candidates) {
             // Check for null b/c don't ever want to fail with an NPE due to autoboxing.
@@ -223,7 +223,7 @@ public class AttributeConsumingServiceSelector {
      * @param candidates the list of candiate services
      * @return the selected candidate or null
      */
-    private AttributeConsumingService selectDefault(List<AttributeConsumingService> candidates) {
+    private AttributeConsumingService selectDefault(final List<AttributeConsumingService> candidates) {
         log.debug("Selecting default AttributeConsumingService");
         AttributeConsumingService firstNoDefault = null;
         for (AttributeConsumingService attribCS : candidates) {
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/metadata/support/SAML2MetadataSupport.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/metadata/support/SAML2MetadataSupport.java
index dd4d065..6180adc 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/metadata/support/SAML2MetadataSupport.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/metadata/support/SAML2MetadataSupport.java
@@ -50,7 +50,7 @@ public final class SAML2MetadataSupport {
      * @param <T> the subtype of IndexedType
      * 
      */
-    public static <T extends IndexedEndpoint> T getDefaultIndexedEndpoint(List<T> candidates) {
+    public static <T extends IndexedEndpoint> T getDefaultIndexedEndpoint(final List<T> candidates) {
         Logger log = getLogger();
         log.debug("Selecting default IndexedEndpoint");
         
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/binding/artifact/AbstractSAML1Artifact.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/binding/artifact/AbstractSAML1Artifact.java
index 2951ec2..7434156 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/binding/artifact/AbstractSAML1Artifact.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/binding/artifact/AbstractSAML1Artifact.java
@@ -29,7 +29,7 @@ public abstract class AbstractSAML1Artifact extends AbstractSAMLArtifact impleme
      * 
      * @param typeCode artifact type code
      */
-    protected AbstractSAML1Artifact(byte[] typeCode) {
+    protected AbstractSAML1Artifact(final byte[] typeCode) {
         super(typeCode);
     }
 }
\ No newline at end of file
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/binding/artifact/SAML1ArtifactBuilderFactory.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/binding/artifact/SAML1ArtifactBuilderFactory.java
index 2e3939f..2fd717d 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/binding/artifact/SAML1ArtifactBuilderFactory.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/binding/artifact/SAML1ArtifactBuilderFactory.java
@@ -53,7 +53,7 @@ public class SAML1ArtifactBuilderFactory {
      * 
      * @return artifact builder for the given type
      */
-    public SAML1ArtifactBuilder getArtifactBuilder(byte[] type) {
+    public SAML1ArtifactBuilder getArtifactBuilder(final byte[] type) {
         return artifactBuilders.get(new String(type));
     }
     
@@ -64,7 +64,7 @@ public class SAML1ArtifactBuilderFactory {
      * 
      * @return constructed artifact
      */
-    public AbstractSAML1Artifact buildArtifact(String base64Artifact){
+    public AbstractSAML1Artifact buildArtifact(final String base64Artifact){
         return buildArtifact(Base64Support.decode(base64Artifact));
     }
 
@@ -75,7 +75,7 @@ public class SAML1ArtifactBuilderFactory {
      * 
      * @return constructed artifact
      */
-    public AbstractSAML1Artifact buildArtifact(byte[] artifact) {
+    public AbstractSAML1Artifact buildArtifact(final byte[] artifact) {
         if(artifact == null){
             return null;
         }
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/binding/artifact/SAML1ArtifactType0001.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/binding/artifact/SAML1ArtifactType0001.java
index 454b53b..d96c4a5 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/binding/artifact/SAML1ArtifactType0001.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/binding/artifact/SAML1ArtifactType0001.java
@@ -50,7 +50,7 @@ public class SAML1ArtifactType0001 extends AbstractSAML1Artifact implements SAML
      * @throws IllegalArgumentException thrown if the given source ID or message handle are not of the current length
      *             (20 bytes)
      */
-    public SAML1ArtifactType0001(byte[] source, byte[] handle) {
+    public SAML1ArtifactType0001(final byte[] source, final byte[] handle) {
         super(TYPE_CODE);
 
         setSourceID(source);
@@ -67,7 +67,7 @@ public class SAML1ArtifactType0001 extends AbstractSAML1Artifact implements SAML
      * @throws IllegalArgumentException thrown if the artifact is not the right type or lenght (42 bytes) or is not of
      *             the correct type (0x0001)
      */
-    public static SAML1ArtifactType0001 parseArtifact(byte[] artifact) {
+    public static SAML1ArtifactType0001 parseArtifact(final byte[] artifact) {
         if (artifact.length != 42) {
             throw new IllegalArgumentException("Artifact length must be 42 bytes it was " + artifact.length + "bytes");
         }
@@ -102,7 +102,7 @@ public class SAML1ArtifactType0001 extends AbstractSAML1Artifact implements SAML
      * 
      * @throws IllegalArgumentException thrown if the given source ID is not 20 bytes
      */
-    protected void setSourceID(byte[] newSourceID) {
+    protected void setSourceID(final byte[] newSourceID) {
         if (newSourceID.length != 20) {
             throw new IllegalArgumentException("Artifact source ID must be 20 bytes long");
         }
@@ -123,7 +123,7 @@ public class SAML1ArtifactType0001 extends AbstractSAML1Artifact implements SAML
      * 
      * @param handle artifiact's 20 byte assertion handle
      */
-    public void setAssertionHandle(byte[] handle) {
+    public void setAssertionHandle(final byte[] handle) {
         if (handle.length != 20) {
             throw new IllegalArgumentException("Artifact assertion handle must be 20 bytes long");
         }
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/binding/artifact/SAML1ArtifactType0001Builder.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/binding/artifact/SAML1ArtifactType0001Builder.java
index c72696b..987edac 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/binding/artifact/SAML1ArtifactType0001Builder.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/binding/artifact/SAML1ArtifactType0001Builder.java
@@ -41,7 +41,7 @@ public class SAML1ArtifactType0001Builder implements SAML1ArtifactBuilder<SAML1A
 
     /** {@inheritDoc} */
     @Override
-    @Nullable public SAML1ArtifactType0001 buildArtifact(byte[] artifact) {
+    @Nullable public SAML1ArtifactType0001 buildArtifact(final byte[] artifact) {
         try {
             return SAML1ArtifactType0001.parseArtifact(artifact);
         } catch (final IllegalArgumentException e) {
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/binding/artifact/SAML1ArtifactType0002.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/binding/artifact/SAML1ArtifactType0002.java
index 1b4a54a..ac32dd5 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/binding/artifact/SAML1ArtifactType0002.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/binding/artifact/SAML1ArtifactType0002.java
@@ -52,7 +52,7 @@ public class SAML1ArtifactType0002 extends AbstractSAML1Artifact implements SAML
      * @throws IllegalArgumentException thrown if the given assertion handle is not 20 bytes or the source location is
      *             null or empty
      */
-    public SAML1ArtifactType0002(byte[] handle, String location) {
+    public SAML1ArtifactType0002(final byte[] handle, final String location) {
         super(TYPE_CODE);
 
         setAssertionHandle(handle);
@@ -67,7 +67,7 @@ public class SAML1ArtifactType0002 extends AbstractSAML1Artifact implements SAML
      * 
      * @throws IllegalArgumentException thrown if the artifact type is not 0x0002
      */
-    public static SAML1ArtifactType0002 parseArtifact(byte[] artifact) {
+    public static SAML1ArtifactType0002 parseArtifact(final byte[] artifact) {
         byte[] typeCode = { artifact[0], artifact[1] };
         if (!Arrays.equals(typeCode, TYPE_CODE)) {
             throw new IllegalArgumentException("Artifact is not of appropriate type.");
@@ -97,7 +97,7 @@ public class SAML1ArtifactType0002 extends AbstractSAML1Artifact implements SAML
      * 
      * @param handle artifiact's 20 byte assertion handle
      */
-    public void setAssertionHandle(byte[] handle) {
+    public void setAssertionHandle(final byte[] handle) {
         if (handle.length != 20) {
             throw new IllegalArgumentException("Artifact assertion handle must be 20 bytes long");
         }
@@ -120,7 +120,7 @@ public class SAML1ArtifactType0002 extends AbstractSAML1Artifact implements SAML
      * 
      * @throws IllegalArgumentException thrown if the given location is empty or null
      */
-    protected void setSourceLocation(String newLocation) {
+    protected void setSourceLocation(final String newLocation) {
         String location = StringSupport.trimOrNull(newLocation);
         if (location == null) {
             throw new IllegalArgumentException("Artifact source location may not be a null or empty string");
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/binding/artifact/SAML1ArtifactType0002Builder.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/binding/artifact/SAML1ArtifactType0002Builder.java
index 7e65602..a97637e 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/binding/artifact/SAML1ArtifactType0002Builder.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/binding/artifact/SAML1ArtifactType0002Builder.java
@@ -42,7 +42,7 @@ public class SAML1ArtifactType0002Builder implements SAML1ArtifactBuilder<SAML1A
 
     /** {@inheritDoc} */
     @Override
-    @Nullable public SAML1ArtifactType0002 buildArtifact(@Nonnull @NotEmpty byte[] artifact) {
+    @Nullable public SAML1ArtifactType0002 buildArtifact(@Nonnull @NotEmpty final byte[] artifact) {
         try {
             return SAML1ArtifactType0002.parseArtifact(artifact);
         } catch (final IllegalArgumentException e) {
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/core/DecisionTypeEnumeration.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/core/DecisionTypeEnumeration.java
index 72d1e8a..636dc8c 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/core/DecisionTypeEnumeration.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/core/DecisionTypeEnumeration.java
@@ -39,7 +39,7 @@ public final class DecisionTypeEnumeration {
      *  
      *  @param newDecisionType the decision type
      */
-    protected DecisionTypeEnumeration(String newDecisionType) {
+    protected DecisionTypeEnumeration(final String newDecisionType) {
         this.decisionType = newDecisionType;
     }
 
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/assertion/SAML20AssertionValidator.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/assertion/SAML20AssertionValidator.java
index 3bc657b..50c04ce 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/assertion/SAML20AssertionValidator.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/assertion/SAML20AssertionValidator.java
@@ -131,7 +131,7 @@ public class SAML20AssertionValidator {
      */
     public SAML20AssertionValidator(@Nullable final Collection<ConditionValidator> newConditionValidators,
             @Nullable final Collection<SubjectConfirmationValidator> newConfirmationValidators,
-            @Nullable Collection<StatementValidator> newStatementValidators, 
+            @Nullable final Collection<StatementValidator> newStatementValidators, 
             @Nullable final SignatureTrustEngine newTrustEngine,
             @Nullable final SignaturePrevalidator newSignaturePrevalidator) {
         
@@ -183,7 +183,7 @@ public class SAML20AssertionValidator {
                 if (clockSkew < 1) {
                     clockSkew = DEFAULT_CLOCK_SKEW;
                 }
-            } catch (ClassCastException e) {
+            } catch (final ClassCastException e) {
                 clockSkew = DEFAULT_CLOCK_SKEW;
             }
         }
@@ -333,7 +333,7 @@ public class SAML20AssertionValidator {
         
         try {
             signaturePrevalidator.validate(signature);
-        } catch (SignatureException e) {
+        } catch (final SignatureException e) {
             String msg = String.format("Assertion Signature failed pre-validation: %s", e.getMessage());
             log.warn(msg);
             context.setValidationFailureMessage(msg);
@@ -354,7 +354,7 @@ public class SAML20AssertionValidator {
                 context.setValidationFailureMessage(msg);
                 return ValidationResult.INVALID;
             }
-        } catch (SecurityException e) {
+        } catch (final SecurityException e) {
             String msg = String.format(
                     "A problem was encountered evaluating the signature over Assertion with ID '%s': %s",
                     token.getID(), e.getMessage());
@@ -535,7 +535,7 @@ public class SAML20AssertionValidator {
                                 SAML2AssertionValidationParameters.CONFIRMED_SUBJECT_CONFIRMATION, confirmation);
                         return ValidationResult.VALID;
                     }
-                } catch (AssertionValidationException e) {
+                } catch (final AssertionValidationException e) {
                     log.warn("Error while executing subject confirmation validation " + validator.getClass().getName(),
                             e);
                 }
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/binding/artifact/AbstractSAML2Artifact.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/binding/artifact/AbstractSAML2Artifact.java
index e329785..6e18b9c 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/binding/artifact/AbstractSAML2Artifact.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/binding/artifact/AbstractSAML2Artifact.java
@@ -35,7 +35,7 @@ public abstract class AbstractSAML2Artifact extends AbstractSAMLArtifact impleme
      * 
      * @param artifactType artifact type code
      */
-    protected AbstractSAML2Artifact(byte[] artifactType) {
+    protected AbstractSAML2Artifact(final byte[] artifactType) {
         super(artifactType);
     }
 
@@ -48,7 +48,7 @@ public abstract class AbstractSAML2Artifact extends AbstractSAMLArtifact impleme
      * @throws IllegalArgumentException thrown if the endpoint index, source ID, or message handle arrays are not of the
      *             right size
      */
-    public AbstractSAML2Artifact(byte[] artifactType, byte[] index) {
+    public AbstractSAML2Artifact(final byte[] artifactType, final byte[] index) {
         super(artifactType);
         setEndpointIndex(index);
     }
@@ -81,7 +81,7 @@ public abstract class AbstractSAML2Artifact extends AbstractSAMLArtifact impleme
      * 
      * @throws IllegalArgumentException thrown if the given index is not 2 bytes
      */
-    public void setEndpointIndex(byte[] newIndex) {
+    public void setEndpointIndex(final byte[] newIndex) {
         if (newIndex.length != 2) {
             throw new IllegalArgumentException("Artifact endpoint index must be two bytes long");
         }
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/binding/artifact/SAML2ArtifactBuilderFactory.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/binding/artifact/SAML2ArtifactBuilderFactory.java
index 0175889..4e84e6b 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/binding/artifact/SAML2ArtifactBuilderFactory.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/binding/artifact/SAML2ArtifactBuilderFactory.java
@@ -52,7 +52,7 @@ public class SAML2ArtifactBuilderFactory {
      * 
      * @return artifact builder for the given type
      */
-    public SAML2ArtifactBuilder getArtifactBuilder(byte[] type) {
+    public SAML2ArtifactBuilder getArtifactBuilder(final byte[] type) {
         return artifactBuilders.get(new String(type));
     }
     
@@ -63,7 +63,7 @@ public class SAML2ArtifactBuilderFactory {
      * 
      * @return constructed artifact
      */
-    public AbstractSAML2Artifact buildArtifact(String base64Artifact){
+    public AbstractSAML2Artifact buildArtifact(final String base64Artifact){
         return buildArtifact(Base64Support.decode(base64Artifact));
     }
 
@@ -74,7 +74,7 @@ public class SAML2ArtifactBuilderFactory {
      * 
      * @return constructed artifact
      */
-    public AbstractSAML2Artifact buildArtifact(byte[] artifact) {
+    public AbstractSAML2Artifact buildArtifact(final byte[] artifact) {
         if(artifact == null){
             return null;
         }
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/binding/artifact/SAML2ArtifactType0004.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/binding/artifact/SAML2ArtifactType0004.java
index 19523f7..fe0dca9 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/binding/artifact/SAML2ArtifactType0004.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/binding/artifact/SAML2ArtifactType0004.java
@@ -51,7 +51,7 @@ public class SAML2ArtifactType0004 extends AbstractSAML2Artifact implements SAML
      * @throws IllegalArgumentException thrown if the endpoint index, source ID, or message handle arrays are not of the
      *             right size
      */
-    public SAML2ArtifactType0004(byte[] endpointIndex, byte[] source, byte[] handle) {
+    public SAML2ArtifactType0004(final byte[] endpointIndex, final byte[] source, final byte[] handle) {
         super(TYPE_CODE, endpointIndex);
         setSourceID(source);
         setMessageHandle(handle);
@@ -66,7 +66,7 @@ public class SAML2ArtifactType0004 extends AbstractSAML2Artifact implements SAML
      * 
      * @throws IllegalArgumentException thrown if the artifact is not the right type or lenght (44 bytes)
      */
-    public static SAML2ArtifactType0004 parseArtifact(byte[] artifact) {
+    public static SAML2ArtifactType0004 parseArtifact(final byte[] artifact) {
         if (artifact.length != 44) {
             throw new IllegalArgumentException("Artifact length must be 44 bytes it was " + artifact.length + "bytes");
         }
@@ -103,7 +103,7 @@ public class SAML2ArtifactType0004 extends AbstractSAML2Artifact implements SAML
      * 
      * @throws IllegalArgumentException thrown if the given source ID is not 20 bytes
      */
-    public void setSourceID(byte[] newSourceID) {
+    public void setSourceID(final byte[] newSourceID) {
         if (newSourceID.length != 20) {
             throw new IllegalArgumentException("Artifact source ID must be 20 bytes long");
         }
@@ -124,7 +124,7 @@ public class SAML2ArtifactType0004 extends AbstractSAML2Artifact implements SAML
      * 
      * @param handle 20 byte message handle of the artifact
      */
-    public void setMessageHandle(byte[] handle) {
+    public void setMessageHandle(final byte[] handle) {
         if (handle.length != 20) {
             throw new IllegalArgumentException("Artifact message handle must be 20 bytes long");
         }
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/binding/artifact/SAML2ArtifactType0004Builder.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/binding/artifact/SAML2ArtifactType0004Builder.java
index f0586a8..1550b0f 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/binding/artifact/SAML2ArtifactType0004Builder.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/binding/artifact/SAML2ArtifactType0004Builder.java
@@ -42,7 +42,7 @@ public class SAML2ArtifactType0004Builder implements SAML2ArtifactBuilder<SAML2A
 
     /** {@inheritDoc} */
     @Override
-    @Nullable public SAML2ArtifactType0004 buildArtifact(@Nonnull @NotEmpty byte[] artifact) {
+    @Nullable public SAML2ArtifactType0004 buildArtifact(@Nonnull @NotEmpty final byte[] artifact) {
         return SAML2ArtifactType0004.parseArtifact(artifact);
     }
 
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/common/IsTimeboundSAMLObjectValidPredicate.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/common/IsTimeboundSAMLObjectValidPredicate.java
index 5834449..8fdd57a 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/common/IsTimeboundSAMLObjectValidPredicate.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/common/IsTimeboundSAMLObjectValidPredicate.java
@@ -27,7 +27,7 @@ import com.google.common.base.Predicate;
 public class IsTimeboundSAMLObjectValidPredicate implements Predicate<XMLObject> {
 
     /** {@inheritDoc} */
-    public boolean apply(XMLObject input) {
+    public boolean apply(final XMLObject input) {
         if (input == null) {
             return false;
         }
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/common/SAML2Support.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/common/SAML2Support.java
index ae8c9eb..25dd7b1 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/common/SAML2Support.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/common/SAML2Support.java
@@ -85,7 +85,7 @@ public final class SAML2Support {
      *          was null, otherwise will always be non-null.
      */
     @Nullable public static DateTime getEarliestExpiration(@Nullable final XMLObject xmlObject, 
-            @Nullable DateTime candidateTime, @Nonnull DateTime now) {
+            @Nullable final DateTime candidateTime, @Nonnull final DateTime now) {
         
         DateTime earliestExpiration = candidateTime;
 
@@ -126,8 +126,8 @@ public final class SAML2Support {
      * @return the earliest effective expiration instant of the 2 targets. May be null if the input candiateTime 
      *          was null, otherwise will always be non-null.
      */
-    @Nullable public static DateTime getEarliestExpirationFromCacheable(@Nonnull CacheableSAMLObject cacheableObject, 
-            @Nullable DateTime candidateTime, @Nonnull DateTime now) {
+    @Nullable public static DateTime getEarliestExpirationFromCacheable(@Nonnull final CacheableSAMLObject cacheableObject, 
+            @Nullable final DateTime candidateTime, @Nonnull final DateTime now) {
         
         DateTime earliestExpiration = candidateTime;
 
@@ -155,8 +155,8 @@ public final class SAML2Support {
      * @return the earliest effective expiration instant of the 2 targets. May be null if the input candiateTime 
      *          was null, otherwise will always be non-null.
      */
-    @Nullable public static DateTime getEarliestExpirationFromTimeBound(@Nonnull TimeBoundSAMLObject timeBoundObject, 
-            @Nullable DateTime candidateTime) {
+    @Nullable public static DateTime getEarliestExpirationFromTimeBound(@Nonnull final TimeBoundSAMLObject timeBoundObject, 
+            @Nullable final DateTime candidateTime) {
         
         DateTime earliestExpiration = candidateTime;
         
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/core/AuthnContextComparisonTypeEnumeration.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/core/AuthnContextComparisonTypeEnumeration.java
index 5a67466..9ef735f 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/core/AuthnContextComparisonTypeEnumeration.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/core/AuthnContextComparisonTypeEnumeration.java
@@ -46,7 +46,7 @@ public final class AuthnContextComparisonTypeEnumeration {
      * 
      * @param newComparisonType the comparison type string
      */
-    protected AuthnContextComparisonTypeEnumeration(String newComparisonType) {
+    protected AuthnContextComparisonTypeEnumeration(final String newComparisonType) {
         this.comparisonType= newComparisonType;
     }
 
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/core/DecisionTypeEnumeration.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/core/DecisionTypeEnumeration.java
index 7aa2e65..1a57617 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/core/DecisionTypeEnumeration.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/core/DecisionTypeEnumeration.java
@@ -39,7 +39,7 @@ public final class DecisionTypeEnumeration {
      * 
      * @param newDecisionType the decision type string
      */
-    protected DecisionTypeEnumeration(String newDecisionType) {
+    protected DecisionTypeEnumeration(final String newDecisionType) {
         this.decisionType = newDecisionType;
     }
 
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/encryption/Decrypter.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/encryption/Decrypter.java
index b2bd9d9..959c020 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/encryption/Decrypter.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/encryption/Decrypter.java
@@ -57,7 +57,7 @@ public class Decrypter extends org.opensaml.xmlsec.encryption.support.Decrypter
      *
      * @param params decryption parameters to use
      */
-    public Decrypter(DecryptionParameters params) {
+    public Decrypter(final DecryptionParameters params) {
         super(params);
     }
     
@@ -174,7 +174,7 @@ public class Decrypter extends org.opensaml.xmlsec.encryption.support.Decrypter
         XMLObject xmlObject = null;
         try {
             xmlObject = decryptData(encElement.getEncryptedData(), isRootInNewDocument());
-        } catch (DecryptionException e) {
+        } catch (final DecryptionException e) {
             log.error("SAML Decrypter encountered an error decrypting element content", e);
             throw e; 
         }
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/encryption/EncryptedElementTypeEncryptedKeyResolver.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/encryption/EncryptedElementTypeEncryptedKeyResolver.java
index 120e72d..0f335be 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/encryption/EncryptedElementTypeEncryptedKeyResolver.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/encryption/EncryptedElementTypeEncryptedKeyResolver.java
@@ -60,7 +60,7 @@ public class EncryptedElementTypeEncryptedKeyResolver extends AbstractEncryptedK
     }
 
     /** {@inheritDoc} */
-    public Iterable<EncryptedKey> resolve(EncryptedData encryptedData) {
+    public Iterable<EncryptedKey> resolve(final EncryptedData encryptedData) {
         final List<EncryptedKey> resolvedEncKeys = new ArrayList<>();
         
         if (!(encryptedData.getParent() instanceof EncryptedElementType) ) {
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/encryption/Encrypter.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/encryption/Encrypter.java
index a8e3d59..3c67892 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/encryption/Encrypter.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/encryption/Encrypter.java
@@ -153,7 +153,7 @@ public class Encrypter extends org.opensaml.xmlsec.encryption.support.Encrypter
      * @param dataEncParams the data encryption parameters
      * @param keyEncParams the key encryption parameters
      */
-    public Encrypter(DataEncryptionParameters dataEncParams, List<KeyEncryptionParameters> keyEncParams) {
+    public Encrypter(final DataEncryptionParameters dataEncParams, final List<KeyEncryptionParameters> keyEncParams) {
         super();
 
         this.encParams = dataEncParams;
@@ -168,7 +168,7 @@ public class Encrypter extends org.opensaml.xmlsec.encryption.support.Encrypter
      * @param dataEncParams the data encryption parameters
      * @param keyEncParam the key encryption parameter
      */
-    public Encrypter(DataEncryptionParameters dataEncParams, KeyEncryptionParameters keyEncParam) {
+    public Encrypter(final DataEncryptionParameters dataEncParams, final KeyEncryptionParameters keyEncParam) {
         super();
 
         List<KeyEncryptionParameters> keks = new ArrayList<>();
@@ -185,7 +185,7 @@ public class Encrypter extends org.opensaml.xmlsec.encryption.support.Encrypter
      * 
      * @param dataEncParams the data encryption parameters
      */
-    public Encrypter(DataEncryptionParameters dataEncParams) {
+    public Encrypter(final DataEncryptionParameters dataEncParams) {
         super();
 
         List<KeyEncryptionParameters> keks = new ArrayList<>();
@@ -222,7 +222,7 @@ public class Encrypter extends org.opensaml.xmlsec.encryption.support.Encrypter
      * 
      * @param newIDGenerator the new IdentifierGenerator to use
      */
-    public void setIDGenerator(IdentifierGenerationStrategy newIDGenerator) {
+    public void setIDGenerator(final IdentifierGenerationStrategy newIDGenerator) {
         this.idGenerator = newIDGenerator;
     }
 
@@ -240,7 +240,7 @@ public class Encrypter extends org.opensaml.xmlsec.encryption.support.Encrypter
      * 
      * @param newKeyPlacement The new key placement option to set
      */
-    public void setKeyPlacement(KeyPlacement newKeyPlacement) {
+    public void setKeyPlacement(final KeyPlacement newKeyPlacement) {
         this.keyPlacement = newKeyPlacement;
     }
 
@@ -251,7 +251,7 @@ public class Encrypter extends org.opensaml.xmlsec.encryption.support.Encrypter
      * @return an EncryptedAssertion
      * @throws EncryptionException thrown when encryption generates an error
      */
-    public EncryptedAssertion encrypt(Assertion assertion) throws EncryptionException {
+    public EncryptedAssertion encrypt(final Assertion assertion) throws EncryptionException {
         logPreEncryption(assertion, "Assertion");
         return (EncryptedAssertion) encrypt(assertion, EncryptedAssertion.DEFAULT_ELEMENT_NAME);
     }
@@ -263,7 +263,7 @@ public class Encrypter extends org.opensaml.xmlsec.encryption.support.Encrypter
      * @return an EncryptedID
      * @throws EncryptionException thrown when encryption generates an error
      */
-    public EncryptedID encryptAsID(Assertion assertion) throws EncryptionException {
+    public EncryptedID encryptAsID(final Assertion assertion) throws EncryptionException {
         logPreEncryption(assertion, "Assertion (as EncryptedID)");
         return (EncryptedID) encrypt(assertion, EncryptedID.DEFAULT_ELEMENT_NAME);
     }
@@ -275,7 +275,7 @@ public class Encrypter extends org.opensaml.xmlsec.encryption.support.Encrypter
      * @return an EncryptedAttribute
      * @throws EncryptionException thrown when encryption generates an error
      */
-    public EncryptedAttribute encrypt(Attribute attribute) throws EncryptionException {
+    public EncryptedAttribute encrypt(final Attribute attribute) throws EncryptionException {
         logPreEncryption(attribute, "Attribute");
         return (EncryptedAttribute) encrypt(attribute, EncryptedAttribute.DEFAULT_ELEMENT_NAME);
     }
@@ -287,7 +287,7 @@ public class Encrypter extends org.opensaml.xmlsec.encryption.support.Encrypter
      * @return an EncryptedID
      * @throws EncryptionException thrown when encryption generates an error
      */
-    public EncryptedID encrypt(NameID nameID) throws EncryptionException {
+    public EncryptedID encrypt(final NameID nameID) throws EncryptionException {
         logPreEncryption(nameID, "NameID");
         return (EncryptedID) encrypt(nameID, EncryptedID.DEFAULT_ELEMENT_NAME);
     }
@@ -299,7 +299,7 @@ public class Encrypter extends org.opensaml.xmlsec.encryption.support.Encrypter
      * @return an EncryptedID
      * @throws EncryptionException thrown when encryption generates an error
      */
-    public EncryptedID encrypt(BaseID baseID) throws EncryptionException {
+    public EncryptedID encrypt(final BaseID baseID) throws EncryptionException {
         logPreEncryption(baseID, "BaseID");
         return (EncryptedID) encrypt(baseID, EncryptedID.DEFAULT_ELEMENT_NAME);
     }
@@ -311,7 +311,7 @@ public class Encrypter extends org.opensaml.xmlsec.encryption.support.Encrypter
      * @return a NewEncryptedID
      * @throws EncryptionException thrown when encryption generates an error
      */
-    public NewEncryptedID encrypt(NewID newID) throws EncryptionException {
+    public NewEncryptedID encrypt(final NewID newID) throws EncryptionException {
         logPreEncryption(newID, "NewID");
         return (NewEncryptedID) encrypt(newID, NewEncryptedID.DEFAULT_ELEMENT_NAME);
     }
@@ -322,7 +322,7 @@ public class Encrypter extends org.opensaml.xmlsec.encryption.support.Encrypter
      * @param xmlObject the XMLObject to encrypt
      * @param objectType String description of the type of object to encrypt
      */
-    private void logPreEncryption(XMLObject xmlObject, String objectType) {
+    private void logPreEncryption(final XMLObject xmlObject, final String objectType) {
         if (log.isDebugEnabled()) {
             try {
                 final Element dom = XMLObjectSupport.marshall(xmlObject);
@@ -342,7 +342,7 @@ public class Encrypter extends org.opensaml.xmlsec.encryption.support.Encrypter
      * @return a specialization of {@link org.opensaml.saml.saml2.core.EncryptedElementType}
      * @throws EncryptionException thrown when encryption generates an error
      */
-    private EncryptedElementType encrypt(XMLObject xmlObject, QName encElementName) throws EncryptionException {
+    private EncryptedElementType encrypt(final XMLObject xmlObject, final QName encElementName) throws EncryptionException {
 
         checkParams(encParams, kekParamsList);
 
@@ -367,7 +367,7 @@ public class Encrypter extends org.opensaml.xmlsec.encryption.support.Encrypter
                     .getClass().getName());
             try {
                 encryptedData.setKeyInfo(generator.generate(encParams.getEncryptionCredential()));
-            } catch (SecurityException e) {
+            } catch (final SecurityException e) {
                 throw new EncryptionException("Error generating EncryptedData KeyInfo", e);
             }
         }
@@ -391,8 +391,8 @@ public class Encrypter extends org.opensaml.xmlsec.encryption.support.Encrypter
      * 
      * @throws EncryptionException thrown when processing encounters an error
      */
-    protected EncryptedElementType processElements(EncryptedElementType encElement, EncryptedData encData,
-            List<EncryptedKey> encKeys) throws EncryptionException {
+    protected EncryptedElementType processElements(final EncryptedElementType encElement, final EncryptedData encData,
+            final List<EncryptedKey> encKeys) throws EncryptionException {
         // First ensure certain elements/attributes are non-null, common to all cases.
         if (encData.getID() == null) {
             encData.setID(idGenerator.generateIdentifier());
@@ -435,8 +435,8 @@ public class Encrypter extends org.opensaml.xmlsec.encryption.support.Encrypter
      * @param encKeys the list of EncryptedKey objects
      * @return the processed EncryptedElementType instance
      */
-    protected EncryptedElementType placeKeysInline(EncryptedElementType encElement, EncryptedData encData,
-            List<EncryptedKey> encKeys) {
+    protected EncryptedElementType placeKeysInline(final EncryptedElementType encElement, final EncryptedData encData,
+            final List<EncryptedKey> encKeys) {
 
         log.debug("Placing EncryptedKey elements inline inside EncryptedData");
 
@@ -455,8 +455,8 @@ public class Encrypter extends org.opensaml.xmlsec.encryption.support.Encrypter
      * @param encKeys the EncryptedKey(s) to store
      * @return the resulting specialization of EncryptedElementType
      */
-    protected EncryptedElementType placeKeysAsPeers(EncryptedElementType encElement, EncryptedData encData,
-            List<EncryptedKey> encKeys) {
+    protected EncryptedElementType placeKeysAsPeers(final EncryptedElementType encElement, final EncryptedData encData,
+            final List<EncryptedKey> encKeys) {
 
         log.debug("Placing EncryptedKey elements as peers of EncryptedData in EncryptedElementType");
 
@@ -487,7 +487,7 @@ public class Encrypter extends org.opensaml.xmlsec.encryption.support.Encrypter
      * @param encData the EncryptedData
      * @param encKey the EncryptedKey
      */
-    protected void linkSinglePeerKey(EncryptedData encData, EncryptedKey encKey) {
+    protected void linkSinglePeerKey(final EncryptedData encData, final EncryptedKey encKey) {
         log.debug("Linking single peer EncryptedKey with RetrievalMethod and DataReference");
         // Forward reference from EncryptedData to the EncryptedKey
         RetrievalMethod rm = retrievalMethodBuilder.buildObject();
@@ -507,7 +507,7 @@ public class Encrypter extends org.opensaml.xmlsec.encryption.support.Encrypter
      * @param encData the EncryptedData
      * @param encKeys the list of EncryptedKeys
      */
-    protected void linkMultiplePeerKeys(EncryptedData encData, List<EncryptedKey> encKeys) {
+    protected void linkMultiplePeerKeys(final EncryptedData encData, final List<EncryptedKey> encKeys) {
         log.debug("Linking multiple peer EncryptedKeys with CarriedKeyName and DataReference");
         // Get the name of the data encryption key
         List<KeyName> dataEncKeyNames = encData.getKeyInfo().getKeyNames();
diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/metadata/ContactPersonTypeEnumeration.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/metadata/ContactPersonTypeEnumeration.java
index 7a4d032..385478a 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/metadata/ContactPersonTypeEnumeration.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/metadata/ContactPersonTypeEnumeration.java
@@ -46,7 +46,7 @@ public final class ContactPersonTypeEnumeration {
      * 
      * @param providedType the contact type
      */
-    protected ContactPersonTypeEnumeration(String providedType) {
+    protected ContactPersonTypeEnumeration(final String providedType) {
         type = providedType;
     }
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list