[java-opensaml] 02/02: JPAR-85 - Checkstyle, check final parameters

Tom Zeller tzeller at dragonacea.biz
Tue Aug 8 17:22:22 EDT 2017


This is an automated email from the git hooks/post-receive script.

tzeller pushed a commit to branch master
in repository java-opensaml.

View the commit online:
http://git.shibboleth.net/view/?p=java-opensaml.git;a=commit;h=8777c0a25cb551eb1a9f6f716022e2fbc7a4a6f8

commit 8777c0a25cb551eb1a9f6f716022e2fbc7a4a6f8
Author: Tom Zeller <tzeller at dragonacea.biz>
AuthorDate: Tue Aug 8 16:06:36 2017 -0500

    JPAR-85 - Checkstyle, check final parameters
---
 .../opensaml/profile/action/impl/AbstractMessageChannelSecurity.java  | 2 +-
 .../src/main/java/org/opensaml/profile/action/impl/DecodeMessage.java | 2 +-
 .../profile/action/impl/HttpServletRequestMessageChannelSecurity.java | 2 +-
 .../profile/action/impl/PopulateClientTLSValidationParameters.java    | 2 +-
 .../opensaml/profile/action/impl/PopulateDecryptionParameters.java    | 2 +-
 .../profile/action/impl/PopulateSignatureValidationParameters.java    | 2 +-
 .../opensaml/profile/action/impl/StaticMessageChannelSecurity.java    | 4 ++--
 7 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/opensaml-profile-impl/src/main/java/org/opensaml/profile/action/impl/AbstractMessageChannelSecurity.java b/opensaml-profile-impl/src/main/java/org/opensaml/profile/action/impl/AbstractMessageChannelSecurity.java
index 41f8d5b..1503370 100644
--- a/opensaml-profile-impl/src/main/java/org/opensaml/profile/action/impl/AbstractMessageChannelSecurity.java
+++ b/opensaml-profile-impl/src/main/java/org/opensaml/profile/action/impl/AbstractMessageChannelSecurity.java
@@ -49,7 +49,7 @@ public abstract class AbstractMessageChannelSecurity extends AbstractProfileActi
     public AbstractMessageChannelSecurity() {
         //TODO this just returns the input PRC - need better default?
         parentContextLookupStrategy = new Function<ProfileRequestContext, BaseContext>() {
-            @Nullable public BaseContext apply(@Nullable ProfileRequestContext input) {
+            @Nullable public BaseContext apply(@Nullable final ProfileRequestContext input) {
                 return input;
             }
         };
diff --git a/opensaml-profile-impl/src/main/java/org/opensaml/profile/action/impl/DecodeMessage.java b/opensaml-profile-impl/src/main/java/org/opensaml/profile/action/impl/DecodeMessage.java
index 3bc1bab..82cb215 100644
--- a/opensaml-profile-impl/src/main/java/org/opensaml/profile/action/impl/DecodeMessage.java
+++ b/opensaml-profile-impl/src/main/java/org/opensaml/profile/action/impl/DecodeMessage.java
@@ -69,7 +69,7 @@ public class DecodeMessage extends AbstractProfileAction {
                     msgContext.getMessage().getClass().getName());
 
             profileRequestContext.setInboundMessageContext(msgContext);
-        } catch (MessageDecodingException e) {
+        } catch (final MessageDecodingException e) {
             log.error("{} Unable to decode incoming request", getLogPrefix(), e);
             ActionSupport.buildEvent(profileRequestContext, EventIds.UNABLE_TO_DECODE);
         } finally {
diff --git a/opensaml-profile-impl/src/main/java/org/opensaml/profile/action/impl/HttpServletRequestMessageChannelSecurity.java b/opensaml-profile-impl/src/main/java/org/opensaml/profile/action/impl/HttpServletRequestMessageChannelSecurity.java
index 50b9faf..ebc8051 100644
--- a/opensaml-profile-impl/src/main/java/org/opensaml/profile/action/impl/HttpServletRequestMessageChannelSecurity.java
+++ b/opensaml-profile-impl/src/main/java/org/opensaml/profile/action/impl/HttpServletRequestMessageChannelSecurity.java
@@ -68,7 +68,7 @@ public class HttpServletRequestMessageChannelSecurity extends AbstractMessageCha
 
     /** {@inheritDoc} */
     @Override
-    protected void doExecute(ProfileRequestContext profileRequestContext) {
+    protected void doExecute(final ProfileRequestContext profileRequestContext) {
         final MessageChannelSecurityContext channelContext =
                 getParentContext().getSubcontext(MessageChannelSecurityContext.class, true);
         
diff --git a/opensaml-profile-impl/src/main/java/org/opensaml/profile/action/impl/PopulateClientTLSValidationParameters.java b/opensaml-profile-impl/src/main/java/org/opensaml/profile/action/impl/PopulateClientTLSValidationParameters.java
index 37a1251..1b3c09b 100644
--- a/opensaml-profile-impl/src/main/java/org/opensaml/profile/action/impl/PopulateClientTLSValidationParameters.java
+++ b/opensaml-profile-impl/src/main/java/org/opensaml/profile/action/impl/PopulateClientTLSValidationParameters.java
@@ -129,7 +129,7 @@ public class PopulateClientTLSValidationParameters extends AbstractProfileAction
             throw new ComponentInitializationException("ClientTLSValidationParametersResolver cannot be null");
         } else if (configurationLookupStrategy == null) {
             configurationLookupStrategy = new Function<ProfileRequestContext,List<ClientTLSValidationConfiguration>>() {
-                public List<ClientTLSValidationConfiguration> apply(ProfileRequestContext input) {
+                public List<ClientTLSValidationConfiguration> apply(final ProfileRequestContext input) {
                     return Collections.singletonList(
                             ConfigurationService.get(ClientTLSValidationConfiguration.class));
                 }
diff --git a/opensaml-profile-impl/src/main/java/org/opensaml/profile/action/impl/PopulateDecryptionParameters.java b/opensaml-profile-impl/src/main/java/org/opensaml/profile/action/impl/PopulateDecryptionParameters.java
index 5e25a8e..e96514b 100644
--- a/opensaml-profile-impl/src/main/java/org/opensaml/profile/action/impl/PopulateDecryptionParameters.java
+++ b/opensaml-profile-impl/src/main/java/org/opensaml/profile/action/impl/PopulateDecryptionParameters.java
@@ -125,7 +125,7 @@ public class PopulateDecryptionParameters extends AbstractConditionalProfileActi
             throw new ComponentInitializationException("DecryptionParametersResolver cannot be null");
         } else if (configurationLookupStrategy == null) {
             configurationLookupStrategy = new Function<ProfileRequestContext,List<DecryptionConfiguration>>() {
-                public List<DecryptionConfiguration> apply(ProfileRequestContext input) {
+                public List<DecryptionConfiguration> apply(final ProfileRequestContext input) {
                     return Collections.singletonList(SecurityConfigurationSupport.getGlobalDecryptionConfiguration());
                 }
             };
diff --git a/opensaml-profile-impl/src/main/java/org/opensaml/profile/action/impl/PopulateSignatureValidationParameters.java b/opensaml-profile-impl/src/main/java/org/opensaml/profile/action/impl/PopulateSignatureValidationParameters.java
index 096dfc7..1de12d4 100644
--- a/opensaml-profile-impl/src/main/java/org/opensaml/profile/action/impl/PopulateSignatureValidationParameters.java
+++ b/opensaml-profile-impl/src/main/java/org/opensaml/profile/action/impl/PopulateSignatureValidationParameters.java
@@ -127,7 +127,7 @@ public class PopulateSignatureValidationParameters extends AbstractProfileAction
             throw new ComponentInitializationException("SignatureValidationParametersResolver cannot be null");
         } else if (configurationLookupStrategy == null) {
             configurationLookupStrategy = new Function<ProfileRequestContext,List<SignatureValidationConfiguration>>() {
-                public List<SignatureValidationConfiguration> apply(ProfileRequestContext input) {
+                public List<SignatureValidationConfiguration> apply(final ProfileRequestContext input) {
                     return Collections.singletonList(
                             SecurityConfigurationSupport.getGlobalSignatureValidationConfiguration());
                 }
diff --git a/opensaml-profile-impl/src/main/java/org/opensaml/profile/action/impl/StaticMessageChannelSecurity.java b/opensaml-profile-impl/src/main/java/org/opensaml/profile/action/impl/StaticMessageChannelSecurity.java
index e273a92..adc4aee 100644
--- a/opensaml-profile-impl/src/main/java/org/opensaml/profile/action/impl/StaticMessageChannelSecurity.java
+++ b/opensaml-profile-impl/src/main/java/org/opensaml/profile/action/impl/StaticMessageChannelSecurity.java
@@ -47,7 +47,7 @@ public class StaticMessageChannelSecurity extends AbstractMessageChannelSecurity
      * 
      * @param flag The confidentialityActive to set.
      */
-    public void setConfidentialityActive(boolean flag) {
+    public void setConfidentialityActive(final boolean flag) {
         confidentialityActive = flag;
     }
 
@@ -65,7 +65,7 @@ public class StaticMessageChannelSecurity extends AbstractMessageChannelSecurity
      * 
      * @param flag The integrityActive to set.
      */
-    public void setIntegrityActive(boolean flag) {
+    public void setIntegrityActive(final boolean flag) {
         integrityActive = flag;
     }
     

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list