[java-opensaml] 04/04: JPAR-85 - Checkstyle, check final variables

[Tom Zeller]

This is an automated email from the git hooks/post-receive script.

tzeller pushed a commit to branch master
in repository java-opensaml.

View the commit online:
http://git.shibboleth.net/view/?p=java-opensaml.git;a=commit;h=79bc6c70ba966e6ab50e2171561d9e6f0eb7aefd

commit 79bc6c70ba966e6ab50e2171561d9e6f0eb7aefd
Author: Tom Zeller <tzeller at dragonacea.biz>
AuthorDate: Mon Aug 7 15:51:33 2017 -0500

    JPAR-85 - Checkstyle, check final variables
---
 .../org/opensaml/messaging/handler/impl/BasicMessageHandlerChain.java | 4 ++--
 .../opensaml/messaging/handler/impl/HTTPRequestValidationHandler.java | 4 ++--
 .../messaging/handler/impl/MessageHandlerErrorStrategyAdapter.java    | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/opensaml-messaging-impl/src/main/java/org/opensaml/messaging/handler/impl/BasicMessageHandlerChain.java b/opensaml-messaging-impl/src/main/java/org/opensaml/messaging/handler/impl/BasicMessageHandlerChain.java
index 1c5484c..42b8fb2 100644
--- a/opensaml-messaging-impl/src/main/java/org/opensaml/messaging/handler/impl/BasicMessageHandlerChain.java
+++ b/opensaml-messaging-impl/src/main/java/org/opensaml/messaging/handler/impl/BasicMessageHandlerChain.java
@@ -72,7 +72,7 @@ public class BasicMessageHandlerChain<MessageType> extends AbstractMessageHandle
      */
     public void setHandlers(@Nullable @NonnullElements final List<MessageHandler<MessageType>> handlers) {
         if (handlers != null) {
-            ArrayList<MessageHandler<MessageType>> newMembers = new ArrayList<>();
+            final ArrayList<MessageHandler<MessageType>> newMembers = new ArrayList<>();
             newMembers.addAll(Collections2.filter(handlers, Predicates.notNull()));
             members = newMembers;
         } else {
@@ -83,7 +83,7 @@ public class BasicMessageHandlerChain<MessageType> extends AbstractMessageHandle
     /** {@inheritDoc} */
     public void doInvoke(@Nonnull final MessageContext<MessageType> msgContext) throws MessageHandlerException {
         if (members != null) {
-            for (MessageHandler handler: members) {
+            for (final MessageHandler handler: members) {
                 handler.invoke(msgContext);
             }
         }
diff --git a/opensaml-messaging-impl/src/main/java/org/opensaml/messaging/handler/impl/HTTPRequestValidationHandler.java b/opensaml-messaging-impl/src/main/java/org/opensaml/messaging/handler/impl/HTTPRequestValidationHandler.java
index 2577388..e783ea1 100644
--- a/opensaml-messaging-impl/src/main/java/org/opensaml/messaging/handler/impl/HTTPRequestValidationHandler.java
+++ b/opensaml-messaging-impl/src/main/java/org/opensaml/messaging/handler/impl/HTTPRequestValidationHandler.java
@@ -155,7 +155,7 @@ public class HTTPRequestValidationHandler extends AbstractMessageHandler {
      * @throws MessageHandlerException thrown if the content type was an unexpected value
      */
     protected void evaluateContentType(final HttpServletRequest request) throws MessageHandlerException {
-        String transportContentType = request.getHeader("Content-Type");
+        final String transportContentType = request.getHeader("Content-Type");
         if (getRequiredContentType() != null && !transportContentType.startsWith(getRequiredContentType())) {
             log.error("Invalid content type, expected '{}' but was '{}'", getRequiredContentType(), 
                     transportContentType);
@@ -172,7 +172,7 @@ public class HTTPRequestValidationHandler extends AbstractMessageHandler {
      * @throws MessageHandlerException thrown if the request method was an unexpected value
      */
     protected void evaluateRequestMethod(final HttpServletRequest request) throws MessageHandlerException {
-        String transportMethod = request.getMethod();
+        final String transportMethod = request.getMethod();
         if (getRequiredRequestMethod() != null && !transportMethod.equalsIgnoreCase(getRequiredRequestMethod())) {
             log.error("Invalid request method, expected '{}' but was '{}'", getRequiredRequestMethod(), 
                     transportMethod);
diff --git a/opensaml-messaging-impl/src/main/java/org/opensaml/messaging/handler/impl/MessageHandlerErrorStrategyAdapter.java b/opensaml-messaging-impl/src/main/java/org/opensaml/messaging/handler/impl/MessageHandlerErrorStrategyAdapter.java
index 66ab412..0ae772e 100644
--- a/opensaml-messaging-impl/src/main/java/org/opensaml/messaging/handler/impl/MessageHandlerErrorStrategyAdapter.java
+++ b/opensaml-messaging-impl/src/main/java/org/opensaml/messaging/handler/impl/MessageHandlerErrorStrategyAdapter.java
@@ -127,10 +127,10 @@ public class MessageHandlerErrorStrategyAdapter<MessageType> extends AbstractMes
             wrappedHandler.invoke(messageContext);
         } catch (final Throwable t) {
             log.trace("Wrapped message handler threw error", t);
-            for (TypedMessageErrorHandler errorHandler : errorHandlers) {
+            for (final TypedMessageErrorHandler errorHandler : errorHandlers) {
                 if (errorHandler.handlesError(t)) {
                     log.trace("Handler indicates it can handle the error: {}", errorHandler.getClass().getName());
-                    boolean handled = errorHandler.handleError(t, messageContext);
+                    final boolean handled = errorHandler.handleError(t, messageContext);
                     log.trace("Handler's indication whether it actually handled the error: {}", handled);
                     if (handled) {
                         if (rethrowIfHandled) {

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.