[spring-extensions] branch master updated: JPAR-85 - Check final parameters and local variables

[Tom Zeller]

This is an automated email from the git hooks/post-receive script.

tzeller pushed a commit to branch master
in repository spring-extensions.

View the commit online:
http://git.shibboleth.net/view/?p=spring-extensions.git;a=commit;h=e2935f72a8919a5fa2b6f9440ba1bd432f9e06a8

The following commit(s) were added to refs/heads/master by this push:
       new  e2935f7   JPAR-85 - Check final parameters and local variables
e2935f7 is described below

commit e2935f72a8919a5fa2b6f9440ba1bd432f9e06a8
Author: Tom Zeller <tzeller at dragonacea.biz>
AuthorDate: Sat Sep 24 18:49:10 2016 -0500

    JPAR-85 - Check final parameters and local variables
---
 checkstyle.xml                                                     | 7 +++++++
 src/main/java/net/shibboleth/ext/spring/resource/HTTPResource.java | 2 +-
 src/main/java/net/shibboleth/ext/spring/resource/SVNResource.java  | 2 +-
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/checkstyle.xml b/checkstyle.xml
index 431ea7b..32b206c 100644
--- a/checkstyle.xml
+++ b/checkstyle.xml
@@ -92,6 +92,13 @@
     <module name="TrailingComment"/>
     <module name="EqualsAvoidNull"/>
     <module name="ModifiedControlVariable"/>
+    <module name="FinalParameters">
+      <property name="tokens" value="METHOD_DEF,CTOR_DEF,LITERAL_CATCH"/>
+    </module>
+    <module name="FinalLocalVariable">
+      <property name="tokens" value="PARAMETER_DEF,VARIABLE_DEF"/>
+      <property name="validateEnhancedForLoopVariable" value="true"/>
+    </module>
   </module>
   <module name="SuppressionCommentFilter">
     <property name="offCommentFormat" value="\bCheck[Ss]tyle:\s*([\w|]+)\s+OFF\b"/>
diff --git a/src/main/java/net/shibboleth/ext/spring/resource/HTTPResource.java b/src/main/java/net/shibboleth/ext/spring/resource/HTTPResource.java
index 57e31ab..285ae9d 100644
--- a/src/main/java/net/shibboleth/ext/spring/resource/HTTPResource.java
+++ b/src/main/java/net/shibboleth/ext/spring/resource/HTTPResource.java
@@ -304,7 +304,7 @@ public class HTTPResource extends AbstractIdentifiedInitializableComponent imple
 
     /** {@inheritDoc} Based on {@link org.springframework.core.io.UrlResource}. */
     @Override public HTTPResource createRelative(final String relativePath) throws IOException {
-        String path;
+        final String path;
         if (relativePath.startsWith("/")) {
             path = relativePath.substring(1);
         } else {
diff --git a/src/main/java/net/shibboleth/ext/spring/resource/SVNResource.java b/src/main/java/net/shibboleth/ext/spring/resource/SVNResource.java
index 0c6d61b..ce4b3f9 100644
--- a/src/main/java/net/shibboleth/ext/spring/resource/SVNResource.java
+++ b/src/main/java/net/shibboleth/ext/spring/resource/SVNResource.java
@@ -233,7 +233,7 @@ public class SVNResource extends AbstractIdentifiedInitializableComponent implem
      */
     protected void checkoutOrUpdateResource() throws IOException {
         log.debug("checking out or updating working copy");
-        SVNRevision newRevision;
+        final SVNRevision newRevision;
 
         if (!workingCopyDirectoryExists()) {
             log.debug("Working copy does not yet exist, checking it out to {}", workingCopyDirectory.getAbsolutePath());

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.