[java-identity-provider COMMIT] in /trunk: idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/WebFlowMess...

[noreply at shibboleth.net]

Author: rdw
Date: Fri Sep  9 10:14:08 2016
New Revision: 8382

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=8382&view=rev
Log:
CheckStyle

Modified:
    trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/WebFlowMessageHandlerAdaptor.java
    trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/saml/impl/BaseSAMLProfileConfigurationParser.java
    trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/saml/impl/SAML2BrowserSSOProfileParser.java
    trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/saml/impl/ShibbolethSSOProfileParser.java

Modified: trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/WebFlowMessageHandlerAdaptor.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/WebFlowMessageHandlerAdaptor.java?rev=8382&r1=8381&r2=8382&view=diff
==============================================================================
--- trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/WebFlowMessageHandlerAdaptor.java	(original)
+++ trunk/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/WebFlowMessageHandlerAdaptor.java	Fri Sep  9 10:14:08 2016
@@ -135,8 +135,8 @@
     }
     
     /** {@inheritDoc} */
-    @Override
-    public void doExecute(@Nonnull final ProfileRequestContext profileRequestContext) {
+//CheckStyle: ReturnCount OFF
+    @Override public void doExecute(@Nonnull final ProfileRequestContext profileRequestContext) {
         ComponentSupport.ifNotInitializedThrowUninitializedComponentException(this);
         
         if (handler == null) {
@@ -187,5 +187,6 @@
             }
         }
     }
+  //CheckStyle: ReturnCount ON
 
  }

Modified: trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/saml/impl/BaseSAMLProfileConfigurationParser.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/saml/impl/BaseSAMLProfileConfigurationParser.java?rev=8382&r1=8381&r2=8382&view=diff
==============================================================================
--- trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/saml/impl/BaseSAMLProfileConfigurationParser.java	(original)
+++ trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/saml/impl/BaseSAMLProfileConfigurationParser.java	Fri Sep  9 10:14:08 2016
@@ -70,7 +70,7 @@
      * @return the builder.
      * 
      */
-    @Nullable protected BeanDefinition getArtifactConfiguration(Element element) {
+    @Nullable protected BeanDefinition getArtifactConfiguration(final Element element) {
 
         final BeanDefinitionBuilder definition =
                 BeanDefinitionBuilder.genericBeanDefinition(BasicSAMLArtifactConfiguration.class);
@@ -105,9 +105,9 @@
      *            {@link LegacyEncryptionRequirementPredicate}
      * @return the bean for the appropriate predicate.
      */
-    @Nonnull private BeanDefinition predicateFor(@Nullable String value, Class<? extends Predicate> claz) {
-
-        BeanDefinitionBuilder builder = BeanDefinitionBuilder.genericBeanDefinition(claz);
+    @Nonnull private BeanDefinition predicateFor(@Nullable final String value, final Class<? extends Predicate> claz) {
+
+        final BeanDefinitionBuilder builder = BeanDefinitionBuilder.genericBeanDefinition(claz);
         builder.addConstructorArgValue(StringSupport.trimOrNull(value));
 
         return builder.getBeanDefinition();
@@ -119,7 +119,7 @@
      * @param value the value
      * @return the definition of an appropriate {@link LegacySigningRequirementPredicate}
      */
-    @Nonnull protected BeanDefinition predicateForSigning(@Nullable String value) {
+    @Nonnull protected BeanDefinition predicateForSigning(@Nullable final String value) {
         return predicateFor(value, LegacySigningRequirementPredicate.class);
     }
 
@@ -129,7 +129,7 @@
      * @param value the value
      * @return the definition of an appropriate {@link LegacyEncryptionRequirementPredicate}
      */
-    @Nonnull protected BeanDefinition predicateForEncryption(@Nullable String value) {
+    @Nonnull protected BeanDefinition predicateForEncryption(@Nullable final String value) {
         return predicateFor(value, LegacyEncryptionRequirementPredicate.class);
     }
 
@@ -139,8 +139,8 @@
      * @param element the element under discussion
      * @return the list of elements (which are subject to property replacement)
      */
-    protected List<String> getAudiences(Element element) {
-        List<Element> audienceElems =
+    protected List<String> getAudiences(final Element element) {
+        final List<Element> audienceElems =
                 ElementSupport.getChildElementsByTagNameNS(element, RelyingPartySAMLNamespaceHandler.NAMESPACE,
                         "Audience");

[... 108 lines stripped ...]