[java-identity-provider COMMIT] /trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/ExternalAuthentication.java

noreply at shibboleth.net noreply at shibboleth.net
Fri Sep 2 21:08:32 EDT 2016


Author: scantor
Date: Fri Sep  2 21:08:31 2016
New Revision: 8369

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=8369&view=rev
Log:
Switch to Guava form parameter encoder.

Modified:
    trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/ExternalAuthentication.java

Modified: trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/ExternalAuthentication.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/ExternalAuthentication.java?rev=8369&r1=8368&r2=8369&view=diff
==============================================================================
--- trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/ExternalAuthentication.java	(original)
+++ trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/ExternalAuthentication.java	Fri Sep  2 21:08:31 2016
@@ -25,9 +25,10 @@
 
 import org.opensaml.profile.context.ProfileRequestContext;
 
+import com.google.common.net.UrlEscapers;
+
 import net.shibboleth.utilities.java.support.annotation.constraint.NotEmpty;
 import net.shibboleth.utilities.java.support.logic.Constraint;
-import net.shibboleth.utilities.java.support.net.URISupport;
 
 /** Public interface supporting external authentication outside the webflow engine. */
 public class ExternalAuthentication {
@@ -104,7 +105,8 @@
         
         // Add a parameter separator for the conversation ID.
         url.append(baseLocation.indexOf('?') == -1 ? '?' : '&');
-        url.append(CONVERSATION_KEY).append('=').append(URISupport.doURLEncode(conversationValue));
+        url.append(CONVERSATION_KEY).append('=').append(
+                UrlEscapers.urlFormParameterEscaper().escape(conversationValue));
         
         return url.toString();
     }



More information about the commits mailing list